[GitHub] yanghua commented on issue #6850: [FLINK-10252] Handle oversized metric messges

2018-11-29 Thread GitBox
yanghua commented on issue #6850: [FLINK-10252] Handle oversized metric messges URL: https://github.com/apache/flink/pull/6850#issuecomment-443107471 @zentol This is an automated message from the Apache Git Service. To

[GitHub] yanghua commented on issue #6850: [FLINK-10252] Handle oversized metric messges

2018-11-21 Thread GitBox
yanghua commented on issue #6850: [FLINK-10252] Handle oversized metric messges URL: https://github.com/apache/flink/pull/6850#issuecomment-440644349 @zentol This is an automated message from the Apache Git Service. To

[GitHub] yanghua commented on issue #6850: [FLINK-10252] Handle oversized metric messges

2018-11-09 Thread GitBox
yanghua commented on issue #6850: [FLINK-10252] Handle oversized metric messges URL: https://github.com/apache/flink/pull/6850#issuecomment-437288416 @zentol Can you give a final check about this PR? thanks. This is an

[GitHub] yanghua commented on issue #6850: [FLINK-10252] Handle oversized metric messges

2018-11-05 Thread GitBox
yanghua commented on issue #6850: [FLINK-10252] Handle oversized metric messges URL: https://github.com/apache/flink/pull/6850#issuecomment-435814056 @zentol This is an automated message from the Apache Git Service. To

[GitHub] yanghua commented on issue #6850: [FLINK-10252] Handle oversized metric messges

2018-11-01 Thread GitBox
yanghua commented on issue #6850: [FLINK-10252] Handle oversized metric messges URL: https://github.com/apache/flink/pull/6850#issuecomment-434975263 @zentol This is an automated message from the Apache Git Service. To

[GitHub] yanghua commented on issue #6850: [FLINK-10252] Handle oversized metric messges

2018-10-24 Thread GitBox
yanghua commented on issue #6850: [FLINK-10252] Handle oversized metric messges URL: https://github.com/apache/flink/pull/6850#issuecomment-432624709 @zentol If you can give a review suggestion as soon as possible, then I can refactor it quickly so that it catches up with 1.7.0.

[GitHub] yanghua commented on issue #6850: [FLINK-10252] Handle oversized metric messges

2018-10-23 Thread GitBox
yanghua commented on issue #6850: [FLINK-10252] Handle oversized metric messges URL: https://github.com/apache/flink/pull/6850#issuecomment-432215589 In fact, Travis has been built successfully. This is an automated message

[GitHub] yanghua commented on issue #6850: [FLINK-10252] Handle oversized metric messges

2018-10-22 Thread GitBox
yanghua commented on issue #6850: [FLINK-10252] Handle oversized metric messges URL: https://github.com/apache/flink/pull/6850#issuecomment-431885641 Hi @zentol It seems I still can not trigger the Travis to rebuild. Can you review my latest change firstly?

[GitHub] yanghua commented on issue #6850: [FLINK-10252] Handle oversized metric messges

2018-10-19 Thread GitBox
yanghua commented on issue #6850: [FLINK-10252] Handle oversized metric messges URL: https://github.com/apache/flink/pull/6850#issuecomment-431261877 Hi @zentol I have not add test for the new implementation, but can you review it firstly so that it can match your requirement? Thanks.

[GitHub] yanghua commented on issue #6850: [FLINK-10252] Handle oversized metric messges

2018-10-18 Thread GitBox
yanghua commented on issue #6850: [FLINK-10252] Handle oversized metric messges URL: https://github.com/apache/flink/pull/6850#issuecomment-430892698 @zentol About the `MetricRegistryConfiguration` I have reverted, please review.

[GitHub] yanghua commented on issue #6850: [FLINK-10252] Handle oversized metric messges

2018-10-17 Thread GitBox
yanghua commented on issue #6850: [FLINK-10252] Handle oversized metric messges URL: https://github.com/apache/flink/pull/6850#issuecomment-430600731 @zentol What do you think of this change? It may cause the last serialized metric to exceed the specified size (overflow). Do you think we

[GitHub] yanghua commented on issue #6850: [FLINK-10252] Handle oversized metric messges

2018-10-16 Thread GitBox
yanghua commented on issue #6850: [FLINK-10252] Handle oversized metric messges URL: https://github.com/apache/flink/pull/6850#issuecomment-430124087 @zentol What about this change? This is an automated message from the