[GitHub] yanghua commented on issue #7038: [FLINK-10791] Provide end-to-end test for Kafka 0.11 connector
yanghua commented on issue #7038: [FLINK-10791] Provide end-to-end test for Kafka 0.11 connector URL: https://github.com/apache/flink/pull/7038#issuecomment-440177013 @pnowojski How about providing a `flink-examples/flink-examples-e2e` module to place these end-to-end examples? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yanghua commented on issue #7038: [FLINK-10791] Provide end-to-end test for Kafka 0.11 connector
yanghua commented on issue #7038: [FLINK-10791] Provide end-to-end test for Kafka 0.11 connector URL: https://github.com/apache/flink/pull/7038#issuecomment-439946559 I agree that it doesn't make much sense to add Kafka example to Flink binary. Examples released with Flink binary should be as simple and easy to use as possible, and should not include dependencies on other systems. @tillrohrmann However, I do not recommend that we continue to keep the source code of Kafka example in `flink-examples'(and then let the E2E module depend on it). This module should be mainly used to demonstrate the capabilities (operators) provided by flink, not connectors. I think we can use the original Kafka example for E2E testing and leave it in the E2E module. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yanghua commented on issue #7038: [FLINK-10791] Provide end-to-end test for Kafka 0.11 connector
yanghua commented on issue #7038: [FLINK-10791] Provide end-to-end test for Kafka 0.11 connector URL: https://github.com/apache/flink/pull/7038#issuecomment-439877741 I think @tillrohrmann means that we don't want the e2e test to rely on `flink-dist`. This way we can run `flink-end-to-end-tests` directly without packaging the entire project. But @pnowojski 's considerations are also correct. If we still need to provide an example of the Kafka connector in `flink-examples`, it will cause some code duplication. I personally feel that temporary code duplication is acceptable. Over time, e2e's code may change and evolve independently (to test more features). What do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yanghua commented on issue #7038: [FLINK-10791] Provide end-to-end test for Kafka 0.11 connector
yanghua commented on issue #7038: [FLINK-10791] Provide end-to-end test for Kafka 0.11 connector URL: https://github.com/apache/flink/pull/7038#issuecomment-439790249 @tillrohrmann I agree with your opinion. I have created a new issue (FLINK-10922) to rework specific modules (0.10, 0.11 and 2.0). Will submit PR as soon as possible. cc @pnowojski This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yanghua commented on issue #7038: [FLINK-10791] Provide end-to-end test for Kafka 0.11 connector
yanghua commented on issue #7038: [FLINK-10791] Provide end-to-end test for Kafka 0.11 connector URL: https://github.com/apache/flink/pull/7038#issuecomment-436593846 Yes, I also encountered this problem. The first time I forgot to add the Apache License to the pom file, but when I added it, it still failed twice and finally succeeded. This PR does not seem to have missing license information. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yanghua commented on issue #7038: [FLINK-10791] Provide end-to-end test for Kafka 0.11 connector
yanghua commented on issue #7038: [FLINK-10791] Provide end-to-end test for Kafka 0.11 connector URL: https://github.com/apache/flink/pull/7038#issuecomment-436561044 @pnowojski @aljoscha can you review this PR? thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
