[GitHub] zentol commented on issue #7098: [FLINK-10869] [build] Update S3 tests to reference new access key environment variables.

2018-11-14 Thread GitBox
zentol commented on issue #7098: [FLINK-10869] [build] Update S3 tests to 
reference new access key environment variables.
URL: https://github.com/apache/flink/pull/7098#issuecomment-438748425
 
 
   btw, for verifying this change we can push it to a separate branch in the 
apache repo.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] zentol commented on issue #7098: [FLINK-10869] [build] Update S3 tests to reference new access key environment variables.

2018-11-14 Thread GitBox
zentol commented on issue #7098: [FLINK-10869] [build] Update S3 tests to 
reference new access key environment variables.
URL: https://github.com/apache/flink/pull/7098#issuecomment-438746732
 
 
   @dawidwys 
   * all S3 tests already check whether credentials are provided, and if not 
are skipped via assumptions
   * this does not change anything in terms of behavior; these tests were 
always only run in the Apache Flink Travis


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services