[GitHub] zhijiangW commented on issue #7146: [FLINK-10942][network, test] Deduplicate common codes in OutputEmitterTest

2018-11-22 Thread GitBox 
zhijiangW commented on issue #7146: [FLINK-10942][network,test] Deduplicate 
common codes in OutputEmitterTest
URL: https://github.com/apache/flink/pull/7146#issuecomment-440970986
 
 
   @pnowojski , thanks for helpful reviews!
   I almost agree with all your above comments except the short loop way I 
mentioned inline.
   I already submit another hotfix for addressing all the issues, wish not 
missing anything. :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zhijiangW commented on issue #7146: [FLINK-10942][network, test] Deduplicate common codes in OutputEmitterTest

2018-11-19 Thread GitBox 
zhijiangW commented on issue #7146: [FLINK-10942][network,test] Deduplicate 
common codes in OutputEmitterTest
URL: https://github.com/apache/flink/pull/7146#issuecomment-440170847
 
 
   cc @pnowojski 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services