Re: [PR] [FLINK-33365][BP-3.1] include filters with Lookup joins [flink-connector-jdbc]

2024-01-26 Thread via GitHub
snuyanzin commented on PR #96: URL: https://github.com/apache/flink-connector-jdbc/pull/96#issuecomment-1912126016 superceded by #97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-33365][BP-3.1] include filters with Lookup joins [flink-connector-jdbc]

2024-01-26 Thread via GitHub
snuyanzin closed pull request #96: [FLINK-33365][BP-3.1] include filters with Lookup joins URL: https://github.com/apache/flink-connector-jdbc/pull/96 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-33365][BP-3.1] include filters with Lookup joins [flink-connector-jdbc]

2024-01-26 Thread via GitHub
davidradl commented on PR #96: URL: https://github.com/apache/flink-connector-jdbc/pull/96#issuecomment-1912118063 @snuyanzin I did the same with https://github.com/apache/flink-connector-jdbc/pull/97 . I cherry picked and fixed up the conflict in one commit. I can close my pr if you are

Re: [PR] [FLINK-33365][BP-3.1] include filters with Lookup joins [flink-connector-jdbc]

2024-01-26 Thread via GitHub
snuyanzin commented on PR #96: URL: https://github.com/apache/flink-connector-jdbc/pull/96#issuecomment-1912058646 @davidradl could you please have a look here I created a backport of #79 it was not a cherry-pick because of some inconsistent changes between branches -- This is an