Re: [PR] [FLINK-33609] Take into account the resource limit specified in the pod template. [flink]

2023-11-26 Thread via GitHub
surendralilhore commented on PR #23768: URL: https://github.com/apache/flink/pull/23768#issuecomment-1826843398 There is one more Jira to fix this issue in better way : [FLINK-33548](https://issues.apache.org/jira/browse/FLINK-33548) -- This is an automated message from the Apache Git

Re: [PR] [FLINK-33609] Take into account the resource limit specified in the pod template. [flink]

2023-11-26 Thread via GitHub
surendralilhore closed pull request #23768: [FLINK-33609] Take into account the resource limit specified in the pod template. URL: https://github.com/apache/flink/pull/23768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-33609] Take into account the resource limit specified in the pod template. [flink]

2023-11-23 Thread via GitHub
surendralilhore commented on PR #23768: URL: https://github.com/apache/flink/pull/23768#issuecomment-1824329775 Thanks @gyfora for review. I will send the discussion mail in community. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-33609] Take into account the resource limit specified in the pod template. [flink]

2023-11-22 Thread via GitHub
gyfora commented on PR #23768: URL: https://github.com/apache/flink/pull/23768#issuecomment-1823921369 Since this will considerably change the resource handling I think we need to have at least a quick discussion on this in the dev list. Furthermore the logic should be consistent for the

Re: [PR] [FLINK-33609] Take into account the resource limit specified in the pod template. [flink]

2023-11-22 Thread via GitHub
gyfora commented on code in PR #23768: URL: https://github.com/apache/flink/pull/23768#discussion_r1402993805 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/utils/KubernetesUtils.java: ## @@ -367,10 +367,24 @@ public static ResourceRequirements

Re: [PR] [FLINK-33609] Take into account the resource limit specified in the pod template. [flink]

2023-11-21 Thread via GitHub
surendralilhore commented on PR #23768: URL: https://github.com/apache/flink/pull/23768#issuecomment-1821341423 @gyfora Please can you help me to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [FLINK-33609] Take into account the resource limit specified in the pod template. [flink]

2023-11-21 Thread via GitHub
flinkbot commented on PR #23768: URL: https://github.com/apache/flink/pull/23768#issuecomment-1821007113 ## CI report: * bbf51c6e8a359305f3e0d67cf0ece9bc7240070f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33609] Take into account the resource limit specified in the pod template. [flink]

2023-11-21 Thread via GitHub
surendralilhore opened a new pull request, #23768: URL: https://github.com/apache/flink/pull/23768 Flink is currently not considering the pod template resource limits and is only utilizing the limit obtained from the configured or default limit factor. Flink should consider both the value