Re: [PR] [FLINK-33853][runtime][JUnit5 Migration] Migrate Junit5 for DeclarativeSlotPoolBridge test classes of runtime module [flink]

2023-12-15 Thread via GitHub
1996fanrui merged PR #23932: URL: https://github.com/apache/flink/pull/23932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33853][runtime][JUnit5 Migration] Migrate Junit5 for DeclarativeSlotPoolBridge test classes of runtime module [flink]

2023-12-15 Thread via GitHub
RocMarshal commented on code in PR #23932: URL: https://github.com/apache/flink/pull/23932#discussion_r1427882696 ## flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolBridgeResourceDeclarationTest.java: ## @@ -141,40 +137,38 @@ public

Re: [PR] [FLINK-33853][runtime][JUnit5 Migration] Migrate Junit5 for DeclarativeSlotPoolBridge test classes of runtime module [flink]

2023-12-15 Thread via GitHub
1996fanrui commented on code in PR #23932: URL: https://github.com/apache/flink/pull/23932#discussion_r1427755866 ## flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolBridgeRequestCompletionTest.java: ## @@ -43,27 +44,24 @@ import

Re: [PR] [FLINK-33853][runtime][JUnit5 Migration] Migrate Junit5 for DeclarativeSlotPoolBridge test classes of runtime module [flink]

2023-12-15 Thread via GitHub
RocMarshal commented on PR #23932: URL: https://github.com/apache/flink/pull/23932#issuecomment-1857550752 Hi, @1996fanrui Could you help review this pr if you're in the free time? Thank you~ -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [FLINK-33853][runtime][JUnit5 Migration] Migrate Junit5 for DeclarativeSlotPoolBridge test classes of runtime module [flink]

2023-12-14 Thread via GitHub
flinkbot commented on PR #23932: URL: https://github.com/apache/flink/pull/23932#issuecomment-1857412172 ## CI report: * bd328df2d2f1dea0cbe121e16a83734451e19306 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33853][runtime][JUnit5 Migration] Migrate Junit5 for DeclarativeSlotPoolBridge test classes of runtime module [flink]

2023-12-14 Thread via GitHub
RocMarshal opened a new pull request, #23932: URL: https://github.com/apache/flink/pull/23932 ## What is the purpose of the change [FLINK-33853][runtime][JUnit5 Migration] Migrate Junit5 for DeclarativeSlotPoolBridge test classes of runtime module ## Brief