Re: [PR] [FLINK-34015][checkpoint] fix that passing ignore-unclaimed-state through dynamic props does not take effect [flink]

Zakelly commented on PR #24058: URL: https://github.com/apache/flink/pull/24058#issuecomment-1954473980 Sorry for jumping in but I have mixed feelings... Is this a common problem that also applies for other options and shall we implement a generic solution for all similar options. --

Re: [PR] [FLINK-34015][checkpoint] fix that passing ignore-unclaimed-state through dynamic props does not take effect [flink]

xiangforever2014 commented on PR #24058: URL: https://github.com/apache/flink/pull/24058#issuecomment-1915983655 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-34015][checkpoint] fix that passing ignore-unclaimed-state through dynamic props does not take effect [flink]

xiangforever2014 commented on PR #24058: URL: https://github.com/apache/flink/pull/24058#issuecomment-1908037053 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-34015][checkpoint] fix that passing ignore-unclaimed-state through dynamic props does not take effect [flink]

xiangforever2014 commented on PR #24058: URL: https://github.com/apache/flink/pull/24058#issuecomment-1907643393 > Thanks for the pr. PTAL my comments. BTW, Could we also provide a UT to verify this ? Sorry to reply so late, I have refactor the code according to your comments, and

Re: [PR] [FLINK-34015][checkpoint] fix that passing ignore-unclaimed-state through dynamic props does not take effect [flink]

xiangforever2014 commented on code in PR #24058: URL: https://github.com/apache/flink/pull/24058#discussion_r1464515517 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/SavepointRestoreSettings.java: ## @@ -163,14 +163,16 @@ public static

Re: [PR] [FLINK-34015][checkpoint] fix that passing ignore-unclaimed-state through dynamic props does not take effect [flink]

masteryhx commented on code in PR #24058: URL: https://github.com/apache/flink/pull/24058#discussion_r1450021637 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/SavepointRestoreSettings.java: ## @@ -163,14 +163,16 @@ public static SavepointRestoreSettings

Re: [PR] [FLINK-34015][checkpoint] fix that passing ignore-unclaimed-state through dynamic props does not take effect [flink]

xiangforever2014 commented on code in PR #24058: URL: https://github.com/apache/flink/pull/24058#discussion_r1448416625 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/SavepointRestoreSettings.java: ## @@ -163,14 +163,16 @@ public static

Re: [PR] [FLINK-34015][checkpoint] fix that passing ignore-unclaimed-state through dynamic props does not take effect [flink]

masteryhx commented on code in PR #24058: URL: https://github.com/apache/flink/pull/24058#discussion_r1448208494 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/SavepointRestoreSettings.java: ## @@ -163,14 +163,16 @@ public static SavepointRestoreSettings

Re: [PR] [FLINK-34015][checkpoint] fix that passing ignore-unclaimed-state through dynamic props does not take effect [flink]

flinkbot commented on PR #24058: URL: https://github.com/apache/flink/pull/24058#issuecomment-1884262593 ## CI report: * 364c3e2b9a652e85d36a76934f59f2c93520d560 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-34015][checkpoint] fix that passing ignore-unclaimed-state through dynamic props does not take effect [flink]

xiangforever2014 opened a new pull request, #24058: URL: https://github.com/apache/flink/pull/24058 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid