Re: [PR] [FLINK-34149][Runtime/Checkpointing] Fix SplitEnumeratorContext compatibility issue [flink]
lindong28 merged PR #24146: URL: https://github.com/apache/flink/pull/24146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34149][Runtime/Checkpointing] Fix SplitEnumeratorContext compatibility issue [flink]
lindong28 commented on PR #24146: URL: https://github.com/apache/flink/pull/24146#issuecomment-1899635755 Thanks for the PR! LGTM. Will merge PR after the CI has passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34149][Runtime/Checkpointing] Fix SplitEnumeratorContext compatibility issue [flink]
flinkbot commented on PR #24146: URL: https://github.com/apache/flink/pull/24146#issuecomment-1899616723 ## CI report: * a9ab0eaa9f38ddca0f6ba23c450ececb33acc7ee UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34149][Runtime/Checkpointing] Fix SplitEnumeratorContext compatibility issue [flink]
yunfengzhou-hub commented on PR #24146: URL: https://github.com/apache/flink/pull/24146#issuecomment-1899595132 Hi @lindong28, could you please take a look at this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [FLINK-34149][Runtime/Checkpointing] Fix SplitEnumeratorContext compatibility issue [flink]
yunfengzhou-hub opened a new pull request, #24146: URL: https://github.com/apache/flink/pull/24146 ## What is the purpose of the change This PR adds a default implementation to SplitEnumeratorContext#setIsProcessingBacklog to fix the compatibility issue introduced in #22931. ## Brief change log - Adds a default implementation to SplitEnumeratorContext#setIsProcessingBacklog. ## Verifying this change It has been verified that the flink-connector-kafka repo will not throw compatibility exception about this method when building against flink-1.19-snapshot after the changes in this PR are introduced. The build would still fail due to other API-incompatible changes, though, and those changes are not related to #22931. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
