Re: [PR] [FLINK-34180][docs] Migrate doc website from ververica to flink [flink-web]
PatrickRen merged PR #722: URL: https://github.com/apache/flink-web/pull/722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34180][docs] Migrate doc website from ververica to flink [flink-web]
PatrickRen commented on code in PR #722: URL: https://github.com/apache/flink-web/pull/722#discussion_r1522749858 ## docs/content.zh/documentation/flink-cdc-master.md: ## @@ -0,0 +1,27 @@ +--- +weight: 12 Review Comment: If we can control the order, what about resorting all titles in alphabetic order? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34180][docs] Migrate doc website from ververica to flink [flink-web]
PatrickRen commented on code in PR #722: URL: https://github.com/apache/flink-web/pull/722#discussion_r1522754606 ## docs/content.zh/getting-started/with-flink-cdc.md: ## @@ -0,0 +1,27 @@ +--- +weight: 6 +title: With Flink CDC +bookHref: "https://nightlies.apache.org/flink/flink-cdc-docs-stable/docs/try-flink-cdc; Review Comment: Had an offline discussion with @GOODBOY008 and we decided to add a page on CDC side, so we keep the link as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34180][docs] Migrate doc website from ververica to flink [flink-web]
PatrickRen commented on code in PR #722: URL: https://github.com/apache/flink-web/pull/722#discussion_r1522749027 ## docs/content.zh/documentation/flink-cdc-master.md: ## @@ -0,0 +1,27 @@ +--- +weight: 12 +title: Flink CDC Master (snapshot) Review Comment: What about `CDC Master (snapshot)` to align with other titles? ## docs/content.zh/documentation/flink-cdc-master.md: ## @@ -0,0 +1,27 @@ +--- +weight: 12 Review Comment: If we can control the order, what about resorting all titles in alphabetic order? ## docs/content.zh/getting-started/training-course.md: ## @@ -1,5 +1,5 @@ --- -weight: 6 Review Comment: Ah thanks for the explanation. I was thinking it was related to font lol. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34180][docs] Migrate doc website from ververica to flink [flink-web]
GOODBOY008 commented on code in PR #722: URL: https://github.com/apache/flink-web/pull/722#discussion_r1517395740 ## docs/content.zh/getting-started/training-course.md: ## @@ -1,5 +1,5 @@ --- -weight: 6 Review Comment: @PatrickRen **Weight** will effect sort. I insert before this catalog ,so modify it's weight. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34180][docs] Migrate doc website from ververica to flink [flink-web]
PatrickRen commented on code in PR #722: URL: https://github.com/apache/flink-web/pull/722#discussion_r1517379722 ## docs/content.zh/getting-started/with-flink-cdc.md: ## @@ -0,0 +1,27 @@ +--- +weight: 6 +title: With Flink CDC +bookHref: "https://nightlies.apache.org/flink/flink-cdc-docs-stable/docs/try-flink-cdc; Review Comment: This link points to an empty page ## docs/content.zh/getting-started/training-course.md: ## @@ -1,5 +1,5 @@ --- -weight: 6 Review Comment: Is this modified by mistake? ## docs/content/getting-started/training-course.md: ## @@ -1,5 +1,5 @@ --- -weight: 6 Review Comment: This is also not necessary I think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34180][docs] Migrate doc website from ververica to flink [flink-web]
GOODBOY008 commented on PR #722: URL: https://github.com/apache/flink-web/pull/722#issuecomment-1985001432 @leonardBang @PatrickRen PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [FLINK-34180][docs] Migrate doc website from ververica to flink [flink-web]
GOODBOY008 opened a new pull request, #722: URL: https://github.com/apache/flink-web/pull/722 Add flink cdc document link to flink website. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
