Re: [PR] [FLINK-34248] Implement restore tests for changelog normalize node [flink]
dawidwys merged PR #24203: URL: https://github.com/apache/flink/pull/24203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34248] Implement restore tests for changelog normalize node [flink]
dawidwys commented on PR #24203: URL: https://github.com/apache/flink/pull/24203#issuecomment-1945896517 Thank you so much! It makes it so much easier to read it now! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34248] Implement restore tests for changelog normalize node [flink]
bvarghese1 commented on PR #24203: URL: https://github.com/apache/flink/pull/24203#issuecomment-1945216459 > Looks good, but could we make the input/output easier to digest? > > 1. Do we need to have a two column key? > 2. Can we have a non-numeric key? At least for me it's easier to track changes for something more distinct. 1. Simplified to 1 primary key 2. Switched to non-numeric key -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34248] Implement restore tests for changelog normalize node [flink]
flinkbot commented on PR #24203: URL: https://github.com/apache/flink/pull/24203#issuecomment-1912908978 ## CI report: * 776ffbde30fa754b06a2858fa572800c5edd8ffa UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [FLINK-34248] Implement restore tests for changelog normalize node [flink]
bvarghese1 opened a new pull request, #24203: URL: https://github.com/apache/flink/pull/24203 ## What is the purpose of the change *Add restore tests for ChangelogNormalize node* ## Verifying this change This change added tests and can be verified as follows: - Added restore tests for ChangelogNormalize node which verifies the generated compiled plan with the saved compiled plan. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
