jeyhunkarimov commented on PR #24510:
URL: https://github.com/apache/flink/pull/24510#issuecomment-2063179382
Thanks a lot for the review @LadyForest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
LadyForest merged PR #24510:
URL: https://github.com/apache/flink/pull/24510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
LadyForest commented on code in PR #24510:
URL: https://github.com/apache/flink/pull/24510#discussion_r1568258000
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/UncollectToTableFunctionScanRule.java:
##
@@ -0,0 +1,135 @@
+/*
+
LadyForest commented on code in PR #24510:
URL: https://github.com/apache/flink/pull/24510#discussion_r1566868181
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/UncollectToTableFunctionScanRule.scala:
##
@@ -0,0 +1,100 @@
+/*
LadyForest commented on PR #24510:
URL: https://github.com/apache/flink/pull/24510#issuecomment-2058380570
> Thanks for your review @LadyForest. I rebased and addressed your comments.
Could you please re-check the PR in your available time? Thanks
Apologies for the delayed response,
jeyhunkarimov commented on PR #24510:
URL: https://github.com/apache/flink/pull/24510#issuecomment-2048528560
Thanks for your review @LadyForest. I rebased and addressed your comments.
Could you please re-check the PR in your available time? Thanks
--
This is an automated message from
jeyhunkarimov commented on code in PR #24510:
URL: https://github.com/apache/flink/pull/24510#discussion_r1560115307
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/LogicalUnnestRule.scala:
##
@@ -73,59 +75,13 @@ class
jeyhunkarimov commented on code in PR #24510:
URL: https://github.com/apache/flink/pull/24510#discussion_r1560114423
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/UnnestConversionUtil.scala:
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to
LadyForest commented on PR #24510:
URL: https://github.com/apache/flink/pull/24510#issuecomment-2044375318
I just noticed that FLINK-34162 has been merged. Would you mind rebasing the
master and resolving the conflicts?
--
This is an automated message from the Apache Git Service.
To
LadyForest commented on code in PR #24510:
URL: https://github.com/apache/flink/pull/24510#discussion_r1554809993
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/LogicalUnnestRule.scala:
##
@@ -20,12 +20,13 @@ package
LadyForest commented on PR #24510:
URL: https://github.com/apache/flink/pull/24510#issuecomment-2031513708
Hi @jeyhunkarimov, thanks for reaching out and sorry for the late response.
I'll take a look ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the
jeyhunkarimov commented on PR #24510:
URL: https://github.com/apache/flink/pull/24510#issuecomment-2018929843
Hi @LadyForest can you please review this PR? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
flinkbot commented on PR #24510:
URL: https://github.com/apache/flink/pull/24510#issuecomment-2002539941
## CI report:
* e239874a6d95df04d4c5919b09fc800b82cacc44 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
jeyhunkarimov opened a new pull request, #24510:
URL: https://github.com/apache/flink/pull/24510
## What is the purpose of the change
Support unnesting array constants
## Brief change log
- Create a new rule `UncollectToTableFunctionScanRule`
- Tests
14 matches
Mail list logo
