Re: [PR] [build] Bump version to 4.2-SNAPSHOT [flink-connector-pulsar]
tisonkun commented on code in PR #67: URL: https://github.com/apache/flink-connector-pulsar/pull/67#discussion_r1423296836 ## flink-connector-pulsar-e2e-tests/pom.xml: ## @@ -23,7 +23,7 @@ under the License. org.apache.flink flink-connector-pulsar-parent - 4.1-SNAPSHOT + 4.2-SNAPSHOT Review Comment: @snuyanzin This may need a mailing list discussion. I personally support to use `4.2.0-SNAPSHOT` but the whole Flink repos use `X.Y-SNAPSHOT` for a long time and I don't know if other scripts depend on this format. cc @zentol For this patch, I tend to keep the current flavor. ## docs/data/pulsar.yml: ## @@ -16,7 +16,7 @@ # limitations under the License. -version: 4.1.0 +version: 4.2-SNAPSHOT Review Comment: ```suggestion version: 4.1.10 ``` ## docs/data/pulsar.yml: ## @@ -16,7 +16,7 @@ # limitations under the License. -version: 4.1.0 +version: 4.2-SNAPSHOT Review Comment: ```suggestion version: 4.1.0 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [build] Bump version to 4.2-SNAPSHOT [flink-connector-pulsar]
snuyanzin commented on code in PR #67: URL: https://github.com/apache/flink-connector-pulsar/pull/67#discussion_r1422304243 ## flink-connector-pulsar-e2e-tests/pom.xml: ## @@ -23,7 +23,7 @@ under the License. org.apache.flink flink-connector-pulsar-parent - 4.1-SNAPSHOT + 4.2-SNAPSHOT Review Comment: Just thoughts out loud since now it is maven 3.8.6 I'm curious whether we could use `revision` for versions and keep it in one place only https://maven.apache.org/maven-ci-friendly.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [build] Bump version to 4.2-SNAPSHOT [flink-connector-pulsar]
tisonkun commented on code in PR #67: URL: https://github.com/apache/flink-connector-pulsar/pull/67#discussion_r1422300397 ## docs/data/pulsar.yml: ## @@ -16,7 +16,7 @@ # limitations under the License. -version: 4.1.0 +version: 4.2-SNAPSHOT Review Comment: I think we don't change this until we do a release. `-SNAPSHOT` is meaningless before it's release. This field will be used to generate docs which is only valid for formal releases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [build] Bump version to 4.2-SNAPSHOT [flink-connector-pulsar]
leonardBang opened a new pull request, #67: URL: https://github.com/apache/flink-connector-pulsar/pull/67 ## Purpose of the change [build] Bump version to 4.2-SNAPSHOT ## Verifying this change Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. ## Significant changes *(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for convenience.)* - [ ] Dependencies have been added or upgraded - [ ] Public API has been changed (Public API is any class annotated with `@Public(Evolving)`) - [ ] Serializers have been changed - [ ] New feature has been introduced - If yes, how is this documented? (not applicable / docs / JavaDocs / not documented) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
