Re: [PR] [hotfix][doc] Generate and use docs of RpcOptions instead of AkkaOptions [flink]
fredia merged PR #24629: URL: https://github.com/apache/flink/pull/24629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [hotfix][doc] Generate and use docs of RpcOptions instead of AkkaOptions [flink]
Zakelly commented on PR #24629: URL: https://github.com/apache/flink/pull/24629#issuecomment-2047505961 > > > Hi @Zakelly , it seems that we should delete the file `docs/layouts/shortcodes/generated/akka_configuration.html` ? > > > > > > Yes, I forgot to delete it manually. Done & pushed. > > @Zakelly Thanks for the PR, I'm wondering if `ConfigOptionsDocsCompletenessITCase#testCompleteness` can pass? After I deleting `akka_configuration.html` in local, the `ConfigOptionsDocsCompletenessITCase#testCompleteness` failed. After you delete `akka_configuration.html` and add `rpc_configuration.html`, it can pass. IIUC, deleting `akka_configuration.html` only will cause incompletion of documents. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [hotfix][doc] Generate and use docs of RpcOptions instead of AkkaOptions [flink]
fredia commented on PR #24629: URL: https://github.com/apache/flink/pull/24629#issuecomment-2047300919 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [hotfix][doc] Generate and use docs of RpcOptions instead of AkkaOptions [flink]
fredia commented on PR #24629: URL: https://github.com/apache/flink/pull/24629#issuecomment-2047300462 @Zakelly Thanks for the PR, I'm curious > > Hi @Zakelly , it seems that we should delete the file `docs/layouts/shortcodes/generated/akka_configuration.html` ? > > Yes, I forgot to delete it manually. Done & pushed. I'm wondering if `ConfigOptionsDocsCompletenessITCase#testCompleteness` can pass? After I deleting `akka_configuration.html` in local, the `ConfigOptionsDocsCompletenessITCase#testCompleteness` failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [hotfix][doc] Generate and use docs of RpcOptions instead of AkkaOptions [flink]
zoltar9264 commented on PR #24629: URL: https://github.com/apache/flink/pull/24629#issuecomment-2046536179 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [hotfix][doc] Generate and use docs of RpcOptions instead of AkkaOptions [flink]
Zakelly commented on PR #24629: URL: https://github.com/apache/flink/pull/24629#issuecomment-2046482349 > Hi @Zakelly , it seems that we should delete the file `docs/layouts/shortcodes/generated/akka_configuration.html` ? Yes, I forgot to delete it manually. Done & pushed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [hotfix][doc] Generate and use docs of RpcOptions instead of AkkaOptions [flink]
zoltar9264 commented on PR #24629: URL: https://github.com/apache/flink/pull/24629#issuecomment-2046468783 Hi @Zakelly , it seems that we should delete the file `docs/layouts/shortcodes/generated/akka_configuration.html` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [hotfix][doc] Generate and use docs of RpcOptions instead of AkkaOptions [flink]
charlesy6 commented on PR #24629: URL: https://github.com/apache/flink/pull/24629#issuecomment-2043963892 lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [hotfix][doc] Generate and use docs of RpcOptions instead of AkkaOptions [flink]
Zakelly commented on PR #24629: URL: https://github.com/apache/flink/pull/24629#issuecomment-2041409660 @XComp Would you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [hotfix][doc] Generate and use docs of RpcOptions instead of AkkaOptions [flink]
flinkbot commented on PR #24629: URL: https://github.com/apache/flink/pull/24629#issuecomment-2041363992 ## CI report: * 1eeedee02ccdb674b5b2598bec8531e8eac49bf9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [hotfix][doc] Generate and use docs of RpcOptions instead of AkkaOptions [flink]
Zakelly opened a new pull request, #24629: URL: https://github.com/apache/flink/pull/24629 ## What is the purpose of the change Currently, when re-generating docs on master branch, the `rpc_configuration.html` is generated. The `AkkaOptions` is renamed to `RpcOptions` via FLINK-32684 so docs should be re-generated and all the content including should point to the new one. ## Brief change log - Re-generate docs. `rpc_configuration.html` is generated. - Replace all including of `akka_configuration.html` with `rpc_configuration.html` ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
