Re: [PR] [hotfix][table][doc] add hint to suggest using UserDefinedFunction class over instance [flink]

2023-11-26 Thread via GitHub
JingGe merged PR #23805: URL: https://github.com/apache/flink/pull/23805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [hotfix][table][doc] add hint to suggest using UserDefinedFunction class over instance [flink]

2023-11-26 Thread via GitHub
JingGe commented on PR #23805: URL: https://github.com/apache/flink/pull/23805#issuecomment-1826798523 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [hotfix][table][doc] add hint to suggest using UserDefinedFunction class over instance [flink]

2023-11-26 Thread via GitHub
JingGe commented on PR #23805: URL: https://github.com/apache/flink/pull/23805#issuecomment-1826797827 Thanks @snuyanzin for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [hotfix][table][doc] add hint to suggest using UserDefinedFunction class over instance [flink]

2023-11-26 Thread via GitHub
snuyanzin commented on code in PR #23805: URL: https://github.com/apache/flink/pull/23805#discussion_r1405381059 ## docs/content/docs/dev/table/functions/udfs.md: ## @@ -227,6 +227,20 @@ env.from("MyTable").select(call(classOf[MyConcatFunction], $"a", $"b", $"c")); {{< /tab

Re: [PR] [hotfix][table][doc] add hint to suggest using UserDefinedFunction class over instance [flink]

2023-11-25 Thread via GitHub
flinkbot commented on PR #23805: URL: https://github.com/apache/flink/pull/23805#issuecomment-1826474593 ## CI report: * cb036179d46abe0da3440617b8af78b9392d6e43 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix][table][doc] add hint to suggest using UserDefinedFunction class over instance [flink]

2023-11-25 Thread via GitHub
JingGe opened a new pull request, #23805: URL: https://github.com/apache/flink/pull/23805 ## What is the purpose of the change add hint to suggest using UserDefinedFunction class over instance ## Does this pull request potentially affect one of the following parts: -