JingGe merged PR #23786:
URL: https://github.com/apache/flink/pull/23786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
JingGe commented on PR #23786:
URL: https://github.com/apache/flink/pull/23786#issuecomment-1826886399
Thanks @snuyanzin for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
snuyanzin commented on code in PR #23786:
URL: https://github.com/apache/flink/pull/23786#discussion_r1405469301
##
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliTableauResultViewTest.java:
##
@@ -240,6 +232,16 @@ void testBatchResult() {
JingGe commented on PR #23786:
URL: https://github.com/apache/flink/pull/23786#issuecomment-1826828710
good catch! Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
snuyanzin commented on PR #23786:
URL: https://github.com/apache/flink/pull/23786#issuecomment-1826815890
Thanks for driving this
i would suggest to replace 2 more same occurrences e.g. at
snuyanzin commented on code in PR #23786:
URL: https://github.com/apache/flink/pull/23786#discussion_r1405421318
##
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliTableauResultViewTest.java:
##
@@ -226,7 +222,7 @@ void testBatchResult() {
snuyanzin commented on code in PR #23786:
URL: https://github.com/apache/flink/pull/23786#discussion_r1405421199
##
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliTableauResultViewTest.java:
##
@@ -226,7 +222,7 @@ void testBatchResult() {
snuyanzin commented on code in PR #23786:
URL: https://github.com/apache/flink/pull/23786#discussion_r1405421199
##
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliTableauResultViewTest.java:
##
@@ -226,7 +222,7 @@ void testBatchResult() {
flinkbot commented on PR #23786:
URL: https://github.com/apache/flink/pull/23786#issuecomment-1825056837
## CI report:
* 0c724f5597a1654d83682d5c39c7ee0ef2959cca UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
JingGe opened a new pull request, #23786:
URL: https://github.com/apache/flink/pull/23786
## What is the purpose of the change
remove duplicated code according the clean code concept.
## Verifying this change
This change is a trivial rework / code cleanup without any
10 matches
Mail list logo
