Re: [PR] Introduce operator for minibatch join [flink]

2024-01-24 Thread via GitHub
xishuaidelin commented on code in PR #24160: URL: https://github.com/apache/flink/pull/24160#discussion_r1465868291 ## flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/join/stream/StreamingMiniBatchJoinOperatorTest.java: ## @@ -0,0 +1,1667

Re: [PR] Introduce operator for minibatch join [flink]

2024-01-24 Thread via GitHub
xishuaidelin commented on code in PR #24160: URL: https://github.com/apache/flink/pull/24160#discussion_r1465811533 ## flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/join/stream/StreamingMiniBatchJoinOperatorTest.java: ## @@ -0,0 +1,1807

Re: [PR] Introduce operator for minibatch join [flink]

2024-01-24 Thread via GitHub
xishuaidelin commented on code in PR #24160: URL: https://github.com/apache/flink/pull/24160#discussion_r1465810094 ## flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/join/stream/StreamingMiniBatchJoinOperatorTest.java: ## @@ -0,0 +1,1667

Re: [PR] Introduce operator for minibatch join [flink]

2024-01-24 Thread via GitHub
xishuaidelin commented on code in PR #24160: URL: https://github.com/apache/flink/pull/24160#discussion_r1465809902 ## flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/join/stream/StreamingJoinOperatorTestBase.java: ## @@ -51,17 +51,17 @@

Re: [PR] Introduce operator for minibatch join [flink]

2024-01-24 Thread via GitHub
xishuaidelin commented on code in PR #24160: URL: https://github.com/apache/flink/pull/24160#discussion_r1465808645 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/MiniBatchStreamingJoinOperator.java: ## @@ -0,0 +1,416 @@

Re: [PR] Introduce operator for minibatch join [flink]

2024-01-24 Thread via GitHub
xishuaidelin commented on code in PR #24160: URL: https://github.com/apache/flink/pull/24160#discussion_r1465808375 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/MiniBatchStreamingJoinOperator.java: ## @@ -0,0 +1,416 @@

Re: [PR] Introduce operator for minibatch join [flink]

2024-01-24 Thread via GitHub
xishuaidelin commented on code in PR #24160: URL: https://github.com/apache/flink/pull/24160#discussion_r1465807749 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/MiniBatchStreamingJoinOperator.java: ## @@ -0,0 +1,416 @@

Re: [PR] Introduce operator for minibatch join [flink]

2024-01-24 Thread via GitHub
xishuaidelin commented on code in PR #24160: URL: https://github.com/apache/flink/pull/24160#discussion_r1465807400 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/MiniBatchStreamingJoinOperator.java: ## @@ -0,0 +1,416 @@

Re: [PR] Introduce operator for minibatch join [flink]

2024-01-24 Thread via GitHub
xishuaidelin commented on code in PR #24160: URL: https://github.com/apache/flink/pull/24160#discussion_r1465806063 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/MiniBatchStreamingJoinOperator.java: ## @@ -0,0 +1,416 @@

Re: [PR] Introduce operator for minibatch join [flink]

2024-01-24 Thread via GitHub
xishuaidelin commented on code in PR #24160: URL: https://github.com/apache/flink/pull/24160#discussion_r1465798199 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/MiniBatchStreamingJoinOperator.java: ## @@ -0,0 +1,420 @@

Re: [PR] Introduce operator for minibatch join [flink]

2024-01-24 Thread via GitHub
xishuaidelin commented on code in PR #24160: URL: https://github.com/apache/flink/pull/24160#discussion_r1465790352 ## flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/join/stream/StreamingJoinOperatorTestBase.java: ## @@ -41,7 +41,7 @@

Re: [PR] Introduce operator for minibatch join [flink]

2024-01-24 Thread via GitHub
xishuaidelin commented on code in PR #24160: URL: https://github.com/apache/flink/pull/24160#discussion_r1465789710 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/MiniBatchStreamingJoinOperator.java: ## @@ -0,0 +1,420 @@

Re: [PR] Introduce operator for minibatch join [flink]

2024-01-24 Thread via GitHub
xishuaidelin commented on code in PR #24160: URL: https://github.com/apache/flink/pull/24160#discussion_r1465789465 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/MiniBatchStreamingJoinOperator.java: ## @@ -0,0 +1,420 @@

Re: [PR] Introduce operator for minibatch join [flink]

2024-01-24 Thread via GitHub
xishuaidelin commented on code in PR #24160: URL: https://github.com/apache/flink/pull/24160#discussion_r1465789018 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/AbstractStreamingJoinOperator.java: ## @@ -66,6 +67,10 @@

Re: [PR] Introduce operator for minibatch join [flink]

2024-01-24 Thread via GitHub
lsyldliu commented on code in PR #24160: URL: https://github.com/apache/flink/pull/24160#discussion_r1465762258 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/AbstractStreamingJoinOperator.java: ## @@ -66,6 +67,10 @@ public

Re: [PR] Introduce operator for minibatch join [flink]

2024-01-24 Thread via GitHub
xishuaidelin commented on code in PR #24160: URL: https://github.com/apache/flink/pull/24160#discussion_r1465753408 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/MiniBatchStreamingJoinOperator.java: ## @@ -0,0 +1,416 @@

Re: [PR] Introduce operator for minibatch join [flink]

2024-01-24 Thread via GitHub
xishuaidelin commented on code in PR #24160: URL: https://github.com/apache/flink/pull/24160#discussion_r1464818953 ## flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/join/stream/StreamingMiniBatchJoinOperatorTest.java: ## @@ -0,0 +1,1667

Re: [PR] Introduce operator for minibatch join [flink]

2024-01-21 Thread via GitHub
flinkbot commented on PR #24160: URL: https://github.com/apache/flink/pull/24160#issuecomment-1903006337 ## CI report: * d487b086c0cccb48244e46b106bcd26143e6a272 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] Introduce operator for minibatch join [flink]

2024-01-21 Thread via GitHub
xishuaidelin opened a new pull request, #24160: URL: https://github.com/apache/flink/pull/24160 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring