[jira] [Comment Edited] (FLINK-33780) Support to store default catalog in CatalogStore

2023-12-11 Thread Yubin Li (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-33780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795574#comment-17795574
 ] 

Yubin Li edited comment on FLINK-33780 at 12/12/23 5:42 AM:


[~hackergin] Hi, we could make modifitions in the `CatalogManager` construct 
function as follows:

!image-2023-12-12-11-09-53-075.png|width=798,height=406!

DefaultCatalog is the current catalog of a session including SqlGateway, 
`default_catalog` is like `d2` under the context `use catalog d2`, the only 
difference is that it is created implicitly by Flink, we should treat them 
equally for semantic consistency, WDYT?

!image-2023-12-12-13-42-04-762.png|width=422,height=184!


was (Author: liyubin117):
[~hackergin] Hi, we could make modifitions in the `CatalogManager` construct 
function as follows:

!image-2023-12-12-11-09-53-075.png|width=1165,height=593!

DefaultCatalog is the current catalog of a session including SqlGateway, 
`default_catalog` is like `d2` under the context `use catalog d2`, the only 
difference is that it is created implicitly by Flink, we should treat them 
equally for semantic consistency, WDYT?

> Support to store default catalog in CatalogStore
> 
>
> Key: FLINK-33780
> URL: https://issues.apache.org/jira/browse/FLINK-33780
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / API
>Affects Versions: 1.19.0
>Reporter: Yubin Li
>Priority: Major
> Attachments: image-2023-12-11-13-47-29-623.png, 
> image-2023-12-11-14-14-10-002.png, image-2023-12-12-11-09-53-075.png, 
> image-2023-12-12-13-42-04-762.png
>
>
> Flink initially creates a default catalog which is included in the 
> `Map catalogs`, but is not stored in the CatalogStore.
> After conducting thorough investigation, I've determined that the necessary 
> modification can be made within the `CatalogManager`.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (FLINK-33780) Support to store default catalog in CatalogStore

2023-12-11 Thread Yubin Li (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-33780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795574#comment-17795574
 ] 

Yubin Li edited comment on FLINK-33780 at 12/12/23 3:22 AM:


[~hackergin] Hi, we could make modifitions in the `CatalogManager` construct 
function as follows:

!image-2023-12-12-11-09-53-075.png|width=1165,height=593!

DefaultCatalog is the current catalog of a session including SqlGateway, 
`default_catalog` is like `d2` under the context `use catalog d2`, the only 
difference is that it is created implicitly by Flink, we should treat them 
equally for semantic consistency, WDYT?


was (Author: liyubin117):
[~hackergin] Hi, we could make modifitions in the `CatalogManager` construct 
function as follows:

!image-2023-12-12-11-09-53-075.png|width=1165,height=593!

DefaultCatalog is the current catalog of a session including SqlGateway, 
`default_catalog` is like `d2` under the context `use catalog d2`, only the 
difference is that it is created implicitly by Flink, we should treat them 
equally for semantic consistency, WDYT?

> Support to store default catalog in CatalogStore
> 
>
> Key: FLINK-33780
> URL: https://issues.apache.org/jira/browse/FLINK-33780
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / API
>Affects Versions: 1.19.0
>Reporter: Yubin Li
>Priority: Major
> Attachments: image-2023-12-11-13-47-29-623.png, 
> image-2023-12-11-14-14-10-002.png, image-2023-12-12-11-09-53-075.png
>
>
> Flink initially creates a default catalog which is included in the 
> `Map catalogs`, but is not stored in the CatalogStore.
> After conducting thorough investigation, I've determined that the necessary 
> modification can be made within the `CatalogManager`.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (FLINK-33780) Support to store default catalog in CatalogStore

2023-12-11 Thread Yubin Li (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-33780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795574#comment-17795574
 ] 

Yubin Li edited comment on FLINK-33780 at 12/12/23 3:21 AM:


[~hackergin] Hi, we could make modifitions in the `CatalogManager` construct 
function as follows:

!image-2023-12-12-11-09-53-075.png|width=1165,height=593!

DefaultCatalog is the current catalog of a session including SqlGateway, 
`default_catalog` is like `d2` under the context `use catalog d2`, only the 
difference is that it is created implicitly by Flink, we should treat them 
equally for semantic consistency, WDYT?


was (Author: liyubin117):
[~hackergin] Hi, we could make modifitions in the `CatalogManager` construct 
function as follows:

!image-2023-12-12-11-09-53-075.png|width=1165,height=593!

DefaultCatalog is the current catalog of a session including SqlGateway, 
`default_catalog` is like `d2`, only the difference is that it is created 
implicitly by Flink, we should treat them equally for semantic consistency, 
WDYT?

!image-2023-12-11-14-14-10-002.png|width=805,height=565!

> Support to store default catalog in CatalogStore
> 
>
> Key: FLINK-33780
> URL: https://issues.apache.org/jira/browse/FLINK-33780
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / API
>Affects Versions: 1.19.0
>Reporter: Yubin Li
>Priority: Major
> Attachments: image-2023-12-11-13-47-29-623.png, 
> image-2023-12-11-14-14-10-002.png, image-2023-12-12-11-09-53-075.png
>
>
> Flink initially creates a default catalog which is included in the 
> `Map catalogs`, but is not stored in the CatalogStore.
> After conducting thorough investigation, I've determined that the necessary 
> modification can be made within the `CatalogManager`.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (FLINK-33780) Support to store default catalog in CatalogStore

2023-12-10 Thread Yubin Li (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-33780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795171#comment-17795171
 ] 

Yubin Li edited comment on FLINK-33780 at 12/11/23 6:14 AM:


[~hackergin] Thanks for your attention:)

In addition to the conceptual necessity (default catalog is also part of 
catalogs equaly and not differ from others), I also found that the `show create 
catalog` statement  proposed in 
https://issues.apache.org/jira/browse/FLINK-24939 would expose the absence of 
the default catalog in the CatalogStore, I have implemented the statement on 
our production env using `CatalogStore`.

!image-2023-12-11-14-14-10-002.png|width=821,height=576!


was (Author: liyubin117):
[~hackergin] Thanks for your attention:)

In addition to the conceptual necessity (default catalog is also part of 
catalogs equaly and not differ from others), I also found that the `show create 
catalog` statement  proposed in 
https://issues.apache.org/jira/browse/FLINK-24939 would expose the absence of 
the default catalog in the CatalogStore, I have implemented the statement on 
our production env using `CatalogStore`.

!image-2023-12-11-13-47-29-623.png|width=702,height=290!

> Support to store default catalog in CatalogStore
> 
>
> Key: FLINK-33780
> URL: https://issues.apache.org/jira/browse/FLINK-33780
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / API
>Affects Versions: 1.19.0
>Reporter: Yubin Li
>Priority: Major
> Attachments: image-2023-12-11-13-47-29-623.png, 
> image-2023-12-11-14-14-10-002.png
>
>
> Flink initially creates a default catalog which is included in the 
> `Map catalogs`, but is not stored in the CatalogStore.
> After conducting thorough investigation, I've determined that the necessary 
> modification can be made within the `CatalogManager`.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (FLINK-33780) Support to store default catalog in CatalogStore

2023-12-10 Thread Yubin Li (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-33780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795171#comment-17795171
 ] 

Yubin Li edited comment on FLINK-33780 at 12/11/23 6:13 AM:


[~hackergin] Thanks for your attention:)

In addition to the conceptual necessity (default catalog is also part of 
catalogs equaly and not differ from others), I also found that the `show create 
catalog` statement  proposed in 
https://issues.apache.org/jira/browse/FLINK-24939 would expose the absence of 
the default catalog in the CatalogStore, I have implemented the statement on 
our production env using `CatalogStore`.

!image-2023-12-11-13-47-29-623.png|width=702,height=290!


was (Author: liyubin117):
[~hackergin] Thanks for your attention:)

In addition to the conceptual necessity (default catalog is also part of 
catalogs), I also found that the `show create catalog` statement  proposed in 
https://issues.apache.org/jira/browse/FLINK-24939 would expose the absence of 
the default catalog in the CatalogStore, I have implemented the statement on 
our production env using `CatalogStore`.

!image-2023-12-11-13-47-29-623.png|width=702,height=290!

> Support to store default catalog in CatalogStore
> 
>
> Key: FLINK-33780
> URL: https://issues.apache.org/jira/browse/FLINK-33780
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / API
>Affects Versions: 1.19.0
>Reporter: Yubin Li
>Priority: Major
> Attachments: image-2023-12-11-13-47-29-623.png
>
>
> Flink initially creates a default catalog which is included in the 
> `Map catalogs`, but is not stored in the CatalogStore.
> After conducting thorough investigation, I've determined that the necessary 
> modification can be made within the `CatalogManager`.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (FLINK-33780) Support to store default catalog in CatalogStore

2023-12-10 Thread Yubin Li (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-33780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795171#comment-17795171
 ] 

Yubin Li edited comment on FLINK-33780 at 12/11/23 5:53 AM:


[~hackergin] Thanks for your attention:)

In addition to the conceptual necessity (default catalog is also part of 
catalogs), I also found that the `show create catalog` statement  proposed in 
https://issues.apache.org/jira/browse/FLINK-24939 would expose the absence of 
the default catalog in the CatalogStore, I have implemented the statement on 
our production env using `CatalogStore`.

!image-2023-12-11-13-47-29-623.png|width=702,height=290!


was (Author: liyubin117):
[~hackergin] In addition to the conceptual necessity (default catalog is also 
part of catalogs), I also found that the `show create catalog` statement  
proposed in https://issues.apache.org/jira/browse/FLINK-24939 would expose the 
absence of the default catalog in the CatalogStore, I have implemented the 
statement on our production env using `CatalogStore`.

!image-2023-12-11-13-47-29-623.png|width=702,height=290!

> Support to store default catalog in CatalogStore
> 
>
> Key: FLINK-33780
> URL: https://issues.apache.org/jira/browse/FLINK-33780
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / API
>Affects Versions: 1.19.0
>Reporter: Yubin Li
>Priority: Major
> Attachments: image-2023-12-11-13-47-29-623.png
>
>
> Flink initially creates a default catalog which is included in the 
> `Map catalogs`, but is not stored in the CatalogStore.
> After conducting thorough investigation, I've determined that the necessary 
> modification can be made within the `CatalogManager`.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (FLINK-33780) Support to store default catalog in CatalogStore

2023-12-10 Thread Yubin Li (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-33780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795171#comment-17795171
 ] 

Yubin Li edited comment on FLINK-33780 at 12/11/23 5:52 AM:


[~hackergin] In addition to the conceptual necessity (default catalog is also 
part of catalogs), I also found that the `show create catalog` statement  
proposed in https://issues.apache.org/jira/browse/FLINK-24939 would expose the 
absence of the default catalog in the CatalogStore, I have implemented the 
statement on our production env using `CatalogStore`.

!image-2023-12-11-13-47-29-623.png|width=702,height=290!


was (Author: liyubin117):
[~hackergin] In addition to the conceptual necessity (default catalog is also 
part of catalogs), I also found that the `show create catalog` statement  
proposed in https://issues.apache.org/jira/browse/FLINK-24939 would expose the 
absence of the default catalog in the CatalogStore, I have implemented the 
statement on our production dev using `CatalogStore`.

!image-2023-12-11-13-47-29-623.png|width=702,height=290!

> Support to store default catalog in CatalogStore
> 
>
> Key: FLINK-33780
> URL: https://issues.apache.org/jira/browse/FLINK-33780
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / API
>Affects Versions: 1.19.0
>Reporter: Yubin Li
>Priority: Major
> Attachments: image-2023-12-11-13-47-29-623.png
>
>
> Flink initially creates a default catalog which is included in the 
> `Map catalogs`, but is not stored in the CatalogStore.
> After conducting thorough investigation, I've determined that the necessary 
> modification can be made within the `CatalogManager`.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (FLINK-33780) Support to store default catalog in CatalogStore

2023-12-10 Thread Yubin Li (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-33780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795171#comment-17795171
 ] 

Yubin Li edited comment on FLINK-33780 at 12/11/23 5:51 AM:


[~hackergin] In addition to the conceptual necessity (default catalog is also 
part of catalogs), I also found that the `show create catalog` statement  
proposed in https://issues.apache.org/jira/browse/FLINK-24939 would expose the 
absence of the default catalog in the CatalogStore, I have implemented the 
statement on our production dev using `CatalogStore`.

!image-2023-12-11-13-47-29-623.png|width=702,height=290!


was (Author: liyubin117):
[~hackergin] In addition to the conceptual necessity (default catalog is also 
part of catalogs), I also found that the `show create catalog` statement  
proposed in https://issues.apache.org/jira/browse/FLINK-24939 would expose the 
absence of the default catalog in the CatalogStore.

!image-2023-12-11-13-47-29-623.png|width=702,height=290!

> Support to store default catalog in CatalogStore
> 
>
> Key: FLINK-33780
> URL: https://issues.apache.org/jira/browse/FLINK-33780
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / API
>Affects Versions: 1.19.0
>Reporter: Yubin Li
>Priority: Major
> Attachments: image-2023-12-11-13-47-29-623.png
>
>
> Flink initially creates a default catalog which is included in the 
> `Map catalogs`, but is not stored in the CatalogStore.
> After conducting thorough investigation, I've determined that the necessary 
> modification can be made within the `CatalogManager`.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (FLINK-33780) Support to store default catalog in CatalogStore

2023-12-08 Thread Yubin Li (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-33780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794581#comment-17794581
 ] 

Yubin Li edited comment on FLINK-33780 at 12/8/23 9:58 AM:
---

[~hackergin] Hi, looking forward to your suggestions :) I have implemented 
this, and if the feature is neccessary, could you please assign this to me? 
thanks~


was (Author: liyubin117):
[~hackergin] Hi, looking forward to your suggestions :) I have implemented 
this, and if it is neccessary, could you please assign this to me? thanks~

> Support to store default catalog in CatalogStore
> 
>
> Key: FLINK-33780
> URL: https://issues.apache.org/jira/browse/FLINK-33780
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / API
>Affects Versions: 1.19.0
>Reporter: Yubin Li
>Priority: Major
>
> Flink initially creates a default catalog which is included in the 
> `Map catalogs`, but is not stored in the CatalogStore.
> After conducting thorough investigation, I've determined that the necessary 
> modification can be made within the `CatalogManager`.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)