[jira] [Commented] (FLINK-10662) Refactor the ChannelSelector interface for single selected channel

2018-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718869#comment-16718869 ] ASF GitHub Bot commented on FLINK-10662: pnowojski commented on a change in pull request #7199:

[jira] [Commented] (FLINK-10662) Refactor the ChannelSelector interface for single selected channel

2018-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718865#comment-16718865 ] ASF GitHub Bot commented on FLINK-10662: pnowojski commented on a change in pull request #7199:

[jira] [Commented] (FLINK-10662) Refactor the ChannelSelector interface for single selected channel

2018-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718868#comment-16718868 ] ASF GitHub Bot commented on FLINK-10662: pnowojski commented on a change in pull request #7199:

[jira] [Commented] (FLINK-10662) Refactor the ChannelSelector interface for single selected channel

2018-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718866#comment-16718866 ] ASF GitHub Bot commented on FLINK-10662: pnowojski commented on a change in pull request #7199:

[jira] [Commented] (FLINK-10662) Refactor the ChannelSelector interface for single selected channel

2018-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703232#comment-16703232 ] ASF GitHub Bot commented on FLINK-10662: zhijiangW commented on issue #7199:

[jira] [Commented] (FLINK-10662) Refactor the ChannelSelector interface for single selected channel

2018-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703231#comment-16703231 ] ASF GitHub Bot commented on FLINK-10662: zhijiangW opened a new pull request #7199:

[jira] [Commented] (FLINK-10662) Refactor the ChannelSelector interface for single selected channel

2018-11-22 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695679#comment-16695679 ] Piotr Nowojski commented on FLINK-10662: Sounds good :) > Refactor the ChannelSelector

[jira] [Commented] (FLINK-10662) Refactor the ChannelSelector interface for single selected channel

2018-11-20 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694190#comment-16694190 ] zhijiang commented on FLINK-10662: -- Thanks for all the suggestions!  I think we all reach the

[jira] [Commented] (FLINK-10662) Refactor the ChannelSelector interface for single selected channel

2018-11-19 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691515#comment-16691515 ] Nico Kruber commented on FLINK-10662: - [~pnowojski] thanks for the clarification. So this change

[jira] [Commented] (FLINK-10662) Refactor the ChannelSelector interface for single selected channel

2018-11-16 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689674#comment-16689674 ] Piotr Nowojski commented on FLINK-10662: I think both current solution and iterator are more

[jira] [Commented] (FLINK-10662) Refactor the ChannelSelector interface for single selected channel

2018-11-15 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688257#comment-16688257 ] Nico Kruber commented on FLINK-10662: - If we never call {{BroadcastPartitioner#selectChannels()}},

[jira] [Commented] (FLINK-10662) Refactor the ChannelSelector interface for single selected channel

2018-11-09 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681454#comment-16681454 ] Piotr Nowojski commented on FLINK-10662: Yes, back in the past I was also thinking about this

[jira] [Commented] (FLINK-10662) Refactor the ChannelSelector interface for single selected channel

2018-11-09 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681198#comment-16681198 ] zhijiang commented on FLINK-10662: -- [~pnowojski], I am currently working on this. If we change to