[
https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974890#comment-16974890
]
Zhenghua Gao commented on FLINK-11935:
--
Created FLINK-14805 to track `remove the copied code when
[
https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974866#comment-16974866
]
Kurt Young commented on FLINK-11935:
{noformat}
we can remove the copied code when we upgraded to
[
https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974838#comment-16974838
]
Zhenghua Gao commented on FLINK-11935:
--
The impact to legacy planner:
# toString of
[
https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974072#comment-16974072
]
vinoyang commented on FLINK-11935:
--
[~ykt836] I am not working on this ticket. Please feel free to
[
https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974066#comment-16974066
]
Kurt Young commented on FLINK-11935:
[~yanghua] are you still working on this? Do you mind we take
[
https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945356#comment-16945356
]
Kurt Young commented on FLINK-11935:
I'm removing this issue from the sub-tasks of upgrading calcite
[
https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834535#comment-16834535
]
vinoyang commented on FLINK-11935:
--
[~walterddr] What do you think about Julian's comment?
> Remove
[
https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831327#comment-16831327
]
Julian Hyde commented on FLINK-11935:
-
If the language you are implementing is SQL, then you don't
[
https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829386#comment-16829386
]
Rong Rong commented on FLINK-11935:
---
I think this issue should not block calcite upgrade, we can still
[
https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827799#comment-16827799
]
vinoyang commented on FLINK-11935:
--
[~walterddr] My thoughts are similar to yours, and I am also
[
https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827666#comment-16827666
]
Rong Rong commented on FLINK-11935:
---
I dug a little deeper: I think there are something problematic in
[
https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826608#comment-16826608
]
vinoyang commented on FLINK-11935:
--
Yes, what do you think?
> Remove DateTimeUtils pull-in and fix
[
https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826601#comment-16826601
]
Rong Rong commented on FLINK-11935:
---
hmm. I might've misunderstood some details.
Are you suggesting
[
https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826599#comment-16826599
]
vinoyang commented on FLINK-11935:
--
Hi [~walterddr] Actually, my idea is to keep it as an option, let
[
https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826516#comment-16826516
]
Rong Rong commented on FLINK-11935:
---
Hi [~yanghua], I understand what you said. I think to summarize
[
https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825651#comment-16825651
]
vinoyang commented on FLINK-11935:
--
[~walterddr] In CALCITE-2989, [~julianhyde] gave a link which
[
https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825347#comment-16825347
]
Rong Rong commented on FLINK-11935:
---
My feeling is that we should find out why Julian datetime *epoch
[
https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824888#comment-16824888
]
vinoyang commented on FLINK-11935:
--
[~walterddr] [~twalthr] What do you think about this issue? Based
[
https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816755#comment-16816755
]
Julian Hyde commented on FLINK-11935:
-
My advice is don't trust Java, do trust PostgreSQL. Java
[
https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816445#comment-16816445
]
Rong Rong commented on FLINK-11935:
---
I think [~julianhyde] is correct. actually I ran the test again
[
https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816093#comment-16816093
]
vinoyang commented on FLINK-11935:
--
[~walterddr] what do you think?
> Remove DateTimeUtils pull-in and
[
https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815625#comment-16815625
]
Julian Hyde commented on FLINK-11935:
-
I think you need to update your tests. Perhaps your tests are
[
https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815059#comment-16815059
]
vinoyang commented on FLINK-11935:
--
[~walterddr] It seems I found the key issue, and we can not delete
[
https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805307#comment-16805307
]
Rong Rong commented on FLINK-11935:
---
Thanks for checking in [~yanghua]. I think we can skip the
[
https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804612#comment-16804612
]
vinoyang commented on FLINK-11935:
--
Hi [~walterddr] Shall I follow these steps?
* Upgrade calcite
25 matches
Mail list logo
