[jira] [Commented] (FLINK-13796) Remove unused variable
[ https://issues.apache.org/jira/browse/FLINK-13796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933243#comment-16933243 ] Stephan Ewen commented on FLINK-13796: -- I think it is okay to merge this. Removing dead code makes sense. Whether this needs an issue or is a hotfix is debatable, but now that the issue already exists, I am fine with keeping it. > Remove unused variable > -- > > Key: FLINK-13796 > URL: https://issues.apache.org/jira/browse/FLINK-13796 > Project: Flink > Issue Type: Task > Components: Deployment / YARN >Affects Versions: 1.8.1 >Reporter: Fokko Driesprong >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-13796) Remove unused variable
[ https://issues.apache.org/jira/browse/FLINK-13796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912027#comment-16912027 ] Xintong Song commented on FLINK-13796: -- Sorry [~Tison], I just closed the ticket before noticing your comment in the PR. I'm staying with my original opinion that trivial issues like this one should not be considered as independent Jira tickets, which consume the community resources to discuss, review and merge. Such changes can be committed as hotfixes together with other valid changes. I don't have strong objection on merging this change. Please reopen the issue if you guys think this is not a trivial issue and worth further discussion. > Remove unused variable > -- > > Key: FLINK-13796 > URL: https://issues.apache.org/jira/browse/FLINK-13796 > Project: Flink > Issue Type: Task > Components: Deployment / YARN >Affects Versions: 1.8.1 >Reporter: Fokko Driesprong >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (FLINK-13796) Remove unused variable
[ https://issues.apache.org/jira/browse/FLINK-13796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912016#comment-16912016 ] TisonKun commented on FLINK-13796: -- Hi [~Fokko], as mention by [~xintongsong] in GH-9492 we'd better follow our workflow that first require a consensus and assignment in JIRA, i.e., here. To [~xintongsong], IMO remove unused variable is a valid contribution, similar to [this commit|https://github.com/apache/flink/commit/5e73062cc980e172a84821085a75d520f4fb2a65]. Retain unused variables may confuse our contributors if they are no familiar with the code and error prone for accidentally further use(without an explicit reason but just there is a variable). See also [the comment here|https://github.com/apache/flink/pull/9245#issuecomment-517672480]. > Remove unused variable > -- > > Key: FLINK-13796 > URL: https://issues.apache.org/jira/browse/FLINK-13796 > Project: Flink > Issue Type: Task > Components: Deployment / YARN >Affects Versions: 1.8.1 >Reporter: Fokko Driesprong >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
