[jira] [Commented] (FLINK-14539) Unique key metadata should be ketp when using concat or concat_ws in some cases

2019-10-30 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962767#comment-16962767 ] Jark Wu commented on FLINK-14539: - [~KevinZwx], I created FLINK-14567. > Unique key metadata should be

[jira] [Commented] (FLINK-14539) Unique key metadata should be ketp when using concat or concat_ws in some cases

2019-10-30 Thread Kevin Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962759#comment-16962759 ] Kevin Zhang commented on FLINK-14539: - [~jark] That's good, I'd like to join the discussion by then,

[jira] [Commented] (FLINK-14539) Unique key metadata should be ketp when using concat or concat_ws in some cases

2019-10-30 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962754#comment-16962754 ] Jark Wu commented on FLINK-14539: - [~KevinZwx], Yes, this is an very important use case and is bothered

[jira] [Commented] (FLINK-14539) Unique key metadata should be ketp when using concat or concat_ws in some cases

2019-10-30 Thread Kevin Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962753#comment-16962753 ] Kevin Zhang commented on FLINK-14539: - [~jark] thansk, greate catch, I omitted this kind of

[jira] [Commented] (FLINK-14539) Unique key metadata should be ketp when using concat or concat_ws in some cases

2019-10-29 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962681#comment-16962681 ] Jark Wu commented on FLINK-14539: - After rethinking this issue, I think we may can't support drivation

[jira] [Commented] (FLINK-14539) Unique key metadata should be ketp when using concat or concat_ws in some cases

2019-10-28 Thread Kevin Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960875#comment-16960875 ] Kevin Zhang commented on FLINK-14539: - Thanks for your opinions[~jark][~danny0405]. Actually I've

[jira] [Commented] (FLINK-14539) Unique key metadata should be ketp when using concat or concat_ws in some cases

2019-10-28 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960873#comment-16960873 ] Jark Wu commented on FLINK-14539: - Hi [~danny0405], the I think the reason to use {{RexBiVisitor}}

[jira] [Commented] (FLINK-14539) Unique key metadata should be ketp when using concat or concat_ws in some cases

2019-10-28 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960862#comment-16960862 ] Danny Chen commented on FLINK-14539: Nice catch [~KevinZwx], you should use RexVisitor instead of

[jira] [Commented] (FLINK-14539) Unique key metadata should be ketp when using concat or concat_ws in some cases

2019-10-28 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960843#comment-16960843 ] Jark Wu commented on FLINK-14539: - Hi [~KevinZwx], I think RexBiVisitor is fine. Some thoughts from my

[jira] [Commented] (FLINK-14539) Unique key metadata should be ketp when using concat or concat_ws in some cases

2019-10-28 Thread Kevin Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960781#comment-16960781 ] Kevin Zhang commented on FLINK-14539: - I indend to implement this using a RexBiVisitor, because