[ https://issues.apache.org/jira/browse/FLINK-15469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017755#comment-17017755 ]
Zhenghua Gao commented on FLINK-15469: -------------------------------------- After an initial POC, the getTypeClass is not needed because Upsert/Retract stream table sink always need java *Tuple2*. And, we don't need any changes for the *getOutputType*/*getConsumedDataType* because the codegen could use *getRecordDataType* directly. > Update UpsertStreamTableSink and RetractStreamTableSink and related interface > to new type system > ------------------------------------------------------------------------------------------------ > > Key: FLINK-15469 > URL: https://issues.apache.org/jira/browse/FLINK-15469 > Project: Flink > Issue Type: Improvement > Components: Table SQL / API > Affects Versions: 1.10.0 > Reporter: Zhenghua Gao > Priority: Major > Labels: pull-request-available > Fix For: 1.11.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently *UpsertStreamTableSink* can only returns TypeInformation of the > requested record, which can't support types with precision and scale, e.g. > TIMESTAMP(p), DECIMAL(p,s). > A proposal is deprecating the *getRecordType* API and adding a > *getRecordDataType* API instead to return the data type of the requested > record. > {code:java} > /** > * Returns the requested record type. > * > * @Deprecated This method will be removed in future versions. It's > recommended to use {@link #getRecordDataType()} instead. > */ > @Deprecated > TypeInformation<T> getRecordType(); > /* > * Returns the requested record data type. > */ > DataType getRecordDataType(); > {code} > -- This message was sent by Atlassian Jira (v8.3.4#803005)