[jira] [Commented] (FLINK-17083) Restrict users of accumulators not to return null in Accumulator#getLocalValue
[
https://issues.apache.org/jira/browse/FLINK-17083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17336240#comment-17336240
]
Flink Jira Bot commented on FLINK-17083:
This issue was labeled "stale-major" 7 ago and has not received any updates so
it is being deprioritized. If this ticket is actually Major, please raise the
priority and ask a committer to assign you the issue or revive the public
discussion.
> Restrict users of accumulators not to return null in Accumulator#getLocalValue
> --
>
> Key: FLINK-17083
> URL: https://issues.apache.org/jira/browse/FLINK-17083
> Project: Flink
> Issue Type: Improvement
> Components: API / Core
>Affects Versions: 1.11.0
>Reporter: Caizhi Weng
>Priority: Major
> Labels: stale-major
>
> [This discussion|https://issues.apache.org/jira/browse/FLINK-13880] raises a
> problem that, if a user returns a null value in
> {{Accumulator#getLocalValue}}, he will be notified that the {{failureCause}}
> should not be null when fetching the accumulator result, which seems to be
> really wired.
> The problem is that we're not explicitly restricting the users not to return
> null values in {{Accumulator#getLocalValue}}.
> [~aljoscha] is it legal to return null values? If not, we should explicitly
> throw a related exception to the users instead of giving the users a somewhat
> unrelated exception.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-17083) Restrict users of accumulators not to return null in Accumulator#getLocalValue
[
https://issues.apache.org/jira/browse/FLINK-17083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17327926#comment-17327926
]
Flink Jira Bot commented on FLINK-17083:
This major issue is unassigned and itself and all of its Sub-Tasks have not
been updated for 30 days. So, it has been labeled "stale-major". If this ticket
is indeed "major", please either assign yourself or give an update. Afterwards,
please remove the label. In 7 days the issue will be deprioritized.
> Restrict users of accumulators not to return null in Accumulator#getLocalValue
> --
>
> Key: FLINK-17083
> URL: https://issues.apache.org/jira/browse/FLINK-17083
> Project: Flink
> Issue Type: Improvement
> Components: API / Core
>Affects Versions: 1.11.0
>Reporter: Caizhi Weng
>Priority: Major
> Labels: stale-major
>
> [This discussion|https://issues.apache.org/jira/browse/FLINK-13880] raises a
> problem that, if a user returns a null value in
> {{Accumulator#getLocalValue}}, he will be notified that the {{failureCause}}
> should not be null when fetching the accumulator result, which seems to be
> really wired.
> The problem is that we're not explicitly restricting the users not to return
> null values in {{Accumulator#getLocalValue}}.
> [~aljoscha] is it legal to return null values? If not, we should explicitly
> throw a related exception to the users instead of giving the users a somewhat
> unrelated exception.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-17083) Restrict users of accumulators not to return null in Accumulator#getLocalValue
[
https://issues.apache.org/jira/browse/FLINK-17083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083040#comment-17083040
]
Aljoscha Krettek commented on FLINK-17083:
--
Yes, I think that restriction makes sense.
> Restrict users of accumulators not to return null in Accumulator#getLocalValue
> --
>
> Key: FLINK-17083
> URL: https://issues.apache.org/jira/browse/FLINK-17083
> Project: Flink
> Issue Type: Improvement
> Components: API / Core
>Affects Versions: 1.11.0
>Reporter: Caizhi Weng
>Priority: Major
>
> [This discussion|https://issues.apache.org/jira/browse/FLINK-13880] raises a
> problem that, if a user returns a null value in
> {{Accumulator#getLocalValue}}, he will be notified that the {{failureCause}}
> should not be null when fetching the accumulator result, which seems to be
> really wired.
> The problem is that we're not explicitly restricting the users not to return
> null values in {{Accumulator#getLocalValue}}.
> [~aljoscha] is it legal to return null values? If not, we should explicitly
> throw a related exception to the users instead of giving the users a somewhat
> unrelated exception.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
