[jira] [Commented] (FLINK-17110) Make StreamExecutionEnvironment#configure also affects StreamExecutionEnvironment#configuration

2021-04-29 Thread Flink Jira Bot (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17336237#comment-17336237
 ] 

Flink Jira Bot commented on FLINK-17110:


This issue was labeled "stale-major" 7 ago and has not received any updates so 
it is being deprioritized. If this ticket is actually Major, please raise the 
priority and ask a committer to assign you the issue or revive the public 
discussion.


> Make StreamExecutionEnvironment#configure also affects 
> StreamExecutionEnvironment#configuration
> ---
>
> Key: FLINK-17110
> URL: https://issues.apache.org/jira/browse/FLINK-17110
> Project: Flink
>  Issue Type: Improvement
>  Components: API / DataStream
>Reporter: Wenlong Lyu
>Priority: Major
>  Labels: pull-request-available, stale-major
>
> If StreamExecutionEnvironment#configure can also affect the configuration in 
> StreamExecutionEnvironment, we can easily not only add some library jars or 
> classpaths dynamically according to the job we want to run which is quite 
> important for a platform product, but also optimize some runtime 
> configuration in program.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-17110) Make StreamExecutionEnvironment#configure also affects StreamExecutionEnvironment#configuration

2021-04-22 Thread Flink Jira Bot (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17327922#comment-17327922
 ] 

Flink Jira Bot commented on FLINK-17110:


This major issue is unassigned and itself and all of its Sub-Tasks have not 
been updated for 30 days. So, it has been labeled "stale-major". If this ticket 
is indeed "major", please either assign yourself or give an update. Afterwards, 
please remove the label. In 7 days the issue will be deprioritized.

> Make StreamExecutionEnvironment#configure also affects 
> StreamExecutionEnvironment#configuration
> ---
>
> Key: FLINK-17110
> URL: https://issues.apache.org/jira/browse/FLINK-17110
> Project: Flink
>  Issue Type: Improvement
>  Components: API / DataStream
>Reporter: Wenlong Lyu
>Priority: Major
>  Labels: pull-request-available, stale-major
>
> If StreamExecutionEnvironment#configure can also affect the configuration in 
> StreamExecutionEnvironment, we can easily not only add some library jars or 
> classpaths dynamically according to the job we want to run which is quite 
> important for a platform product, but also optimize some runtime 
> configuration in program.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-17110) Make StreamExecutionEnvironment#configure also affects StreamExecutionEnvironment#configuration

2020-04-17 Thread Kostas Kloudas (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085596#comment-17085596
 ] 

Kostas Kloudas commented on FLINK-17110:


I agree that the two configurations should be consolidated, but we should be 
clear on the prioritisation of the different places where the user can 
configure things. For example, in the attached branch, if the user passes a 
{{configuration}} on the constructor of the environment, and then uses 
{{configure()}}  then the {{configure()}}  has priority. 

This should be documented.

> Make StreamExecutionEnvironment#configure also affects 
> StreamExecutionEnvironment#configuration
> ---
>
> Key: FLINK-17110
> URL: https://issues.apache.org/jira/browse/FLINK-17110
> Project: Flink
>  Issue Type: Improvement
>Reporter: Wenlong Lyu
>Priority: Major
>
> If StreamExecutionEnvironment#configure can also affect the configuration in 
> StreamExecutionEnvironment, we can easily not only add some library jars or 
> classpaths dynamically according to the job we want to run which is quite 
> important for a platform product, but also optimize some runtime 
> configuration in program.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-17110) Make StreamExecutionEnvironment#configure also affects StreamExecutionEnvironment#configuration

2020-04-16 Thread Aljoscha Krettek (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084697#comment-17084697
 ] 

Aljoscha Krettek commented on FLINK-17110:
--

I think it should be OK to apply the Configuration. What do you think, [~kkl0u]?

> Make StreamExecutionEnvironment#configure also affects 
> StreamExecutionEnvironment#configuration
> ---
>
> Key: FLINK-17110
> URL: https://issues.apache.org/jira/browse/FLINK-17110
> Project: Flink
>  Issue Type: Improvement
>Reporter: Wenlong Lyu
>Priority: Major
>
> If StreamExecutionEnvironment#configure can also affect the configuration in 
> StreamExecutionEnvironment, we can easily not only add some library jars or 
> classpaths dynamically according to the job we want to run which is quite 
> important for a platform product, but also optimize some runtime 
> configuration in program.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-17110) Make StreamExecutionEnvironment#configure also affects StreamExecutionEnvironment#configuration

2020-04-15 Thread Wenlong Lyu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083957#comment-17083957
 ] 

Wenlong Lyu commented on FLINK-17110:
-

hi, [~aljoscha][~kkl0u] Do you have any more comments? Here is a patch : 
https://github.com/wenlong88/flink/commit/651a48ce4d837623e6eacb4814bd1e43c686fdd4,
 mainly contains two points of change:
1. use PipelineExecutorUtils to generate JobGraph so that the configuration in 
StreamExecutionEnvironment can affect on JobGraph, unifying the manner on 
RemoteExecutor, LocalExecutor, ClasspathJobGraphRetriever and web submit 
handler.
2. make configuration in StreamExecutionEnvironment configurable by 
StreamExecutionEnvironment#configure, so that user can update the configuration 
in the program.

> Make StreamExecutionEnvironment#configure also affects 
> StreamExecutionEnvironment#configuration
> ---
>
> Key: FLINK-17110
> URL: https://issues.apache.org/jira/browse/FLINK-17110
> Project: Flink
>  Issue Type: Improvement
>Reporter: Wenlong Lyu
>Priority: Major
>
> If StreamExecutionEnvironment#configure can also affect the configuration in 
> StreamExecutionEnvironment, we can easily not only add some library jars or 
> classpaths dynamically according to the job we want to run which is quite 
> important for a platform product, but also optimize some runtime 
> configuration in program.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)