[jira] [Commented] (FLINK-22408) Flink Table Parsr Hive Drop Partitions Syntax unparse is Error
[
https://issues.apache.org/jira/browse/FLINK-22408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342543#comment-17342543
]
Rui Li commented on FLINK-22408:
Yes, we should also fix it in 1.13.
> Flink Table Parsr Hive Drop Partitions Syntax unparse is Error
> --
>
> Key: FLINK-22408
> URL: https://issues.apache.org/jira/browse/FLINK-22408
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Hive
>Affects Versions: 1.11.3
>Reporter: Ma Jun
>Assignee: Ma Jun
>Priority: Major
> Labels: pull-request-available
>
> Flink Table Parser is error：
> *Synopsis:*
>
> *SQL：*
> {code:java}
> alter table tbl drop partition (p1='a',p2=1), partition(p1='b',p2=2);{code}
> *hive muit partition unparse toSqlString is :*
> {code:java}
> ALTER TABLE `TBL`\n" +
> "DROP\n" +
> "PARTITION (`P1` = 'a', `P2` = 1)\n" +
> "PARTITION (`P1` = 'b', `P2` = 2)
> {code}
> Missing comma in Partition SqlNodeList
> Hive syntax：
> {code:java}
> ALTER TABLE table_name DROP [IF EXISTS] PARTITION (partition_spec) [,
> PARTITION (partition_spec)];
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-22408) Flink Table Parsr Hive Drop Partitions Syntax unparse is Error
[
https://issues.apache.org/jira/browse/FLINK-22408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342528#comment-17342528
]
Ma Jun commented on FLINK-22408:
Hi [~lirui] , The branch release-1.13 need to submit?
> Flink Table Parsr Hive Drop Partitions Syntax unparse is Error
> --
>
> Key: FLINK-22408
> URL: https://issues.apache.org/jira/browse/FLINK-22408
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Hive
>Affects Versions: 1.11.3
>Reporter: Ma Jun
>Assignee: Ma Jun
>Priority: Major
> Labels: pull-request-available
>
> Flink Table Parser is error：
> *Synopsis:*
>
> *SQL：*
> {code:java}
> alter table tbl drop partition (p1='a',p2=1), partition(p1='b',p2=2);{code}
> *hive muit partition unparse toSqlString is :*
> {code:java}
> ALTER TABLE `TBL`\n" +
> "DROP\n" +
> "PARTITION (`P1` = 'a', `P2` = 1)\n" +
> "PARTITION (`P1` = 'b', `P2` = 2)
> {code}
> Missing comma in Partition SqlNodeList
> Hive syntax：
> {code:java}
> ALTER TABLE table_name DROP [IF EXISTS] PARTITION (partition_spec) [,
> PARTITION (partition_spec)];
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-22408) Flink Table Parsr Hive Drop Partitions Syntax unparse is Error
[
https://issues.apache.org/jira/browse/FLINK-22408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342469#comment-17342469
]
Rui Li commented on FLINK-22408:
Fixed in master: TBD
Fixed in release-1.13: TBD
Fixed in release-1.12: 9e5b0d408b110bbc56987c383435be9c3da394ac
> Flink Table Parsr Hive Drop Partitions Syntax unparse is Error
> --
>
> Key: FLINK-22408
> URL: https://issues.apache.org/jira/browse/FLINK-22408
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Hive
>Affects Versions: 1.11.3
>Reporter: Ma Jun
>Priority: Major
> Labels: pull-request-available
>
> Flink Table Parser is error：
> *Synopsis:*
>
> *SQL：*
> {code:java}
> alter table tbl drop partition (p1='a',p2=1), partition(p1='b',p2=2);{code}
> *hive muit partition unparse toSqlString is :*
> {code:java}
> ALTER TABLE `TBL`\n" +
> "DROP\n" +
> "PARTITION (`P1` = 'a', `P2` = 1)\n" +
> "PARTITION (`P1` = 'b', `P2` = 2)
> {code}
> Missing comma in Partition SqlNodeList
> Hive syntax：
> {code:java}
> ALTER TABLE table_name DROP [IF EXISTS] PARTITION (partition_spec) [,
> PARTITION (partition_spec)];
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-22408) Flink Table Parsr Hive Drop Partitions Syntax unparse is Error
[
https://issues.apache.org/jira/browse/FLINK-22408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342468#comment-17342468
]
Rui Li commented on FLINK-22408:
Hi [~aidenma], I realized the fix is in {{SqlDropPartitions}} which is not only
used by hive. So please also submit a PR for master.
> Flink Table Parsr Hive Drop Partitions Syntax unparse is Error
> --
>
> Key: FLINK-22408
> URL: https://issues.apache.org/jira/browse/FLINK-22408
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Hive
>Affects Versions: 1.11.3
>Reporter: Ma Jun
>Priority: Major
> Labels: pull-request-available
>
> Flink Table Parser is error：
> *Synopsis:*
>
> *SQL：*
> {code:java}
> alter table tbl drop partition (p1='a',p2=1), partition(p1='b',p2=2);{code}
> *hive muit partition unparse toSqlString is :*
> {code:java}
> ALTER TABLE `TBL`\n" +
> "DROP\n" +
> "PARTITION (`P1` = 'a', `P2` = 1)\n" +
> "PARTITION (`P1` = 'b', `P2` = 2)
> {code}
> Missing comma in Partition SqlNodeList
> Hive syntax：
> {code:java}
> ALTER TABLE table_name DROP [IF EXISTS] PARTITION (partition_spec) [,
> PARTITION (partition_spec)];
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-22408) Flink Table Parsr Hive Drop Partitions Syntax unparse is Error
[
https://issues.apache.org/jira/browse/FLINK-22408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340600#comment-17340600
]
Ma Jun commented on FLINK-22408:
[~lirui] The branch has been pulled according to realease-1.12. See the link
for details.
> Flink Table Parsr Hive Drop Partitions Syntax unparse is Error
> --
>
> Key: FLINK-22408
> URL: https://issues.apache.org/jira/browse/FLINK-22408
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Hive
>Affects Versions: 1.11.3
>Reporter: Ma Jun
>Priority: Major
> Labels: pull-request-available
>
> Flink Table Parser is error：
> *Synopsis:*
>
> *SQL：*
> {code:java}
> alter table tbl drop partition (p1='a',p2=1), partition(p1='b',p2=2);{code}
> *hive muit partition unparse toSqlString is :*
> {code:java}
> ALTER TABLE `TBL`\n" +
> "DROP\n" +
> "PARTITION (`P1` = 'a', `P2` = 1)\n" +
> "PARTITION (`P1` = 'b', `P2` = 2)
> {code}
> Missing comma in Partition SqlNodeList
> Hive syntax：
> {code:java}
> ALTER TABLE table_name DROP [IF EXISTS] PARTITION (partition_spec) [,
> PARTITION (partition_spec)];
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-22408) Flink Table Parsr Hive Drop Partitions Syntax unparse is Error
[
https://issues.apache.org/jira/browse/FLINK-22408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332945#comment-17332945
]
Rui Li commented on FLINK-22408:
[~aidenma] OK. I think we can fix this issue in release-1.12 branch. We don't
need to fix it in 1.13 and later, since the calcite parser is deprecated. So
please submit a PR for 1.12.
> Flink Table Parsr Hive Drop Partitions Syntax unparse is Error
> --
>
> Key: FLINK-22408
> URL: https://issues.apache.org/jira/browse/FLINK-22408
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Hive
>Affects Versions: 1.11.3
>Reporter: Ma Jun
>Priority: Major
> Labels: pull-request-available
>
> Flink Table Parser is error：
> *Synopsis:*
>
> *SQL：*
> {code:java}
> alter table tbl drop partition (p1='a',p2=1), partition(p1='b',p2=2);{code}
> *hive muit partition unparse toSqlString is :*
> {code:java}
> ALTER TABLE `TBL`\n" +
> "DROP\n" +
> "PARTITION (`P1` = 'a', `P2` = 1)\n" +
> "PARTITION (`P1` = 'b', `P2` = 2)
> {code}
> Missing comma in Partition SqlNodeList
> Hive syntax：
> {code:java}
> ALTER TABLE table_name DROP [IF EXISTS] PARTITION (partition_spec) [,
> PARTITION (partition_spec)];
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-22408) Flink Table Parsr Hive Drop Partitions Syntax unparse is Error
[
https://issues.apache.org/jira/browse/FLINK-22408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332910#comment-17332910
]
Ma Jun commented on FLINK-22408:
Hi [~lirui] Thank！I got it! I know that if there is a subsequent release of
version 1.13, I will switch the version of the existing business. I have a
business requirement here: I use the module SQL translation in Flink to do some
front-end SQL verification and formatting, because I found that the syntax of
hive is inconsistent when converting dialects. So I think we should keep the
syntax consistent with hive.
> Flink Table Parsr Hive Drop Partitions Syntax unparse is Error
> --
>
> Key: FLINK-22408
> URL: https://issues.apache.org/jira/browse/FLINK-22408
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Hive
>Affects Versions: 1.11.3
>Reporter: Ma Jun
>Priority: Major
> Labels: pull-request-available
>
> Flink Table Parser is error：
> *Synopsis:*
>
> *SQL：*
> {code:java}
> alter table tbl drop partition (p1='a',p2=1), partition(p1='b',p2=2);{code}
> *hive muit partition unparse toSqlString is :*
> {code:java}
> ALTER TABLE `TBL`\n" +
> "DROP\n" +
> "PARTITION (`P1` = 'a', `P2` = 1)\n" +
> "PARTITION (`P1` = 'b', `P2` = 2)
> {code}
> Missing comma in Partition SqlNodeList
> Hive syntax：
> {code:java}
> ALTER TABLE table_name DROP [IF EXISTS] PARTITION (partition_spec) [,
> PARTITION (partition_spec)];
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-22408) Flink Table Parsr Hive Drop Partitions Syntax unparse is Error
[
https://issues.apache.org/jira/browse/FLINK-22408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330015#comment-17330015
]
Jark Wu commented on FLINK-22408:
-
Sorry, I was thinking this is used in default dialect.
> Flink Table Parsr Hive Drop Partitions Syntax unparse is Error
> --
>
> Key: FLINK-22408
> URL: https://issues.apache.org/jira/browse/FLINK-22408
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Hive
>Affects Versions: 1.11.3
>Reporter: Ma Jun
>Priority: Major
> Labels: pull-request-available
>
> Flink Table Parser is error：
> *Synopsis:*
>
> *SQL：*
> {code:java}
> alter table tbl drop partition (p1='a',p2=1), partition(p1='b',p2=2);{code}
> *hive muit partition unparse toSqlString is :*
> {code:java}
> ALTER TABLE `TBL`\n" +
> "DROP\n" +
> "PARTITION (`P1` = 'a', `P2` = 1)\n" +
> "PARTITION (`P1` = 'b', `P2` = 2)
> {code}
> Missing comma in Partition SqlNodeList
> Hive syntax：
> {code:java}
> ALTER TABLE table_name DROP [IF EXISTS] PARTITION (partition_spec) [,
> PARTITION (partition_spec)];
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-22408) Flink Table Parsr Hive Drop Partitions Syntax unparse is Error
[
https://issues.apache.org/jira/browse/FLINK-22408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330010#comment-17330010
]
Rui Li commented on FLINK-22408:
Hi [~jark], the feature is already supported:
https://ci.apache.org/projects/flink/flink-docs-release-1.12/dev/table/connectors/hive/hive_dialect.html#drop-partitions
The issue here is the unparse result of the SqlNode is incorrect.
> Flink Table Parsr Hive Drop Partitions Syntax unparse is Error
> --
>
> Key: FLINK-22408
> URL: https://issues.apache.org/jira/browse/FLINK-22408
> Project: Flink
> Issue Type: New Feature
> Components: Table SQL / API, Table SQL / Planner
>Affects Versions: 1.11.3
>Reporter: Ma Jun
>Priority: Major
> Labels: pull-request-available
>
> Flink Table Parser is error：
> *Synopsis:*
>
> *SQL：*
> {code:java}
> alter table tbl drop partition (p1='a',p2=1), partition(p1='b',p2=2);{code}
> *hive muit partition unparse toSqlString is :*
> {code:java}
> ALTER TABLE `TBL`\n" +
> "DROP\n" +
> "PARTITION (`P1` = 'a', `P2` = 1)\n" +
> "PARTITION (`P1` = 'b', `P2` = 2)
> {code}
> Missing comma in Partition SqlNodeList
> Hive syntax：
> {code:java}
> ALTER TABLE table_name DROP [IF EXISTS] PARTITION (partition_spec) [,
> PARTITION (partition_spec)];
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-22408) Flink Table Parsr Hive Drop Partitions Syntax unparse is Error
[
https://issues.apache.org/jira/browse/FLINK-22408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330009#comment-17330009
]
Rui Li commented on FLINK-22408:
Hi [~aidenma], thanks for reporting the issue. I think it's a valid one. But I
don't see why it can lead to Hive SQL failure. Are you somehow relying on the
unparse result in your code?
And btw, in flink 1.13 we have added {{HiveParser}} to support hive dialect.
The old calcite parser (for hive) is deprecated and will eventually be removed.
> Flink Table Parsr Hive Drop Partitions Syntax unparse is Error
> --
>
> Key: FLINK-22408
> URL: https://issues.apache.org/jira/browse/FLINK-22408
> Project: Flink
> Issue Type: New Feature
> Components: Table SQL / API, Table SQL / Planner
>Affects Versions: 1.11.3
>Reporter: Ma Jun
>Priority: Major
> Labels: pull-request-available
>
> Flink Table Parser is error：
> *Synopsis:*
>
> *SQL：*
> {code:java}
> alter table tbl drop partition (p1='a',p2=1), partition(p1='b',p2=2);{code}
> *hive muit partition unparse toSqlString is :*
> {code:java}
> ALTER TABLE `TBL`\n" +
> "DROP\n" +
> "PARTITION (`P1` = 'a', `P2` = 1)\n" +
> "PARTITION (`P1` = 'b', `P2` = 2)
> {code}
> Missing comma in Partition SqlNodeList
> Hive syntax：
> {code:java}
> ALTER TABLE table_name DROP [IF EXISTS] PARTITION (partition_spec) [,
> PARTITION (partition_spec)];
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-22408) Flink Table Parsr Hive Drop Partitions Syntax unparse is Error
[
https://issues.apache.org/jira/browse/FLINK-22408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329983#comment-17329983
]
Ma Jun commented on FLINK-22408:
I think the final Unparse result：
{code:java}
alter table tbl drop partition (p1='a',p2=1), partition(p1='b',p2=2);
{code}
> Flink Table Parsr Hive Drop Partitions Syntax unparse is Error
> --
>
> Key: FLINK-22408
> URL: https://issues.apache.org/jira/browse/FLINK-22408
> Project: Flink
> Issue Type: New Feature
> Components: Table SQL / API, Table SQL / Planner
>Affects Versions: 1.11.3
>Reporter: Ma Jun
>Priority: Major
> Labels: pull-request-available
>
> Flink Table Parser is error：
> *Synopsis:*
>
> *SQL：*
> {code:java}
> alter table tbl drop partition (p1='a',p2=1), partition(p1='b',p2=2);{code}
> *hive muit partition unparse toSqlString is :*
> {code:java}
> ALTER TABLE `TBL`\n" +
> "DROP\n" +
> "PARTITION (`P1` = 'a', `P2` = 1)\n" +
> "PARTITION (`P1` = 'b', `P2` = 2)
> {code}
> Missing comma in Partition SqlNodeList
> Hive syntax：
> {code:java}
> ALTER TABLE table_name DROP [IF EXISTS] PARTITION (partition_spec) [,
> PARTITION (partition_spec)];
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-22408) Flink Table Parsr Hive Drop Partitions Syntax unparse is Error
[
https://issues.apache.org/jira/browse/FLINK-22408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329981#comment-17329981
]
Ma Jun commented on FLINK-22408:
We mainly use hive in the table environment. We find this syntax problem in the
production environment. At present, there is a difference between hive and hive
syntax, which leads to Hive SQL failure.
> Flink Table Parsr Hive Drop Partitions Syntax unparse is Error
> --
>
> Key: FLINK-22408
> URL: https://issues.apache.org/jira/browse/FLINK-22408
> Project: Flink
> Issue Type: New Feature
> Components: Table SQL / API, Table SQL / Planner
>Affects Versions: 1.11.3
>Reporter: Ma Jun
>Priority: Major
> Labels: pull-request-available
>
> Flink Table Parser is error：
> *Synopsis:*
>
> *SQL：*
> {code:java}
> alter table tbl drop partition (p1='a',p2=1), partition(p1='b',p2=2);{code}
> *hive muit partition unparse toSqlString is :*
> {code:java}
> ALTER TABLE `TBL`\n" +
> "DROP\n" +
> "PARTITION (`P1` = 'a', `P2` = 1)\n" +
> "PARTITION (`P1` = 'b', `P2` = 2)
> {code}
> Missing comma in Partition SqlNodeList
> Hive syntax：
> {code:java}
> ALTER TABLE table_name DROP [IF EXISTS] PARTITION (partition_spec) [,
> PARTITION (partition_spec)];
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-22408) Flink Table Parsr Hive Drop Partitions Syntax unparse is Error
[
https://issues.apache.org/jira/browse/FLINK-22408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329965#comment-17329965
]
Jark Wu commented on FLINK-22408:
-
This is an unsupported feature and we should discuss the synax API first before
moving to pull request.
> Flink Table Parsr Hive Drop Partitions Syntax unparse is Error
> --
>
> Key: FLINK-22408
> URL: https://issues.apache.org/jira/browse/FLINK-22408
> Project: Flink
> Issue Type: New Feature
> Components: Table SQL / API, Table SQL / Planner
>Affects Versions: 1.11.3
>Reporter: Ma Jun
>Priority: Major
> Labels: pull-request-available
>
> Flink Table Parser is error：
> *Synopsis:*
>
> *SQL：*
> {code:java}
> alter table tbl drop partition (p1='a',p2=1), partition(p1='b',p2=2);{code}
> *hive muit partition unparse toSqlString is :*
> {code:java}
> ALTER TABLE `TBL`\n" +
> "DROP\n" +
> "PARTITION (`P1` = 'a', `P2` = 1)\n" +
> "PARTITION (`P1` = 'b', `P2` = 2)
> {code}
> Missing comma in Partition SqlNodeList
> Hive syntax：
> {code:java}
> ALTER TABLE table_name DROP [IF EXISTS] PARTITION (partition_spec) [,
> PARTITION (partition_spec)];
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
