[jira] [Commented] (FLINK-23313) Reintroduce temporal table function documentation

2021-09-29 Thread Seth Wiesman (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422407#comment-17422407
 ] 

Seth Wiesman commented on FLINK-23313:
--

resolved in release-1.14: fc8e269e9415a75fe9d1c5634eef2caaf059e1bc

master: a328e3b2a264a914d9fef4a94f91eecc6623a08c

> Reintroduce temporal table function documentation
> -
>
> Key: FLINK-23313
> URL: https://issues.apache.org/jira/browse/FLINK-23313
> Project: Flink
>  Issue Type: Bug
>  Components: Documentation, Table SQL / API
>Reporter: Timo Walther
>Assignee: Leonard Xu
>Priority: Critical
>  Labels: pull-request-available
>
> FLIP-132 introduced the new {{FOR SYSTEM_TIME AS OF}} and dropped the main 
> documentation for temporal table function. This causes a lot of confusion for 
> users.
> First, because processing time joins are not supported yet.
> Second, because a primary key might not always be present in the current 
> pipeline when using Table API.
> We have not deprecated `createTemporalTableFunction` and the documentation in 
> https://ci.apache.org/projects/flink/flink-docs-release-1.13/docs/dev/table/tableapi/#join-with-temporal-table
>  is not enough.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-23313) Reintroduce temporal table function documentation

2021-09-08 Thread Leonard Xu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411906#comment-17411906
 ] 

Leonard Xu commented on FLINK-23313:


[~MartijnVisser] Sure, please assign this to me.

> Reintroduce temporal table function documentation
> -
>
> Key: FLINK-23313
> URL: https://issues.apache.org/jira/browse/FLINK-23313
> Project: Flink
>  Issue Type: Bug
>  Components: Documentation, Table SQL / API
>Reporter: Timo Walther
>Priority: Critical
>
> FLIP-132 introduced the new {{FOR SYSTEM_TIME AS OF}} and dropped the main 
> documentation for temporal table function. This causes a lot of confusion for 
> users.
> First, because processing time joins are not supported yet.
> Second, because a primary key might not always be present in the current 
> pipeline when using Table API.
> We have not deprecated `createTemporalTableFunction` and the documentation in 
> https://ci.apache.org/projects/flink/flink-docs-release-1.13/docs/dev/table/tableapi/#join-with-temporal-table
>  is not enough.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-23313) Reintroduce temporal table function documentation

2021-09-08 Thread Martijn Visser (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411896#comment-17411896
 ] 

Martijn Visser commented on FLINK-23313:


[~Leonard Xu] Should I still assign this ticket to you?

> Reintroduce temporal table function documentation
> -
>
> Key: FLINK-23313
> URL: https://issues.apache.org/jira/browse/FLINK-23313
> Project: Flink
>  Issue Type: Bug
>  Components: Documentation, Table SQL / API
>Reporter: Timo Walther
>Priority: Critical
>
> FLIP-132 introduced the new {{FOR SYSTEM_TIME AS OF}} and dropped the main 
> documentation for temporal table function. This causes a lot of confusion for 
> users.
> First, because processing time joins are not supported yet.
> Second, because a primary key might not always be present in the current 
> pipeline when using Table API.
> We have not deprecated `createTemporalTableFunction` and the documentation in 
> https://ci.apache.org/projects/flink/flink-docs-release-1.13/docs/dev/table/tableapi/#join-with-temporal-table
>  is not enough.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-23313) Reintroduce temporal table function documentation

2021-07-08 Thread Leonard Xu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17377347#comment-17377347
 ] 

Leonard Xu commented on FLINK-23313:


Thanks [~twalthr] for open this ticket, I keep the temporal table function in 
FLINK-19082, but the documentation lost  latter. I agree that we should 
reIntroduce it until we support  processing time temporal join.

Could you assign this ticket to me ? 

> Reintroduce temporal table function documentation
> -
>
> Key: FLINK-23313
> URL: https://issues.apache.org/jira/browse/FLINK-23313
> Project: Flink
>  Issue Type: Bug
>  Components: Documentation, Table SQL / API
>Reporter: Timo Walther
>Priority: Critical
>
> FLIP-132 introduced the new {{FOR SYSTEM_TIME AS OF}} and dropped the main 
> documentation for temporal table function. This causes a lot of confusion for 
> users.
> First, because processing time joins are not supported yet.
> Second, because a primary key might not always be present in the current 
> pipeline when using Table API.
> We have not deprecated `createTemporalTableFunction` and the documentation in 
> https://ci.apache.org/projects/flink/flink-docs-release-1.13/docs/dev/table/tableapi/#join-with-temporal-table
>  is not enough.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-23313) Reintroduce temporal table function documentation

2021-07-08 Thread Timo Walther (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17377337#comment-17377337
 ] 

Timo Walther commented on FLINK-23313:
--

CC [~Leonard Xu]

> Reintroduce temporal table function documentation
> -
>
> Key: FLINK-23313
> URL: https://issues.apache.org/jira/browse/FLINK-23313
> Project: Flink
>  Issue Type: Bug
>  Components: Documentation, Table SQL / API
>Reporter: Timo Walther
>Priority: Critical
>
> FLIP-132 introduced the new {{FOR SYSTEM_TIME AS OF}} and dropped the main 
> documentation for temporal table function. This causes a lot of confusion for 
> users.
> First, because processing time joins are not supported yet.
> Second, because a primary key might not always be present in the current 
> pipeline when using Table API.
> We have not deprecated `createTemporalTableFunction` and the documentation in 
> https://ci.apache.org/projects/flink/flink-docs-release-1.13/docs/dev/table/tableapi/#join-with-temporal-table
>  is not enough.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)