[jira] [Commented] (FLINK-24054) Let SinkUpsertMaterializer emit +U instead of only +I

2021-09-02 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17408828#comment-17408828 ] Timo Walther commented on FLINK-24054: -- [~ykt836] sorry, I saw you comment to late. I just marked

[jira] [Commented] (FLINK-24054) Let SinkUpsertMaterializer emit +U instead of only +I

2021-08-31 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407735#comment-17407735 ] Kurt Young commented on FLINK-24054: You opinions also make sense in some cases. That's exactly what

[jira] [Commented] (FLINK-24054) Let SinkUpsertMaterializer emit +U instead of only +I

2021-08-31 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407237#comment-17407237 ] Arvid Heise commented on FLINK-24054: - If the external system strictly follows +I key +I key, you

[jira] [Commented] (FLINK-24054) Let SinkUpsertMaterializer emit +U instead of only +I

2021-08-31 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407231#comment-17407231 ] Timo Walther commented on FLINK-24054: -- In the first version, the test was failing because I did

[jira] [Commented] (FLINK-24054) Let SinkUpsertMaterializer emit +U instead of only +I

2021-08-31 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407218#comment-17407218 ] Kurt Young commented on FLINK-24054: The example you gave is test, whose behavior could be changed &

[jira] [Commented] (FLINK-24054) Let SinkUpsertMaterializer emit +U instead of only +I

2021-08-31 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407214#comment-17407214 ] Timo Walther commented on FLINK-24054: -- It really depends on the use case. For our current Kafka

[jira] [Commented] (FLINK-24054) Let SinkUpsertMaterializer emit +U instead of only +I

2021-08-31 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407171#comment-17407171 ] Kurt Young commented on FLINK-24054: In most cases, +I and -D are easier to handle, and are