[jira] [Commented] (FLINK-2771) IterateTest.testSimpleIteration fails on Travis

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889659#comment-15889659
 ] 

ASF GitHub Bot commented on FLINK-2771:
---

Github user rekhajoshm commented on the issue:

https://github.com/apache/flink/pull/2028
  
done @uce 


> IterateTest.testSimpleIteration fails on Travis
> ---
>
> Key: FLINK-2771
> URL: https://issues.apache.org/jira/browse/FLINK-2771
> Project: Flink
>  Issue Type: Bug
>  Components: Local Runtime
>Affects Versions: 0.10.0
>Reporter: Till Rohrmann
>Assignee: Rekha Joshi
>Priority: Critical
>  Labels: test-stability
> Fix For: 1.0.0
>
>
> The {{IterateTest.testSimpleIteration}} failed on Travis with
> {code}
> Failed tests: 
>   IterateTest.testSimpleIteration:384 null
> {code}
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/81986242/log.txt 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-2771) IterateTest.testSimpleIteration fails on Travis

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889660#comment-15889660
 ] 

ASF GitHub Bot commented on FLINK-2771:
---

Github user rekhajoshm closed the pull request at:

https://github.com/apache/flink/pull/2028


> IterateTest.testSimpleIteration fails on Travis
> ---
>
> Key: FLINK-2771
> URL: https://issues.apache.org/jira/browse/FLINK-2771
> Project: Flink
>  Issue Type: Bug
>  Components: Local Runtime
>Affects Versions: 0.10.0
>Reporter: Till Rohrmann
>Assignee: Rekha Joshi
>Priority: Critical
>  Labels: test-stability
> Fix For: 1.0.0
>
>
> The {{IterateTest.testSimpleIteration}} failed on Travis with
> {code}
> Failed tests: 
>   IterateTest.testSimpleIteration:384 null
> {code}
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/81986242/log.txt 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-2771) IterateTest.testSimpleIteration fails on Travis

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888285#comment-15888285
 ] 

ASF GitHub Bot commented on FLINK-2771:
---

Github user uce commented on the issue:

https://github.com/apache/flink/pull/2028
  
I think the proper solution to this is outside of the scope of this PR. 
This hasn't occurred in a long time. I will change the timeout to the suggested 
5000 ms and merge this.


> IterateTest.testSimpleIteration fails on Travis
> ---
>
> Key: FLINK-2771
> URL: https://issues.apache.org/jira/browse/FLINK-2771
> Project: Flink
>  Issue Type: Bug
>  Components: Local Runtime
>Affects Versions: 0.10.0
>Reporter: Till Rohrmann
>Assignee: Rekha Joshi
>Priority: Critical
>  Labels: test-stability
> Fix For: 1.0.0
>
>
> The {{IterateTest.testSimpleIteration}} failed on Travis with
> {code}
> Failed tests: 
>   IterateTest.testSimpleIteration:384 null
> {code}
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/81986242/log.txt 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-2771) IterateTest.testSimpleIteration fails on Travis

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888286#comment-15888286
 ] 

ASF GitHub Bot commented on FLINK-2771:
---

Github user uce commented on the issue:

https://github.com/apache/flink/pull/2028
  
Turns out the test has been removed in the mean time. Could you please 
close this PR @rekhajoshm?


> IterateTest.testSimpleIteration fails on Travis
> ---
>
> Key: FLINK-2771
> URL: https://issues.apache.org/jira/browse/FLINK-2771
> Project: Flink
>  Issue Type: Bug
>  Components: Local Runtime
>Affects Versions: 0.10.0
>Reporter: Till Rohrmann
>Assignee: Rekha Joshi
>Priority: Critical
>  Labels: test-stability
> Fix For: 1.0.0
>
>
> The {{IterateTest.testSimpleIteration}} failed on Travis with
> {code}
> Failed tests: 
>   IterateTest.testSimpleIteration:384 null
> {code}
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/81986242/log.txt 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-2771) IterateTest.testSimpleIteration fails on Travis

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301987#comment-15301987
 ] 

ASF GitHub Bot commented on FLINK-2771:
---

Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/2028#issuecomment-221853220
  
Thanks for looking into this.
Making the iteration timeout longer makes the test more stable, but still 
not absolutely stable. It also increases the time that the build takes, for 
every build.

I think a good start would be to increase the timeout to 5000 (a bit more 
stability), and then actually improve the test and the iterations themselves:

  - The test case could be modified to actually run the program with a 
large iteration timeout. But the program is started in a separate thread, and 
the main thread checks for the result periodically (every 50ms or so) and 
cancels the program as soon as the expected result is there. That way, the test 
will return fast if the execution is fast, and will still be pretty reliable, 
because the termination has a long timeout.

  - We should change the stream iteration behavior from a timeout-based 
termination to a proper "end-of-stream-event" based termination. That would 
also automatically make the test reliable and predictable. This is a bit more 
involved, but would be the best solution. I'd be happy to write more about that 
in a design doc, if you want to do that.

Please let us know if you would be up for helping out with these efforts!


> IterateTest.testSimpleIteration fails on Travis
> ---
>
> Key: FLINK-2771
> URL: https://issues.apache.org/jira/browse/FLINK-2771
> Project: Flink
>  Issue Type: Bug
>Affects Versions: 0.10.0
>Reporter: Till Rohrmann
>Assignee: Rekha Joshi
>Priority: Critical
>  Labels: test-stability
> Fix For: 1.0.0
>
>
> The {{IterateTest.testSimpleIteration}} failed on Travis with
> {code}
> Failed tests: 
>   IterateTest.testSimpleIteration:384 null
> {code}
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/81986242/log.txt 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2771) IterateTest.testSimpleIteration fails on Travis

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298692#comment-15298692
 ] 

ASF GitHub Bot commented on FLINK-2771:
---

GitHub user rekhajoshm opened a pull request:

https://github.com/apache/flink/pull/2028

[FLINK-2771] Fix for IterateTest.testSimpleIteration fail on Travis

[FLINK-2771] Fix for IterateTest.testSimpleIteration fail on Travis

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rekhajoshm/flink FLINK-2771

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/2028.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2028


commit d7df832c17592d840d1419e4b6bc1764664c2e75
Author: Joshi 
Date:   2016-05-24T18:46:40Z

[FLINK-2771] Fix for IterateTest.testSimpleIteration fail on Travis




> IterateTest.testSimpleIteration fails on Travis
> ---
>
> Key: FLINK-2771
> URL: https://issues.apache.org/jira/browse/FLINK-2771
> Project: Flink
>  Issue Type: Bug
>Affects Versions: 0.10.0
>Reporter: Till Rohrmann
>Assignee: Rekha Joshi
>Priority: Critical
>  Labels: test-stability
> Fix For: 1.0.0
>
>
> The {{IterateTest.testSimpleIteration}} failed on Travis with
> {code}
> Failed tests: 
>   IterateTest.testSimpleIteration:384 null
> {code}
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/81986242/log.txt 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-2771) IterateTest.testSimpleIteration fails on Travis

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-2771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008777#comment-15008777
 ] 

ASF GitHub Bot commented on FLINK-2771:
---

Github user mliesenberg commented on the pull request:

https://github.com/apache/flink/pull/1367#issuecomment-157394443
  
several travis builds failed:
oraclejdk8 & hadoop 2.7: https://issues.apache.org/jira/browse/FLINK-2771
oraclejdk8 & hadoop 2.5: https://issues.apache.org/jira/browse/FLINK-2392
openjdk7 & hadoop 2.4: error in test: 
JobManagerSubmittedJobGraphsRecoveryITCase.cleanUp:111 » ConnectionLoss 
Keeper...
 
I think all of those are not related to the javadoc change. :)


> IterateTest.testSimpleIteration fails on Travis
> ---
>
> Key: FLINK-2771
> URL: https://issues.apache.org/jira/browse/FLINK-2771
> Project: Flink
>  Issue Type: Bug
>Affects Versions: 0.10.0
>Reporter: Till Rohrmann
>Priority: Critical
>  Labels: test-stability
> Fix For: 1.0.0
>
>
> The {{IterateTest.testSimpleIteration}} failed on Travis with
> {code}
> Failed tests: 
>   IterateTest.testSimpleIteration:384 null
> {code}
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/81986242/log.txt 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)