[ https://issues.apache.org/jira/browse/FLINK-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977598#comment-14977598 ]
GaoLun commented on FLINK-2892: ------------------------------- IMO, if I modify this class with JMH, the result will be much more complex. Because I must rewrite all the test into small benchmark test method. Method number is almost 96! It will be too long to read and understand. I don’t think it’s a good idea to modify this class with JMH. Also there is no rule that all benchmark in flink-benchmark need to be ported to JMH. So I will close the issue. > Apply JMH on MemorySegmentSpeedBenchmark class. > ----------------------------------------------- > > Key: FLINK-2892 > URL: https://issues.apache.org/jira/browse/FLINK-2892 > Project: Flink > Issue Type: Sub-task > Components: Tests > Reporter: GaoLun > Assignee: GaoLun > Priority: Minor > Labels: easyfix > > JMH is a Java harness for building, running, and analysing > nano/micro/milli/macro benchmarks.Use JMH to replace the old micro benchmarks > method in order to get much more accurate results.Modify the > MemorySegmentSpeedBenchmark class and move it to flink-benchmark module. -- This message was sent by Atlassian JIRA (v6.3.4#6332)