[jira] [Commented] (FLINK-29541) [JUnit5 Migration] Module: flink-table-planner

2023-08-28 Thread Leonard Xu (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17759462#comment-17759462
 ] 

Leonard Xu commented on FLINK-29541:


Hi, [~rskraba] I assigned this ticket to [~jiabao.sun] as this ticket hasn't 
been updated for a long time, you can also help to review PR if you have time 
slot.

> [JUnit5 Migration] Module: flink-table-planner
> --
>
> Key: FLINK-29541
> URL: https://issues.apache.org/jira/browse/FLINK-29541
> Project: Flink
>  Issue Type: Technical Debt
>  Components: Table SQL / Planner, Tests
>Reporter: Lijie Wang
>Assignee: Ryan Skraba
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29541) [JUnit5 Migration] Module: flink-table-planner

2023-08-27 Thread Jiabao Sun (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17759379#comment-17759379
 ] 

Jiabao Sun commented on FLINK-29541:


Hey [~jark],

I found that this issue has not been updated for a long time. 
Could you help assign this ticket to me?

> [JUnit5 Migration] Module: flink-table-planner
> --
>
> Key: FLINK-29541
> URL: https://issues.apache.org/jira/browse/FLINK-29541
> Project: Flink
>  Issue Type: Technical Debt
>  Components: Table SQL / Planner, Tests
>Reporter: Lijie Wang
>Assignee: Ryan Skraba
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29541) [JUnit5 Migration] Module: flink-table-planner

2023-04-08 Thread Jark Wu (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709884#comment-17709884
 ] 

Jark Wu commented on FLINK-29541:
-

Considering migrating for flink-table-planner is a huge effort, I converted 
this issue from sub-task into an umbrella issue. [~rskraba] feel free to create 
other sub-issues under it when you finish the {{BatchAbstractTestBase}}. 

> [JUnit5 Migration] Module: flink-table-planner
> --
>
> Key: FLINK-29541
> URL: https://issues.apache.org/jira/browse/FLINK-29541
> Project: Flink
>  Issue Type: Technical Debt
>  Components: Table SQL / Planner, Tests
>Reporter: Lijie Wang
>Assignee: Ryan Skraba
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29541) [JUnit5 Migration] Module: flink-table-planner

2023-03-30 Thread Ryan Skraba (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706913#comment-17706913
 ] 

Ryan Skraba commented on FLINK-29541:
-

I created the linked Jira to address only the {{BatchAbstractTestBase}} (but 
I'm willing to take on another tree of tests once the PR for that one is done!)

> [JUnit5 Migration] Module: flink-table-planner
> --
>
> Key: FLINK-29541
> URL: https://issues.apache.org/jira/browse/FLINK-29541
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / Planner, Tests
>Reporter: Lijie Wang
>Assignee: Ryan Skraba
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29541) [JUnit5 Migration] Module: flink-table-planner

2023-03-14 Thread Jark Wu (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700452#comment-17700452
 ] 

Jark Wu commented on FLINK-29541:
-

Hi [~rskraba], I would suggest keeping this issue as is and creating issues for 
individual tests migration. This helps us to track the overall migration 
progress. We can't create sub-tasks under a sub-task, so may need to use issue 
links to linking the sub issues. 

> [JUnit5 Migration] Module: flink-table-planner
> --
>
> Key: FLINK-29541
> URL: https://issues.apache.org/jira/browse/FLINK-29541
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / Planner, Tests
>Reporter: Lijie Wang
>Assignee: Ryan Skraba
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29541) [JUnit5 Migration] Module: flink-table-planner

2023-03-14 Thread Ryan Skraba (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700279#comment-17700279
 ] 

Ryan Skraba commented on FLINK-29541:
-

Hey thanks for checking in!  I had quite a bit of progress on this, but let it 
slide during the last few months.  I'd love to get back into it.

Would it be possible to retitle this Jira "[JUnit5 Migration] Module: 
flink-table-planner (BatchAbstractTestBase hierarchy)" ?  At the minimum this 
would let other devs know that the other hierarchies of test cases starting 
from flink-table-planner bases are available for migration!

> [JUnit5 Migration] Module: flink-table-planner
> --
>
> Key: FLINK-29541
> URL: https://issues.apache.org/jira/browse/FLINK-29541
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / Planner, Tests
>Reporter: Lijie Wang
>Assignee: Ryan Skraba
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29541) [JUnit5 Migration] Module: flink-table-planner

2023-03-11 Thread Jark Wu (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699311#comment-17699311
 ] 

Jark Wu commented on FLINK-29541:
-

Hi [~rskraba], what's the progress now? I agree with you this might be a huge 
work and we can separate the issue into sub-tasks. 

> [JUnit5 Migration] Module: flink-table-planner
> --
>
> Key: FLINK-29541
> URL: https://issues.apache.org/jira/browse/FLINK-29541
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / Planner, Tests
>Reporter: Lijie Wang
>Assignee: Ryan Skraba
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29541) [JUnit5 Migration] Module: flink-table-planner

2022-10-27 Thread Lijie Wang (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625437#comment-17625437
 ] 

Lijie Wang commented on FLINK-29541:


Sure, just assigned to you :). It would be better to create a separate issue 
for these abstract base classes to track them, just like what you did in 
FLINK-28542

> [JUnit5 Migration] Module: flink-table-planner
> --
>
> Key: FLINK-29541
> URL: https://issues.apache.org/jira/browse/FLINK-29541
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / Planner, Tests
>Reporter: Lijie Wang
>Assignee: Ryan Skraba
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29541) [JUnit5 Migration] Module: flink-table-planner

2022-10-27 Thread Ryan Skraba (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625098#comment-17625098
 ] 

Ryan Skraba commented on FLINK-29541:
-

I can start attacking these tests!  I think my proposed strategy of doing a 
"hierarchy" of related tests that share a common abstract base class but have 
implementations across modules is probably a good way to attack this, but I'll 
start with a single PR to demonstrate.

Can this JIRA be assigned to me?

> [JUnit5 Migration] Module: flink-table-planner
> --
>
> Key: FLINK-29541
> URL: https://issues.apache.org/jira/browse/FLINK-29541
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / Planner, Tests
>Reporter: Lijie Wang
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29541) [JUnit5 Migration] Module: flink-table-planner

2022-10-26 Thread Lijie Wang (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624816#comment-17624816
 ] 

Lijie Wang commented on FLINK-29541:


No, I'm not working on this, because I'm not familiar with flink-table-planner. 
I create this issue since the migration of this module does block another work 
I'm doing (FLINK-27940).  Feel free to take it if you want :) [~rskraba] 

> [JUnit5 Migration] Module: flink-table-planner
> --
>
> Key: FLINK-29541
> URL: https://issues.apache.org/jira/browse/FLINK-29541
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / Planner, Tests
>Reporter: Lijie Wang
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (FLINK-29541) [JUnit5 Migration] Module: flink-table-planner

2022-10-26 Thread Ryan Skraba (Jira) 


[ 
https://issues.apache.org/jira/browse/FLINK-29541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624464#comment-17624464
 ] 

Ryan Skraba commented on FLINK-29541:
-

Hello!  There's a LOT of unit tests in flink-table-planner – are you currently 
working on this?

I was thinking about breaking this up by taking one of the lower level test 
cases like (like {{BatchAbstractTestBase}} and doing the entire hierarchy of 
tests across all modules that depend on it one way or another.  Just doing that 
PR would touch many dozens of files (most of them inside flink-table-planner, 
but also across flink-format), but they would all be related.  What do you 
think?

I'd be willing to help out in this module if I can!

> [JUnit5 Migration] Module: flink-table-planner
> --
>
> Key: FLINK-29541
> URL: https://issues.apache.org/jira/browse/FLINK-29541
> Project: Flink
>  Issue Type: Sub-task
>  Components: Table SQL / Planner, Tests
>Reporter: Lijie Wang
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)