[jira] [Commented] (FLINK-2959) Remove number of execution retries configuration from Environment
[ https://issues.apache.org/jira/browse/FLINK-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993424#comment-14993424 ] Maximilian Michels commented on FLINK-2959: --- The setters on the ExecutionEnvironment just set the corresponding parameter in the ExecutionConfig. I second [~StephanEwen]. In addition to very frequently used settings like the parallelism, batch or streaming specific settings should can go into the Environments. > Remove number of execution retries configuration from Environment > - > > Key: FLINK-2959 > URL: https://issues.apache.org/jira/browse/FLINK-2959 > Project: Flink > Issue Type: Improvement > Components: Java API, Scala API >Affects Versions: 0.10 >Reporter: Ufuk Celebi >Priority: Minor > Labels: api-breaking > Fix For: 0.10 > > > The number of execution retries is configured via the Environment, but all > other execution configuration happens exclusively via ExecutionConfig. > I think it will be more consistent to have it in ExecutionConfig only. > This will be an API breaking change. > What's your opinion? Should we move it to the ExecutionConfig? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2959) Remove number of execution retries configuration from Environment
[ https://issues.apache.org/jira/browse/FLINK-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989249#comment-14989249 ] Maximilian Michels commented on FLINK-2959: --- Good point [~aljoscha]. I guess we have the most essential configuration accessible directly on the Environment. For the fine tuning, the user has to get the ExecutionConfig. Leaving it as it is, seems to be fine then :) > Remove number of execution retries configuration from Environment > - > > Key: FLINK-2959 > URL: https://issues.apache.org/jira/browse/FLINK-2959 > Project: Flink > Issue Type: Improvement > Components: Java API, Scala API >Affects Versions: 0.10 >Reporter: Ufuk Celebi >Priority: Minor > Labels: api-breaking > Fix For: 0.10 > > > The number of execution retries is configured via the Environment, but all > other execution configuration happens exclusively via ExecutionConfig. > I think it will be more consistent to have it in ExecutionConfig only. > This will be an API breaking change. > What's your opinion? Should we move it to the ExecutionConfig? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2959) Remove number of execution retries configuration from Environment
[ https://issues.apache.org/jira/browse/FLINK-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989257#comment-14989257 ] Fabian Hueske commented on FLINK-2959: -- alright. +1 to what [~mxm] said. > Remove number of execution retries configuration from Environment > - > > Key: FLINK-2959 > URL: https://issues.apache.org/jira/browse/FLINK-2959 > Project: Flink > Issue Type: Improvement > Components: Java API, Scala API >Affects Versions: 0.10 >Reporter: Ufuk Celebi >Priority: Minor > Labels: api-breaking > Fix For: 0.10 > > > The number of execution retries is configured via the Environment, but all > other execution configuration happens exclusively via ExecutionConfig. > I think it will be more consistent to have it in ExecutionConfig only. > This will be an API breaking change. > What's your opinion? Should we move it to the ExecutionConfig? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2959) Remove number of execution retries configuration from Environment
[
https://issues.apache.org/jira/browse/FLINK-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989289#comment-14989289
]
Till Rohrmann commented on FLINK-2959:
--
I agree that we have to come up with a consistent way of putting methods in the
{{ExecutionConfig}} or in the {{ExecutionEnvironment}}. But for {{0.10}} it
should be fine.
> Remove number of execution retries configuration from Environment
> -
>
> Key: FLINK-2959
> URL: https://issues.apache.org/jira/browse/FLINK-2959
> Project: Flink
> Issue Type: Improvement
> Components: Java API, Scala API
>Affects Versions: 0.10
>Reporter: Ufuk Celebi
>Priority: Minor
> Labels: api-breaking
> Fix For: 0.10
>
>
> The number of execution retries is configured via the Environment, but all
> other execution configuration happens exclusively via ExecutionConfig.
> I think it will be more consistent to have it in ExecutionConfig only.
> This will be an API breaking change.
> What's your opinion? Should we move it to the ExecutionConfig?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-2959) Remove number of execution retries configuration from Environment
[ https://issues.apache.org/jira/browse/FLINK-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989223#comment-14989223 ] Maximilian Michels commented on FLINK-2959: --- We are about to create another RC. IMHO we should also configure the number of execution retries in one place. This should be the ExecutionConfig. > Remove number of execution retries configuration from Environment > - > > Key: FLINK-2959 > URL: https://issues.apache.org/jira/browse/FLINK-2959 > Project: Flink > Issue Type: Improvement > Components: Java API, Scala API >Affects Versions: 0.10 >Reporter: Ufuk Celebi >Priority: Minor > Labels: api-breaking > Fix For: 0.10 > > > The number of execution retries is configured via the Environment, but all > other execution configuration happens exclusively via ExecutionConfig. > I think it will be more consistent to have it in ExecutionConfig only. > This will be an API breaking change. > What's your opinion? Should we move it to the ExecutionConfig? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2959) Remove number of execution retries configuration from Environment
[ https://issues.apache.org/jira/browse/FLINK-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989225#comment-14989225 ] Robert Metzger commented on FLINK-2959: --- Can we mark the old method on the Environment as Depricated > Remove number of execution retries configuration from Environment > - > > Key: FLINK-2959 > URL: https://issues.apache.org/jira/browse/FLINK-2959 > Project: Flink > Issue Type: Improvement > Components: Java API, Scala API >Affects Versions: 0.10 >Reporter: Ufuk Celebi >Priority: Minor > Labels: api-breaking > Fix For: 0.10 > > > The number of execution retries is configured via the Environment, but all > other execution configuration happens exclusively via ExecutionConfig. > I think it will be more consistent to have it in ExecutionConfig only. > This will be an API breaking change. > What's your opinion? Should we move it to the ExecutionConfig? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2959) Remove number of execution retries configuration from Environment
[ https://issues.apache.org/jira/browse/FLINK-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989226#comment-14989226 ] Fabian Hueske commented on FLINK-2959: -- I agree with [~mxm] > Remove number of execution retries configuration from Environment > - > > Key: FLINK-2959 > URL: https://issues.apache.org/jira/browse/FLINK-2959 > Project: Flink > Issue Type: Improvement > Components: Java API, Scala API >Affects Versions: 0.10 >Reporter: Ufuk Celebi >Priority: Minor > Labels: api-breaking > Fix For: 0.10 > > > The number of execution retries is configured via the Environment, but all > other execution configuration happens exclusively via ExecutionConfig. > I think it will be more consistent to have it in ExecutionConfig only. > This will be an API breaking change. > What's your opinion? Should we move it to the ExecutionConfig? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2959) Remove number of execution retries configuration from Environment
[
https://issues.apache.org/jira/browse/FLINK-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989234#comment-14989234
]
Aljoscha Krettek commented on FLINK-2959:
-
But this is not the only method on {{StreamExecutionEnvironment}} that would
fall into this category. There are also {{setParallelism}},
{{setBufferTimeout}}, {{disableOperatorChaining}}, {{enableCheckpointing}},
{{setStateBackend}} and so on...
> Remove number of execution retries configuration from Environment
> -
>
> Key: FLINK-2959
> URL: https://issues.apache.org/jira/browse/FLINK-2959
> Project: Flink
> Issue Type: Improvement
> Components: Java API, Scala API
>Affects Versions: 0.10
>Reporter: Ufuk Celebi
>Priority: Minor
> Labels: api-breaking
> Fix For: 0.10
>
>
> The number of execution retries is configured via the Environment, but all
> other execution configuration happens exclusively via ExecutionConfig.
> I think it will be more consistent to have it in ExecutionConfig only.
> This will be an API breaking change.
> What's your opinion? Should we move it to the ExecutionConfig?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-2959) Remove number of execution retries configuration from Environment
[ https://issues.apache.org/jira/browse/FLINK-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989239#comment-14989239 ] Maximilian Michels commented on FLINK-2959: --- Ok let's deprecate the method and remove it in 1.0. > Remove number of execution retries configuration from Environment > - > > Key: FLINK-2959 > URL: https://issues.apache.org/jira/browse/FLINK-2959 > Project: Flink > Issue Type: Improvement > Components: Java API, Scala API >Affects Versions: 0.10 >Reporter: Ufuk Celebi >Priority: Minor > Labels: api-breaking > Fix For: 0.10 > > > The number of execution retries is configured via the Environment, but all > other execution configuration happens exclusively via ExecutionConfig. > I think it will be more consistent to have it in ExecutionConfig only. > This will be an API breaking change. > What's your opinion? Should we move it to the ExecutionConfig? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2959) Remove number of execution retries configuration from Environment
[ https://issues.apache.org/jira/browse/FLINK-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989247#comment-14989247 ] Ufuk Celebi commented on FLINK-2959: [~aljoscha] has a point. I think it's best to leave it as it is. > Remove number of execution retries configuration from Environment > - > > Key: FLINK-2959 > URL: https://issues.apache.org/jira/browse/FLINK-2959 > Project: Flink > Issue Type: Improvement > Components: Java API, Scala API >Affects Versions: 0.10 >Reporter: Ufuk Celebi >Priority: Minor > Labels: api-breaking > Fix For: 0.10 > > > The number of execution retries is configured via the Environment, but all > other execution configuration happens exclusively via ExecutionConfig. > I think it will be more consistent to have it in ExecutionConfig only. > This will be an API breaking change. > What's your opinion? Should we move it to the ExecutionConfig? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2959) Remove number of execution retries configuration from Environment
[ https://issues.apache.org/jira/browse/FLINK-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987439#comment-14987439 ] Maximilian Michels commented on FLINK-2959: --- +1 Let's configure this only through the ExecutionConfig. A bit unfortunate that the old method on ExecutionEnvironment will be in the 0.10 release. > Remove number of execution retries configuration from Environment > - > > Key: FLINK-2959 > URL: https://issues.apache.org/jira/browse/FLINK-2959 > Project: Flink > Issue Type: Improvement > Components: Java API, Scala API >Affects Versions: 0.10 >Reporter: Ufuk Celebi >Priority: Minor > Labels: api-breaking > > The number of execution retries is configured via the Environment, but all > other execution configuration happens exclusively via ExecutionConfig. > I think it will be more consistent to have it in ExecutionConfig only. > This will be an API breaking change. > What's your opinion? Should we move it to the ExecutionConfig? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
