[jira] [Commented] (FLINK-31848) And Operator has side effect when operands have udf

2023-04-23 Thread zju_zsx (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715554#comment-17715554 ] zju_zsx commented on FLINK-31848: - [~csq] tks, you are right, this breaks three value logic.  Then the

[jira] [Commented] (FLINK-31848) And Operator has side effect when operands have udf

2023-04-23 Thread Shuiqiang Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715419#comment-17715419 ] Shuiqiang Chen commented on FLINK-31848: Here is a test case: {code:scala} def

[jira] [Commented] (FLINK-31848) And Operator has side effect when operands have udf

2023-04-23 Thread Shuiqiang Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715415#comment-17715415 ] Shuiqiang Chen commented on FLINK-31848: Hi [~zju_zsx] take a table MyTable(a INT, b INT) for

[jira] [Commented] (FLINK-31848) And Operator has side effect when operands have udf

2023-04-23 Thread Shuiqiang Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715392#comment-17715392 ] Shuiqiang Chen commented on FLINK-31848: Hi [~zju_zsx], take a table MyTable(a INT, b INT) for

[jira] [Commented] (FLINK-31848) And Operator has side effect when operands have udf

2023-04-22 Thread zju_zsx (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715352#comment-17715352 ] zju_zsx commented on FLINK-31848: - [~csq]  Although using ${left.nullTerm} may make the code more

[jira] [Commented] (FLINK-31848) And Operator has side effect when operands have udf

2023-04-21 Thread Shuiqiang Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715115#comment-17715115 ] Shuiqiang Chen commented on FLINK-31848: [~martijnvisser][~zju_zsx][~jark] Thanks for your

[jira] [Commented] (FLINK-31848) And Operator has side effect when operands have udf

2023-04-21 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714995#comment-17714995 ] Jark Wu commented on FLINK-31848: - [~csq] do you have a simple case to reproduce the wrong result (and

[jira] [Commented] (FLINK-31848) And Operator has side effect when operands have udf

2023-04-19 Thread zju_zsx (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714067#comment-17714067 ] zju_zsx commented on FLINK-31848: - [~csq] null check is checked in left.code,  left.resultTerm also set

[jira] [Commented] (FLINK-31848) And Operator has side effect when operands have udf

2023-04-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714022#comment-17714022 ] Martijn Visser commented on FLINK-31848: [~csq] Thanks for the ticket, have you also verified

[jira] [Commented] (FLINK-31848) And Operator has side effect when operands have udf

2023-04-19 Thread Shuiqiang Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713985#comment-17713985 ] Shuiqiang Chen commented on FLINK-31848: And without null check, it can be simplified to be if

[jira] [Commented] (FLINK-31848) And Operator has side effect when operands have udf

2023-04-19 Thread Shuiqiang Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713984#comment-17713984 ] Shuiqiang Chen commented on FLINK-31848: Hi, The code block is under the null check required