[jira] [Commented] (FLINK-3395) Polishing the web UI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362566#comment-15362566
 ] 

ASF GitHub Bot commented on FLINK-3395:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/2092


> Polishing the web UI
> 
>
> Key: FLINK-3395
> URL: https://issues.apache.org/jira/browse/FLINK-3395
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Reporter: Greg Hogan
>Assignee: Greg Hogan
>
> On the job properties page one must select an operator from the plan. 
> Elsewhere in the UI a list of operators is displayed and clicking the table 
> or the plan will reveal the requested information.
> A list of operators could likewise be added to the timeline page.
> The job exceptions page should display a "No exceptions" notification as done 
> elsewhere for when there is nothing to display.
> The job plan is not redrawn when the browser window is resized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3395) Polishing the web UI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339488#comment-15339488
 ] 

ASF GitHub Bot commented on FLINK-3395:
---

Github user rmetzger commented on the issue:

https://github.com/apache/flink/pull/2092
  
I quickly looked through the changed files. I think the changes are okay.
However, it seems that the the pull request doesn't build (and merge with 
master). I've started addressing those issues and will open a new PR once I've 
addressed all issues.


> Polishing the web UI
> 
>
> Key: FLINK-3395
> URL: https://issues.apache.org/jira/browse/FLINK-3395
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Reporter: Greg Hogan
>Assignee: Greg Hogan
>
> On the job properties page one must select an operator from the plan. 
> Elsewhere in the UI a list of operators is displayed and clicking the table 
> or the plan will reveal the requested information.
> A list of operators could likewise be added to the timeline page.
> The job exceptions page should display a "No exceptions" notification as done 
> elsewhere for when there is nothing to display.
> The job plan is not redrawn when the browser window is resized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3395) Polishing the web UI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339478#comment-15339478
 ] 

ASF GitHub Bot commented on FLINK-3395:
---

Github user rmetzger commented on a diff in the pull request:

https://github.com/apache/flink/pull/2092#discussion_r67688097
  
--- Diff: flink-scala-shell/pom.xml ---
@@ -70,27 +71,19 @@ under the License.
scala-library
${scala.version}

+

org.scala-lang
scala-reflect
${scala.version}

-   
-   org.apache.flink
-   flink-streaming-java_2.10
-   1.1-SNAPSHOT
-   
-   
-   org.apache.flink
-   flink-streaming-scala_2.10
-   1.1-SNAPSHOT
--- End diff --

Oh wow. This is really bad.


> Polishing the web UI
> 
>
> Key: FLINK-3395
> URL: https://issues.apache.org/jira/browse/FLINK-3395
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Reporter: Greg Hogan
>Assignee: Greg Hogan
>
> On the job properties page one must select an operator from the plan. 
> Elsewhere in the UI a list of operators is displayed and clicking the table 
> or the plan will reveal the requested information.
> A list of operators could likewise be added to the timeline page.
> The job exceptions page should display a "No exceptions" notification as done 
> elsewhere for when there is nothing to display.
> The job plan is not redrawn when the browser window is resized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3395) Polishing the web UI

[Robert Metzger (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333700#comment-15333700
 ] 

Robert Metzger commented on FLINK-3395:
---

The PR opened by Stephan has the wrong issue id. So its unrelated.

> Polishing the web UI
> 
>
> Key: FLINK-3395
> URL: https://issues.apache.org/jira/browse/FLINK-3395
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Reporter: Greg Hogan
>Assignee: Greg Hogan
>
> On the job properties page one must select an operator from the plan. 
> Elsewhere in the UI a list of operators is displayed and clicking the table 
> or the plan will reveal the requested information.
> A list of operators could likewise be added to the timeline page.
> The job exceptions page should display a "No exceptions" notification as done 
> elsewhere for when there is nothing to display.
> The job plan is not redrawn when the browser window is resized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3395) Polishing the web UI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15325570#comment-15325570
 ] 

ASF GitHub Bot commented on FLINK-3395:
---

GitHub user StephanEwen opened a pull request:

https://github.com/apache/flink/pull/2092

[FLINK-3395] [build] Make test utils properly available and fix Maven 
dependencies

This pull requests fixes maven project scopes:

  - No **main** scope must ever depend on a **test** scope
  - Common test utils (`ForkableMiniCluster`, `TestEnvironment`, ...) 
should not be in test-jars, but in reusable and user-exposed test utils 
projects in **main** scope.
  - The number of test-jar dependencies should be minimal
  
## New Structure

  - Created a **flink-test-utils-junit** module that contains all JUnit 
related utils like
- `TestLogger`
- `RetryRules`
This reduces the `flink-core` `test-jar` dependency.

  - The **flink-test-utils** project contains all necessary utils for most 
tests
- `ForkableMiniCluster`
- `TestEnvironment` & `TestStreamEnvironment`
- `MultipleProgramsTestBase` & `StreamingMultipleProgramsTestBase`
- ...

  - The `flink-test-utils-junit` and `flink-test-utils` are in the parent 
project `flink-test-utils-parent`.
  

Tons of tests have minor adjustments to use different ways of accessing a 
specific test utility function, to keep the dependencies smaller.

## Other Fixes

  - Removed unnecessary dependencies in the test scope
  - The Table API no longer pulls the example projects into the main scope
  - The Kafka consumer no longer pulls zkclient into the main scope


The size of this pull request is very large, but most edits are 
straightforward minor changes due to moving certain util classes and 
consolidating duplicate util classes.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/StephanEwen/incubator-flink test_utils

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/2092.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2092


commit 0c10ccb1aab18d0709861297f6aa2b8c58512d51
Author: Stephan Ewen 
Date:   2016-05-30T18:56:05Z

[FLINK-3995] [build] Properly structure test scopes and dependencies

Makes the JUnit test utils (TestLogger, retry rules, ...) properly 
available to
other projects without the 'flink-core' test-jar, via the 
'flink-test-utils-junit' project.

Makes the ForkableMiniCluster, TestEnvironment,  and other test utilities 
available in the 'main'
scope of the 'flink-test-utils' project.

Creates a 'flink-test-utils-parent' project that holds the 
'flink-test-utils-junit' and
'flink-test-utils' project.

Also moves some tests between projects and inlines some very simple utility 
functions in
order to simplify some test jar dependencies.

commit 151324df1d314ce46737bf9994ca7a960c29e6ed
Author: Stephan Ewen 
Date:   2016-06-11T00:14:07Z

[FLINK-3995] [build] flink-test-utils also contains the streaming test 
utilities.

Test utilities include the StreamingMultipleProgramsTestBase and 
StreamingTestEnvironment.

This moves the ITCases for streaming into 'flink-tests' to achieve that.




> Polishing the web UI
> 
>
> Key: FLINK-3395
> URL: https://issues.apache.org/jira/browse/FLINK-3395
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Reporter: Greg Hogan
>Assignee: Greg Hogan
>
> On the job properties page one must select an operator from the plan. 
> Elsewhere in the UI a list of operators is displayed and clicking the table 
> or the plan will reveal the requested information.
> A list of operators could likewise be added to the timeline page.
> The job exceptions page should display a "No exceptions" notification as done 
> elsewhere for when there is nothing to display.
> The job plan is not redrawn when the browser window is resized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3395) Polishing the web UI

[Greg Hogan (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15150734#comment-15150734
 ] 

Greg Hogan commented on FLINK-3395:
---

[~fhueske] is it straightforward for reviewers to recompile the web frontend 
when merging a pull request? And there is already an updated transitive Bower 
dependency (qtip2 -> imagesloaded -> ev-emitter).

> Polishing the web UI
> 
>
> Key: FLINK-3395
> URL: https://issues.apache.org/jira/browse/FLINK-3395
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Reporter: Greg Hogan
>Assignee: Greg Hogan
> Fix For: 1.0.0
>
>
> On the job properties page one must select an operator from the plan. 
> Elsewhere in the UI a list of operators is displayed and clicking the table 
> or the plan will reveal the requested information.
> A list of operators could likewise be added to the timeline page.
> The job exceptions page should display a "No exceptions" notification as done 
> elsewhere for when there is nothing to display.
> In the job plan page, selecting accumulators, checkpoints, or back pressure 
> deselects "Plan" from the upper tab, removing the underline and emphasis.
> The job plan is not redrawn when the browser window is resized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3395) Polishing the web UI

[Fabian Hueske (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15147251#comment-15147251
 ] 

Fabian Hueske commented on FLINK-3395:
--

Hi Greg, sounds like this could be an umbrella task for several smaller issues..
Do you want to create subissues that can be individually fixed?

> Polishing the web UI
> 
>
> Key: FLINK-3395
> URL: https://issues.apache.org/jira/browse/FLINK-3395
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Reporter: Greg Hogan
> Fix For: 1.0.0
>
>
> On the job properties page one must select an operator from the plan. 
> Elsewhere in the UI a list of operators is displayed and clicking the table 
> or the plan will reveal the requested information.
> A list of operators could likewise be added to the timeline page. Also, when 
> selecting an operator the subtask timelines zoom out to show "000" for 
> milliseconds. It would be nice to back off to seconds, minutes, etc.
> The job exceptions page should display a "No exceptions" notification as done 
> elsewhere for when there is nothing to display.
> In the job plan page, selecting accumulators, checkpoints, or back pressure 
> deselects "Plan" from the upper tab, removing the underline and emphasis.
> The job plan is not redrawn when the browser window is resized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)