[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270270#comment-15270270
]
Ufuk Celebi commented on FLINK-3669:
Yes, sir.
> WindowOperator registers a lot of timers at
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268419#comment-15268419
]
Aljoscha Krettek commented on FLINK-3669:
-
Ok, I think it's good to merge then. :-)
>
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266976#comment-15266976
]
Konstantin Knauf commented on FLINK-3669:
-
The problem in the gist, yes. As I said, I could not
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266509#comment-15266509
]
Aljoscha Krettek commented on FLINK-3669:
-
Is the problem gone with changing this? If yes, I'd
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15264132#comment-15264132
]
Konstantin Knauf commented on FLINK-3669:
-
Hmpf, of course...
> WindowOperator registers a lot of
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15263974#comment-15263974
]
Aljoscha Krettek commented on FLINK-3669:
-
Ah, in the custom trigger the {{oldTimestamp}} field is
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262485#comment-15262485
]
Konstantin Knauf commented on FLINK-3669:
-
[[~aljoscha] Thanks, will do the next time.
I tried
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262013#comment-15262013
]
Aljoscha Krettek commented on FLINK-3669:
-
Thanks :-) Quick remark: if you include the Jira issue
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262000#comment-15262000
]
Konstantin Knauf commented on FLINK-3669:
-
[~aljoscha] I opened a PR
> WindowOperator registers a
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260431#comment-15260431
]
Konstantin Knauf commented on FLINK-3669:
-
I made the changes as suggested, and will open a PR
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260171#comment-15260171
]
Aljoscha Krettek commented on FLINK-3669:
-
I think we have a winner now :-) Could you also test
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260086#comment-15260086
]
Aljoscha Krettek commented on FLINK-3669:
-
Thanks! I'll have a look at your branch. For the
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258912#comment-15258912
]
Konstantin Knauf commented on FLINK-3669:
-
[~aljoscha] Hmpf. You're right. I was actually a little
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253666#comment-15253666
]
Aljoscha Krettek commented on FLINK-3669:
-
Hi,
it's almost done but I think we need both the
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253604#comment-15253604
]
Aljoscha Krettek commented on FLINK-3669:
-
Btw, in the future if you reference me like this
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253601#comment-15253601
]
Aljoscha Krettek commented on FLINK-3669:
-
I'm checking it out.
> WindowOperator registers a lot
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253557#comment-15253557
]
Konstantin Knauf commented on FLINK-3669:
-
Aljoscha, could you have a look at
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15241151#comment-15241151
]
Aljoscha Krettek commented on FLINK-3669:
-
No worries, we all have plenty to do. :-)
>
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15240925#comment-15240925
]
Konstantin Knauf commented on FLINK-3669:
-
Nope, sorry I do not think I will have the time in the
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15236970#comment-15236970
]
Aljoscha Krettek commented on FLINK-3669:
-
Hi,
I finally had a look at your code. It looks good
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234552#comment-15234552
]
Aljoscha Krettek commented on FLINK-3669:
-
Hi,
I'll be looking at your code today.
For the tests,
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232228#comment-15232228
]
Konstantin Knauf commented on FLINK-3669:
-
Is WindowCheckpointingIT the right place to put a test
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230891#comment-15230891
]
Konstantin Knauf commented on FLINK-3669:
-
I have a first draft here:
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15223811#comment-15223811
]
Aljoscha Krettek commented on FLINK-3669:
-
Yes, you are right about that one. I think the way to
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15223402#comment-15223402
]
Konstantin Knauf commented on FLINK-3669:
-
I tried to implement the 1.. The hard part, I think, is
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221682#comment-15221682
]
Aljoscha Krettek commented on FLINK-3669:
-
Sure, no pressure!
> WindowOperator registers a lot of
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221677#comment-15221677
]
Konstantin Knauf commented on FLINK-3669:
-
I would like to work on it, but not today. I will give
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221600#comment-15221600
]
Aljoscha Krettek commented on FLINK-3669:
-
Yes, the 3rd option would require additional
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219865#comment-15219865
]
Konstantin Knauf commented on FLINK-3669:
-
In my opionen the 1st option is the cleanest, but I can
[
https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219845#comment-15219845
]
Aljoscha Krettek commented on FLINK-3669:
-
Yes, you're right that's still a problem. The issue
30 matches
Mail list logo
