[jira] [Commented] (FLINK-3759) Table API should throw exception is null value is encountered in non-null mode.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15243281#comment-15243281
 ] 

ASF GitHub Bot commented on FLINK-3759:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1892


> Table API should throw exception is null value is encountered in non-null 
> mode.
> ---
>
> Key: FLINK-3759
> URL: https://issues.apache.org/jira/browse/FLINK-3759
> Project: Flink
>  Issue Type: Bug
>  Components: Table API
>Affects Versions: 1.1.0
>Reporter: Fabian Hueske
>Priority: Critical
>
> The Table API can be configured to omit null-checks in generated code to 
> speed up processing. Currently, the generated code replaces a null value with 
> a data type specific default value if it is encountered in non-null-check 
> mode. 
> This can silently cause wrong results and should be changed such that an 
> exception is thrown if a null value is encountered in non-null-check mode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3759) Table API should throw exception is null value is encountered in non-null mode.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242744#comment-15242744
 ] 

ASF GitHub Bot commented on FLINK-3759:
---

Github user fhueske commented on the pull request:

https://github.com/apache/flink/pull/1892#issuecomment-210401616
  
Thanks for the fix. 
Will merge this PR.


> Table API should throw exception is null value is encountered in non-null 
> mode.
> ---
>
> Key: FLINK-3759
> URL: https://issues.apache.org/jira/browse/FLINK-3759
> Project: Flink
>  Issue Type: Bug
>  Components: Table API
>Affects Versions: 1.1.0
>Reporter: Fabian Hueske
>Priority: Critical
>
> The Table API can be configured to omit null-checks in generated code to 
> speed up processing. Currently, the generated code replaces a null value with 
> a data type specific default value if it is encountered in non-null-check 
> mode. 
> This can silently cause wrong results and should be changed such that an 
> exception is thrown if a null value is encountered in non-null-check mode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3759) Table API should throw exception is null value is encountered in non-null mode.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242670#comment-15242670
 ] 

ASF GitHub Bot commented on FLINK-3759:
---

GitHub user twalthr opened a pull request:

https://github.com/apache/flink/pull/1892

[FLINK-3759] [table] Table API should throw exception is null value is 
encountered in non-null mode.

As discussed in FLINK-3739 this PR changes the behavior of null literals in 
non null-check mode.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/twalthr/flink FLINK-3759

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1892.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1892


commit cf6c3e79c9d091bd7011f5fb062034e4f35196de
Author: twalthr 
Date:   2016-04-15T09:05:36Z

[FLINK-3759] [table] Table API should throw exception is null value is 
encountered in non-null mode.




> Table API should throw exception is null value is encountered in non-null 
> mode.
> ---
>
> Key: FLINK-3759
> URL: https://issues.apache.org/jira/browse/FLINK-3759
> Project: Flink
>  Issue Type: Bug
>  Components: Table API
>Affects Versions: 1.1.0
>Reporter: Fabian Hueske
>Priority: Critical
>
> The Table API can be configured to omit null-checks in generated code to 
> speed up processing. Currently, the generated code replaces a null value with 
> a data type specific default value if it is encountered in non-null-check 
> mode. 
> This can silently cause wrong results and should be changed such that an 
> exception is thrown if a null value is encountered in non-null-check mode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)