[jira] [Commented] (FLINK-4082) Add Setting for LargeRecordHandler

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342206#comment-15342206
 ] 

ASF GitHub Bot commented on FLINK-4082:
---

Github user aljoscha closed the pull request at:

https://github.com/apache/flink/pull/2113


> Add Setting for LargeRecordHandler
> --
>
> Key: FLINK-4082
> URL: https://issues.apache.org/jira/browse/FLINK-4082
> Project: Flink
>  Issue Type: Improvement
>Reporter: Aljoscha Krettek
>Assignee: Aljoscha Krettek
>
> Now, this is always enabled but there are known problems when users specify a 
> custom {{TypeInformation}}. We should introduce a setting for this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4082) Add Setting for LargeRecordHandler

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341982#comment-15341982
 ] 

ASF GitHub Bot commented on FLINK-4082:
---

Github user uce commented on the issue:

https://github.com/apache/flink/pull/2113
  
Thanks! Looks good to merge. +1


> Add Setting for LargeRecordHandler
> --
>
> Key: FLINK-4082
> URL: https://issues.apache.org/jira/browse/FLINK-4082
> Project: Flink
>  Issue Type: Improvement
>Reporter: Aljoscha Krettek
>Assignee: Aljoscha Krettek
>
> Now, this is always enabled but there are known problems when users specify a 
> custom {{TypeInformation}}. We should introduce a setting for this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4082) Add Setting for LargeRecordHandler

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341952#comment-15341952
 ] 

ASF GitHub Bot commented on FLINK-4082:
---

Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/2113
  
@uce I addressed the comments.


> Add Setting for LargeRecordHandler
> --
>
> Key: FLINK-4082
> URL: https://issues.apache.org/jira/browse/FLINK-4082
> Project: Flink
>  Issue Type: Improvement
>Reporter: Aljoscha Krettek
>Assignee: Aljoscha Krettek
>
> Now, this is always enabled but there are known problems when users specify a 
> custom {{TypeInformation}}. We should introduce a setting for this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4082) Add Setting for LargeRecordHandler

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341808#comment-15341808
 ] 

ASF GitHub Bot commented on FLINK-4082:
---

Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/2113
  
Nope, I forgot that. Thanks for spotting!


> Add Setting for LargeRecordHandler
> --
>
> Key: FLINK-4082
> URL: https://issues.apache.org/jira/browse/FLINK-4082
> Project: Flink
>  Issue Type: Improvement
>Reporter: Aljoscha Krettek
>Assignee: Aljoscha Krettek
>
> Now, this is always enabled but there are known problems when users specify a 
> custom {{TypeInformation}}. We should introduce a setting for this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4082) Add Setting for LargeRecordHandler

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341508#comment-15341508
 ] 

ASF GitHub Bot commented on FLINK-4082:
---

Github user uce commented on the issue:

https://github.com/apache/flink/pull/2113
  
Changes look good, but did you skip the `CombiningUnilateralSortMerger` on 
purpose?

It's hard to tell, because the `handleLargeRecords` argument was existing 
before your changes, but it was not configurable. The 
`CombiningUnilateralSortMerger` always sets `handleLargeRecords` to `true`.


> Add Setting for LargeRecordHandler
> --
>
> Key: FLINK-4082
> URL: https://issues.apache.org/jira/browse/FLINK-4082
> Project: Flink
>  Issue Type: Improvement
>Reporter: Aljoscha Krettek
>Assignee: Aljoscha Krettek
>
> Now, this is always enabled but there are known problems when users specify a 
> custom {{TypeInformation}}. We should introduce a setting for this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-4082) Add Setting for LargeRecordHandler

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333702#comment-15333702
 ] 

ASF GitHub Bot commented on FLINK-4082:
---

GitHub user aljoscha opened a pull request:

https://github.com/apache/flink/pull/2113

[FLINK-4082] Add Setting for enabling/disabling LargeRecordHandler

By default this is set to disabled because there are known issues when
users specify a custom TypeInformation.

R: @tillrohrmann (the `R:` is for review) I think you know how stuff should 
work there
CC: @StephanEwen 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aljoscha/flink large-record-handler/setting

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/2113.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2113


commit 183e5ab32951ae0ee8392efd147936bb4711d966
Author: Aljoscha Krettek 
Date:   2016-06-16T12:39:23Z

[FLINK-4082] Add Setting for enabling/disabling LargeRecordHandler

By default this is set to disabled because there are known issues when
users specify a custom TypeInformation.




> Add Setting for LargeRecordHandler
> --
>
> Key: FLINK-4082
> URL: https://issues.apache.org/jira/browse/FLINK-4082
> Project: Flink
>  Issue Type: Improvement
>Reporter: Aljoscha Krettek
>Assignee: Aljoscha Krettek
>
> Now, this is always enabled but there are known problems when users specify a 
> custom {{TypeInformation}}. We should introduce a setting for this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)