[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409491#comment-15409491 ] Stephan Ewen commented on FLINK-4094: - The warning has been added in

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409487#comment-15409487 ] ASF GitHub Bot commented on FLINK-4094: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409387#comment-15409387 ] ASF GitHub Bot commented on FLINK-4094: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409350#comment-15409350 ] ramkrishna.s.vasudevan commented on FLINK-4094: --- Updated the PR. Pls check. [~StephanEwen]

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409277#comment-15409277 ] ASF GitHub Bot commented on FLINK-4094: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409278#comment-15409278 ] ASF GitHub Bot commented on FLINK-4094: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409276#comment-15409276 ] ASF GitHub Bot commented on FLINK-4094: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408925#comment-15408925 ] ASF GitHub Bot commented on FLINK-4094: --- GitHub user ramkrish86 opened a pull request:

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408274#comment-15408274 ] ramkrishna.s.vasudevan commented on FLINK-4094: --- I created the log related msg and the doc.

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405836#comment-15405836 ] Stephan Ewen commented on FLINK-4094: - If a task requests more memory than the system is configured

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404384#comment-15404384 ] ramkrishna.s.vasudevan commented on FLINK-4094: --- I can do this Log update and document

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404378#comment-15404378 ] ramkrishna.s.vasudevan commented on FLINK-4094: --- bq. We cannot really manually release the

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404270#comment-15404270 ] Stephan Ewen commented on FLINK-4094: - True, it is not documented the {{preallocate == false}} returns

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404120#comment-15404120 ] Maximilian Michels commented on FLINK-4094: --- Yes, it was undocumented. Initially, I thought

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404095#comment-15404095 ] Till Rohrmann commented on FLINK-4094: -- Is {{preallocate == false}} really supposed to return the

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403961#comment-15403961 ] Maximilian Michels commented on FLINK-4094: --- Thanks [~StephanEwen] for clyariying that we can't

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403843#comment-15403843 ] ramkrishna.s.vasudevan commented on FLINK-4094: --- Ok. bq.If we use pooling, I think we should

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403775#comment-15403775 ] Stephan Ewen commented on FLINK-4094: - If we use pooling, I think we should just follow the exact same

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403533#comment-15403533 ] ramkrishna.s.vasudevan commented on FLINK-4094: --- bq.So, another option to fix this would be

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402572#comment-15402572 ] Stephan Ewen commented on FLINK-4094: - If we pool the off-heap byte buffers, we effectively make a

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402231#comment-15402231 ] Maximilian Michels commented on FLINK-4094: --- Thanks for elaborating on your thoughts

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402004#comment-15402004 ] Till Rohrmann commented on FLINK-4094: -- I think that having in both cases (preallocate and no

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399085#comment-15399085 ] ramkrishna.s.vasudevan commented on FLINK-4094: --- [~mxm] Thanks for the comment. My comment

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399038#comment-15399038 ] Maximilian Michels commented on FLINK-4094: --- I don't think just disallowing preallocation:false

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397634#comment-15397634 ] ramkrishna.s.vasudevan commented on FLINK-4094: --- Can I work on this? I saw the code - if

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340447#comment-15340447 ] Anıl Chalil commented on FLINK-4094: https://github.com/capacman/flinkoffheaptest Above github

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339332#comment-15339332 ] ramkrishna.s.vasudevan commented on FLINK-4094: --- So if the direct memory cannot be reused

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339331#comment-15339331 ] ramkrishna.s.vasudevan commented on FLINK-4094: --- Offheap direct memory cannot be cleared