[jira] [Commented] (FLINK-4675) Remove Parameter from WindowAssigner.getDefaultTrigger()
[
https://issues.apache.org/jira/browse/FLINK-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17328896#comment-17328896
]
Flink Jira Bot commented on FLINK-4675:
---
This major issue is unassigned and itself and all of its Sub-Tasks have not
been updated for 30 days. So, it has been labeled "stale-major". If this ticket
is indeed "major", please either assign yourself or give an update. Afterwards,
please remove the label. In 7 days the issue will be deprioritized.
> Remove Parameter from WindowAssigner.getDefaultTrigger()
>
>
> Key: FLINK-4675
> URL: https://issues.apache.org/jira/browse/FLINK-4675
> Project: Flink
> Issue Type: Sub-task
> Components: API / DataStream
>Reporter: Aljoscha Krettek
>Priority: Major
> Labels: stale-major
> Fix For: 2.0.0
>
>
> For legacy reasons the method has {{StreamExecutionEnvironment}} as a
> parameter. This is not needed anymore.
> [~StephanEwen] do you think we should break this now? {{WindowAssigner}} is
> {{PublicEvolving}} but I wanted to play it conservative for now.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-4675) Remove Parameter from WindowAssigner.getDefaultTrigger()
[
https://issues.apache.org/jira/browse/FLINK-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15527122#comment-15527122
]
Stephan Ewen commented on FLINK-4675:
-
It would be okay to break it now (from what we defined as stability guarantees)
- but tough call still.
Do we have a hunch how many people write their own window assigners? If only
few people write custom window assigners, it is probably fine.
> Remove Parameter from WindowAssigner.getDefaultTrigger()
>
>
> Key: FLINK-4675
> URL: https://issues.apache.org/jira/browse/FLINK-4675
> Project: Flink
> Issue Type: Sub-task
> Components: Windowing Operators
>Reporter: Aljoscha Krettek
> Fix For: 2.0.0
>
>
> For legacy reasons the method has {{StreamExecutionEnvironment}} as a
> parameter. This is not needed anymore.
> [~StephanEwen] do you think we should break this now? {{WindowAssigner}} is
> {{PublicEvolving}} but I wanted to play it conservative for now.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
