[jira] [Commented] (FLINK-4813) Having flink-test-utils as a dependency outside Flink fails the build
[
https://issues.apache.org/jira/browse/FLINK-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15873915#comment-15873915
]
ASF GitHub Bot commented on FLINK-4813:
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3322
> Having flink-test-utils as a dependency outside Flink fails the build
> -
>
> Key: FLINK-4813
> URL: https://issues.apache.org/jira/browse/FLINK-4813
> Project: Flink
> Issue Type: Bug
> Components: Build System
>Affects Versions: 1.2.0
>Reporter: Robert Metzger
>Assignee: Nico Kruber
>
> The {{flink-test-utils}} depend on {{hadoop-minikdc}}, which has a
> dependency, which is only resolvable, if the {{maven-bundle-plugin}} is
> loaded.
> This is the error message
> {code}
> [ERROR] Failed to execute goal on project quickstart-1.2-tests: Could not
> resolve dependencies for project
> com.dataartisans:quickstart-1.2-tests:jar:1.0-SNAPSHOT: Failure to find
> org.apache.directory.jdbm:apacheds-jdbm1:bundle:2.0.0-M2 in
> https://repo.maven.apache.org/maven2 was cached in the local repository,
> resolution will not be reattempted until the update interval of central has
> elapsed or updates are forced -> [Help 1]
> {code}
> {{flink-parent}} loads that plugin, so all "internal" dependencies to the
> test utils can resolve the plugin.
> Right now, users have to use the maven bundle plugin to use our test utils
> externally.
> By making the hadoop minikdc dependency optional, we can probably resolve the
> issues. Then, only users who want to use the security-related tools in the
> test utils need to manually add the hadoop minikdc dependency + the plugin.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-4813) Having flink-test-utils as a dependency outside Flink fails the build
[
https://issues.apache.org/jira/browse/FLINK-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872250#comment-15872250
]
ASF GitHub Bot commented on FLINK-4813:
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3322
The change looks good, thank you!
Merging this...
> Having flink-test-utils as a dependency outside Flink fails the build
> -
>
> Key: FLINK-4813
> URL: https://issues.apache.org/jira/browse/FLINK-4813
> Project: Flink
> Issue Type: Bug
> Components: Build System
>Affects Versions: 1.2.0
>Reporter: Robert Metzger
>Assignee: Nico Kruber
>
> The {{flink-test-utils}} depend on {{hadoop-minikdc}}, which has a
> dependency, which is only resolvable, if the {{maven-bundle-plugin}} is
> loaded.
> This is the error message
> {code}
> [ERROR] Failed to execute goal on project quickstart-1.2-tests: Could not
> resolve dependencies for project
> com.dataartisans:quickstart-1.2-tests:jar:1.0-SNAPSHOT: Failure to find
> org.apache.directory.jdbm:apacheds-jdbm1:bundle:2.0.0-M2 in
> https://repo.maven.apache.org/maven2 was cached in the local repository,
> resolution will not be reattempted until the update interval of central has
> elapsed or updates are forced -> [Help 1]
> {code}
> {{flink-parent}} loads that plugin, so all "internal" dependencies to the
> test utils can resolve the plugin.
> Right now, users have to use the maven bundle plugin to use our test utils
> externally.
> By making the hadoop minikdc dependency optional, we can probably resolve the
> issues. Then, only users who want to use the security-related tools in the
> test utils need to manually add the hadoop minikdc dependency + the plugin.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-4813) Having flink-test-utils as a dependency outside Flink fails the build
[
https://issues.apache.org/jira/browse/FLINK-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870240#comment-15870240
]
ASF GitHub Bot commented on FLINK-4813:
---
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/3322#discussion_r101565321
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/SecureTestEnvironment.java
---
@@ -37,9 +37,39 @@
/**
* Helper {@link SecureTestEnvironment} to handle MiniKDC lifecycle.
* This class can be used to start/stop MiniKDC and create secure
configurations for MiniDFSCluster
- * and MiniYarn
+ * and MiniYarn.
+ *
+ * If you use this class in your project, please make sure to add a
dependency to
+ * hadoop-minikdc, e.g. in your pom.xml:
+ *
+ * ...
+ *
--- End diff --
If you do the example code as follows, you can use the `<` and make the
sample more readable.
```
{@code
org.apache.hadoop
...
}
```
> Having flink-test-utils as a dependency outside Flink fails the build
> -
>
> Key: FLINK-4813
> URL: https://issues.apache.org/jira/browse/FLINK-4813
> Project: Flink
> Issue Type: Bug
> Components: Build System
>Affects Versions: 1.2.0
>Reporter: Robert Metzger
>Assignee: Nico Kruber
>
> The {{flink-test-utils}} depend on {{hadoop-minikdc}}, which has a
> dependency, which is only resolvable, if the {{maven-bundle-plugin}} is
> loaded.
> This is the error message
> {code}
> [ERROR] Failed to execute goal on project quickstart-1.2-tests: Could not
> resolve dependencies for project
> com.dataartisans:quickstart-1.2-tests:jar:1.0-SNAPSHOT: Failure to find
> org.apache.directory.jdbm:apacheds-jdbm1:bundle:2.0.0-M2 in
> https://repo.maven.apache.org/maven2 was cached in the local repository,
> resolution will not be reattempted until the update interval of central has
> elapsed or updates are forced -> [Help 1]
> {code}
> {{flink-parent}} loads that plugin, so all "internal" dependencies to the
> test utils can resolve the plugin.
> Right now, users have to use the maven bundle plugin to use our test utils
> externally.
> By making the hadoop minikdc dependency optional, we can probably resolve the
> issues. Then, only users who want to use the security-related tools in the
> test utils need to manually add the hadoop minikdc dependency + the plugin.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-4813) Having flink-test-utils as a dependency outside Flink fails the build
[
https://issues.apache.org/jira/browse/FLINK-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870238#comment-15870238
]
ASF GitHub Bot commented on FLINK-4813:
---
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/3322
sure, that makes sense
actually, I only had to add it to the flink-test-utils sub-project since
all the others already included the bundler :)
> Having flink-test-utils as a dependency outside Flink fails the build
> -
>
> Key: FLINK-4813
> URL: https://issues.apache.org/jira/browse/FLINK-4813
> Project: Flink
> Issue Type: Bug
> Components: Build System
>Affects Versions: 1.2.0
>Reporter: Robert Metzger
>Assignee: Nico Kruber
>
> The {{flink-test-utils}} depend on {{hadoop-minikdc}}, which has a
> dependency, which is only resolvable, if the {{maven-bundle-plugin}} is
> loaded.
> This is the error message
> {code}
> [ERROR] Failed to execute goal on project quickstart-1.2-tests: Could not
> resolve dependencies for project
> com.dataartisans:quickstart-1.2-tests:jar:1.0-SNAPSHOT: Failure to find
> org.apache.directory.jdbm:apacheds-jdbm1:bundle:2.0.0-M2 in
> https://repo.maven.apache.org/maven2 was cached in the local repository,
> resolution will not be reattempted until the update interval of central has
> elapsed or updates are forced -> [Help 1]
> {code}
> {{flink-parent}} loads that plugin, so all "internal" dependencies to the
> test utils can resolve the plugin.
> Right now, users have to use the maven bundle plugin to use our test utils
> externally.
> By making the hadoop minikdc dependency optional, we can probably resolve the
> issues. Then, only users who want to use the security-related tools in the
> test utils need to manually add the hadoop minikdc dependency + the plugin.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-4813) Having flink-test-utils as a dependency outside Flink fails the build
[
https://issues.apache.org/jira/browse/FLINK-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869907#comment-15869907
]
ASF GitHub Bot commented on FLINK-4813:
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3322
Very good, I had stumbled over that problem as well.
Could you also remove the bundle plugin from the root pom (this should
speed up dependency resolutions in IDEs by a lot) and instead add the above
described dependency to the test projects that use the `SecureTestEnvironment`?
> Having flink-test-utils as a dependency outside Flink fails the build
> -
>
> Key: FLINK-4813
> URL: https://issues.apache.org/jira/browse/FLINK-4813
> Project: Flink
> Issue Type: Bug
> Components: Build System
>Affects Versions: 1.2.0
>Reporter: Robert Metzger
>Assignee: Nico Kruber
>
> The {{flink-test-utils}} depend on {{hadoop-minikdc}}, which has a
> dependency, which is only resolvable, if the {{maven-bundle-plugin}} is
> loaded.
> This is the error message
> {code}
> [ERROR] Failed to execute goal on project quickstart-1.2-tests: Could not
> resolve dependencies for project
> com.dataartisans:quickstart-1.2-tests:jar:1.0-SNAPSHOT: Failure to find
> org.apache.directory.jdbm:apacheds-jdbm1:bundle:2.0.0-M2 in
> https://repo.maven.apache.org/maven2 was cached in the local repository,
> resolution will not be reattempted until the update interval of central has
> elapsed or updates are forced -> [Help 1]
> {code}
> {{flink-parent}} loads that plugin, so all "internal" dependencies to the
> test utils can resolve the plugin.
> Right now, users have to use the maven bundle plugin to use our test utils
> externally.
> By making the hadoop minikdc dependency optional, we can probably resolve the
> issues. Then, only users who want to use the security-related tools in the
> test utils need to manually add the hadoop minikdc dependency + the plugin.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-4813) Having flink-test-utils as a dependency outside Flink fails the build
[
https://issues.apache.org/jira/browse/FLINK-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867901#comment-15867901
]
ASF GitHub Bot commented on FLINK-4813:
---
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/3322
[FLINK-4813][flink-test-utils] make the hadoop-minikdc dependency optional
This removes the need to add the `maven-bundle-plugin`plugin for most
projects using `flink-test-utils`.
Instead, any project using `flink-test-utils` that also requires
`SecureTestEnvironment` must add a dependency to `hadoop-minikdc` itself,
e.g. in
`pom.xml`:
```xml
...
org.apache.hadoop
hadoop-minikdc
${minikdc.version}
compile
...
...
org.apache.felix
maven-bundle-plugin
3.0.1
true
true
...
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-4813
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3322.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3322
commit db3da8bbdcee1b1a72bd7638864b7d052c7f1c83
Author: Nico Kruber
Date: 2017-02-15T13:24:32Z
[FLINK-4813][flink-test-utils] make the hadoop-minikdc dependency optional
With this change, any project using flink-test-utils which also requires
SecureTestEnvironment must add a dependency to hadoop-minikdc itself, e.g.
in
pom.xml:
...
org.apache.hadoop
hadoop-minikdc
${minikdc.version}
compile
...
...
org.apache.felix
maven-bundle-plugin
3.0.1
true
true
...
> Having flink-test-utils as a dependency outside Flink fails the build
> -
>
> Key: FLINK-4813
> URL: https://issues.apache.org/jira/browse/FLINK-4813
> Project: Flink
> Issue Type: Bug
> Components: Build System
>Affects Versions: 1.2.0
>Reporter: Robert Metzger
>Assignee: Nico Kruber
>
> The {{flink-test-utils}} depend on {{hadoop-minikdc}}, which has a
> dependency, which is only resolvable, if the {{maven-bundle-plugin}} is
> loaded.
> This is the error message
> {code}
> [ERROR] Failed to execute goal on project quickstart-1.2-tests: Could not
> resolve dependencies for project
> com.dataartisans:quickstart-1.2-tests:jar:1.0-SNAPSHOT: Failure to find
> org.apache.directory.jdbm:apacheds-jdbm1:bundle:2.0.0-M2 in
> https://repo.maven.apache.org/maven2 was cached in the local repository,
> resolution will not be reattempted until the update interval of central has
> elapsed or updates are forced -> [Help 1]
> {code}
> {{flink-parent}} loads that plugin, so all "internal" dependencies to the
> test utils can resolve the plugin.
> Right now, users have to use the maven bundle plugin to use our test utils
> externally.
> By making the hadoop minikdc dependency optional, we can probably resolve the
> issues. Then, only users who want to use the security-related tools in the
> test utils need to manually add the hadoop minikdc dependency + the plugin.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-4813) Having flink-test-utils as a dependency outside Flink fails the build
[
https://issues.apache.org/jira/browse/FLINK-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866678#comment-15866678
]
Stephan Ewen commented on FLINK-4813:
-
[~NicoK] Do you want to go ahead and patch this?
> Having flink-test-utils as a dependency outside Flink fails the build
> -
>
> Key: FLINK-4813
> URL: https://issues.apache.org/jira/browse/FLINK-4813
> Project: Flink
> Issue Type: Bug
> Components: Build System
>Affects Versions: 1.2.0
>Reporter: Robert Metzger
>
> The {{flink-test-utils}} depend on {{hadoop-minikdc}}, which has a
> dependency, which is only resolvable, if the {{maven-bundle-plugin}} is
> loaded.
> This is the error message
> {code}
> [ERROR] Failed to execute goal on project quickstart-1.2-tests: Could not
> resolve dependencies for project
> com.dataartisans:quickstart-1.2-tests:jar:1.0-SNAPSHOT: Failure to find
> org.apache.directory.jdbm:apacheds-jdbm1:bundle:2.0.0-M2 in
> https://repo.maven.apache.org/maven2 was cached in the local repository,
> resolution will not be reattempted until the update interval of central has
> elapsed or updates are forced -> [Help 1]
> {code}
> {{flink-parent}} loads that plugin, so all "internal" dependencies to the
> test utils can resolve the plugin.
> Right now, users have to use the maven bundle plugin to use our test utils
> externally.
> By making the hadoop minikdc dependency optional, we can probably resolve the
> issues. Then, only users who want to use the security-related tools in the
> test utils need to manually add the hadoop minikdc dependency + the plugin.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-4813) Having flink-test-utils as a dependency outside Flink fails the build
[
https://issues.apache.org/jira/browse/FLINK-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866135#comment-15866135
]
Nico Kruber commented on FLINK-4813:
for documentation: until the minikdc dependency is made optional, users are
required to add the following to their build plugins:
{code:xml}
org.apache.felix
maven-bundle-plugin
3.0.1
true
true
{code}
> Having flink-test-utils as a dependency outside Flink fails the build
> -
>
> Key: FLINK-4813
> URL: https://issues.apache.org/jira/browse/FLINK-4813
> Project: Flink
> Issue Type: Bug
> Components: Build System
>Affects Versions: 1.2.0
>Reporter: Robert Metzger
>
> The {{flink-test-utils}} depend on {{hadoop-minikdc}}, which has a
> dependency, which is only resolvable, if the {{maven-bundle-plugin}} is
> loaded.
> This is the error message
> {code}
> [ERROR] Failed to execute goal on project quickstart-1.2-tests: Could not
> resolve dependencies for project
> com.dataartisans:quickstart-1.2-tests:jar:1.0-SNAPSHOT: Failure to find
> org.apache.directory.jdbm:apacheds-jdbm1:bundle:2.0.0-M2 in
> https://repo.maven.apache.org/maven2 was cached in the local repository,
> resolution will not be reattempted until the update interval of central has
> elapsed or updates are forced -> [Help 1]
> {code}
> {{flink-parent}} loads that plugin, so all "internal" dependencies to the
> test utils can resolve the plugin.
> Right now, users have to use the maven bundle plugin to use our test utils
> externally.
> By making the hadoop minikdc dependency optional, we can probably resolve the
> issues. Then, only users who want to use the security-related tools in the
> test utils need to manually add the hadoop minikdc dependency + the plugin.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-4813) Having flink-test-utils as a dependency outside Flink fails the build
[
https://issues.apache.org/jira/browse/FLINK-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568803#comment-15568803
]
Stephan Ewen commented on FLINK-4813:
-
+1
> Having flink-test-utils as a dependency outside Flink fails the build
> -
>
> Key: FLINK-4813
> URL: https://issues.apache.org/jira/browse/FLINK-4813
> Project: Flink
> Issue Type: Bug
> Components: Build System
>Affects Versions: 1.2.0
>Reporter: Robert Metzger
>
> The {{flink-test-utils}} depend on {{hadoop-minikdc}}, which has a
> dependency, which is only resolvable, if the {{maven-bundle-plugin}} is
> loaded.
> This is the error message
> {code}
> [ERROR] Failed to execute goal on project quickstart-1.2-tests: Could not
> resolve dependencies for project
> com.dataartisans:quickstart-1.2-tests:jar:1.0-SNAPSHOT: Failure to find
> org.apache.directory.jdbm:apacheds-jdbm1:bundle:2.0.0-M2 in
> https://repo.maven.apache.org/maven2 was cached in the local repository,
> resolution will not be reattempted until the update interval of central has
> elapsed or updates are forced -> [Help 1]
> {code}
> {{flink-parent}} loads that plugin, so all "internal" dependencies to the
> test utils can resolve the plugin.
> Right now, users have to use the maven bundle plugin to use our test utils
> externally.
> By making the hadoop minikdc dependency optional, we can probably resolve the
> issues. Then, only users who want to use the security-related tools in the
> test utils need to manually add the hadoop minikdc dependency + the plugin.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4813) Having flink-test-utils as a dependency outside Flink fails the build
[
https://issues.apache.org/jira/browse/FLINK-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568657#comment-15568657
]
Maximilian Michels commented on FLINK-4813:
---
+1 That sounds like a good solution.
> Having flink-test-utils as a dependency outside Flink fails the build
> -
>
> Key: FLINK-4813
> URL: https://issues.apache.org/jira/browse/FLINK-4813
> Project: Flink
> Issue Type: Bug
> Components: Build System
>Affects Versions: 1.2.0
>Reporter: Robert Metzger
>
> The {{flink-test-utils}} depend on {{hadoop-minikdc}}, which has a
> dependency, which is only resolvable, if the {{maven-bundle-plugin}} is
> loaded.
> This is the error message
> {code}
> [ERROR] Failed to execute goal on project quickstart-1.2-tests: Could not
> resolve dependencies for project
> com.dataartisans:quickstart-1.2-tests:jar:1.0-SNAPSHOT: Failure to find
> org.apache.directory.jdbm:apacheds-jdbm1:bundle:2.0.0-M2 in
> https://repo.maven.apache.org/maven2 was cached in the local repository,
> resolution will not be reattempted until the update interval of central has
> elapsed or updates are forced -> [Help 1]
> {code}
> {{flink-parent}} loads that plugin, so all "internal" dependencies to the
> test utils can resolve the plugin.
> Right now, users have to use the maven bundle plugin to use our test utils
> externally.
> By making the hadoop minikdc dependency optional, we can probably resolve the
> issues. Then, only users who want to use the security-related tools in the
> test utils need to manually add the hadoop minikdc dependency + the plugin.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
