[jira] [Commented] (FLINK-5831) Sort metrics in metric selector and add search box

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004997#comment-16004997
 ] 

ASF GitHub Bot commented on FLINK-5831:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/3369


> Sort metrics in metric selector and add search box
> --
>
> Key: FLINK-5831
> URL: https://issues.apache.org/jira/browse/FLINK-5831
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Reporter: Robert Metzger
> Attachments: dropDown.png
>
>
> The JobManager UI makes it hard to select metrics using the drop down menu.
> First of all, it would me nice to sort all entries. Also a search box on top 
> of the drop down would make it much easier to find the metrics.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5831) Sort metrics in metric selector and add search box

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004992#comment-16004992
 ] 

ASF GitHub Bot commented on FLINK-5831:
---

Github user greghogan commented on the issue:

https://github.com/apache/flink/pull/3369
  
@nellboy and also thanks for this contribution! Merging ...


> Sort metrics in metric selector and add search box
> --
>
> Key: FLINK-5831
> URL: https://issues.apache.org/jira/browse/FLINK-5831
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Reporter: Robert Metzger
> Attachments: dropDown.png
>
>
> The JobManager UI makes it hard to select metrics using the drop down menu.
> First of all, it would me nice to sort all entries. Also a search box on top 
> of the drop down would make it much easier to find the metrics.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5831) Sort metrics in metric selector and add search box

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989857#comment-15989857
 ] 

ASF GitHub Bot commented on FLINK-5831:
---

Github user greghogan commented on the issue:

https://github.com/apache/flink/pull/3369
  
@nellboy please rebase to master.


> Sort metrics in metric selector and add search box
> --
>
> Key: FLINK-5831
> URL: https://issues.apache.org/jira/browse/FLINK-5831
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Reporter: Robert Metzger
> Attachments: dropDown.png
>
>
> The JobManager UI makes it hard to select metrics using the drop down menu.
> First of all, it would me nice to sort all entries. Also a search box on top 
> of the drop down would make it much easier to find the metrics.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5831) Sort metrics in metric selector and add search box

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875750#comment-15875750
 ] 

ASF GitHub Bot commented on FLINK-5831:
---

Github user rmetzger commented on the issue:

https://github.com/apache/flink/pull/3369
  
Cool, very nice!


> Sort metrics in metric selector and add search box
> --
>
> Key: FLINK-5831
> URL: https://issues.apache.org/jira/browse/FLINK-5831
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Reporter: Robert Metzger
> Attachments: dropDown.png
>
>
> The JobManager UI makes it hard to select metrics using the drop down menu.
> First of all, it would me nice to sort all entries. Also a search box on top 
> of the drop down would make it much easier to find the metrics.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5831) Sort metrics in metric selector and add search box

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875725#comment-15875725
 ] 

ASF GitHub Bot commented on FLINK-5831:
---

Github user nellboy commented on the issue:

https://github.com/apache/flink/pull/3369
  
Ok,  this has been updated now. 
![screen shot 2017-02-21 at 11 02 
41](https://cloud.githubusercontent.com/assets/39847/23160154/b2ea3f90-f825-11e6-8f3e-5f775b8204a8.png)



> Sort metrics in metric selector and add search box
> --
>
> Key: FLINK-5831
> URL: https://issues.apache.org/jira/browse/FLINK-5831
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Reporter: Robert Metzger
> Attachments: dropDown.png
>
>
> The JobManager UI makes it hard to select metrics using the drop down menu.
> First of all, it would me nice to sort all entries. Also a search box on top 
> of the drop down would make it much easier to find the metrics.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5831) Sort metrics in metric selector and add search box

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875632#comment-15875632
 ] 

ASF GitHub Bot commented on FLINK-5831:
---

Github user rmetzger commented on the issue:

https://github.com/apache/flink/pull/3369
  
Thank you for opening a pull request addressing the issue.

I know it is out of scope of the JIRA, but since you are working on it 
already, I was wondering if we can improve the optics of the metric selector 
dropdown a bit.
I think it would look much nicer, if the search text field spans the entire 
width of the box, and if the selectable entries are aligned on the left.
What do you think?


> Sort metrics in metric selector and add search box
> --
>
> Key: FLINK-5831
> URL: https://issues.apache.org/jira/browse/FLINK-5831
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Reporter: Robert Metzger
> Attachments: dropDown.png
>
>
> The JobManager UI makes it hard to select metrics using the drop down menu.
> First of all, it would me nice to sort all entries. Also a search box on top 
> of the drop down would make it much easier to find the metrics.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5831) Sort metrics in metric selector and add search box

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874853#comment-15874853
 ] 

ASF GitHub Bot commented on FLINK-5831:
---

GitHub user nellboy opened a pull request:

https://github.com/apache/flink/pull/3369

[FLINK-5831] [webui] order, search and filter metrics

Metrics are now ordered, and searchable when displaying which metrics 
graphs to display in the web ui.
![screen shot 2017-02-20 at 16 09 
58](https://cloud.githubusercontent.com/assets/39847/23136003/fc02da1a-f79a-11e6-90c0-8da1742d42c1.png)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nellboy/flink webui/metrics-filtering

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/3369.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3369


commit 730e7b6d3b35855d93049e48850ca5919f7db968
Author: paul 
Date:   2017-02-20T09:28:14Z

[FLINK-5831] [webui] sort metrics by id

commit 45f5c565d9a805f78c40ed8ad7cc497aaf5c438f
Author: paul 
Date:   2017-02-20T17:27:13Z

[FLINK-5831] [webui] order, search and filter metrics




> Sort metrics in metric selector and add search box
> --
>
> Key: FLINK-5831
> URL: https://issues.apache.org/jira/browse/FLINK-5831
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Reporter: Robert Metzger
> Attachments: dropDown.png
>
>
> The JobManager UI makes it hard to select metrics using the drop down menu.
> First of all, it would me nice to sort all entries. Also a search box on top 
> of the drop down would make it much easier to find the metrics.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5831) Sort metrics in metric selector and add search box

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874850#comment-15874850
 ] 

ASF GitHub Bot commented on FLINK-5831:
---

Github user nellboy closed the pull request at:

https://github.com/apache/flink/pull/3362


> Sort metrics in metric selector and add search box
> --
>
> Key: FLINK-5831
> URL: https://issues.apache.org/jira/browse/FLINK-5831
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Reporter: Robert Metzger
> Attachments: dropDown.png
>
>
> The JobManager UI makes it hard to select metrics using the drop down menu.
> First of all, it would me nice to sort all entries. Also a search box on top 
> of the drop down would make it much easier to find the metrics.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5831) Sort metrics in metric selector and add search box

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874673#comment-15874673
 ] 

ASF GitHub Bot commented on FLINK-5831:
---

Github user nellboy commented on the issue:

https://github.com/apache/flink/pull/3362
  
Yes, here is the screenshot ... also will rebase on master
![screen shot 2017-02-20 at 16 09 
58](https://cloud.githubusercontent.com/assets/39847/23130544/2f022510-f787-11e6-84d3-b423b2fec8d2.png)



> Sort metrics in metric selector and add search box
> --
>
> Key: FLINK-5831
> URL: https://issues.apache.org/jira/browse/FLINK-5831
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Reporter: Robert Metzger
> Attachments: dropDown.png
>
>
> The JobManager UI makes it hard to select metrics using the drop down menu.
> First of all, it would me nice to sort all entries. Also a search box on top 
> of the drop down would make it much easier to find the metrics.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5831) Sort metrics in metric selector and add search box

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874669#comment-15874669
 ] 

ASF GitHub Bot commented on FLINK-5831:
---

Github user rmetzger commented on the issue:

https://github.com/apache/flink/pull/3362
  
Thank you for opening a PR.
Can you provide a screenshot of the change. Also, the PR is conflicting 
with the current master, so we can not just merge it:

![image](https://cloud.githubusercontent.com/assets/89049/23130497/f2ee89ce-f786-11e6-94ca-2d76d53ee1e8.png)

Can you rebase the PR on the current master?




> Sort metrics in metric selector and add search box
> --
>
> Key: FLINK-5831
> URL: https://issues.apache.org/jira/browse/FLINK-5831
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Reporter: Robert Metzger
> Attachments: dropDown.png
>
>
> The JobManager UI makes it hard to select metrics using the drop down menu.
> First of all, it would me nice to sort all entries. Also a search box on top 
> of the drop down would make it much easier to find the metrics.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-5831) Sort metrics in metric selector and add search box

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874660#comment-15874660
 ] 

ASF GitHub Bot commented on FLINK-5831:
---

GitHub user nellboy opened a pull request:

https://github.com/apache/flink/pull/3362

[FLINK-5831] [webui] order, search and filter metrics

When adding metrics, available metrics are now ordered alphabetically and 
filtered via a search box

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nellboy/flink webui/metrics-selection

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/3362.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3362


commit 2929dbe93984117d71a57e4499337d3fbfbc5537
Author: paul 
Date:   2017-02-20T09:28:14Z

[FLINK-5831] [webui] sort metrics by id

commit c2393bd01e06edf360002bd87f46c3f50fcda62f
Author: paul 
Date:   2017-02-20T15:01:25Z

[FLINK-5831] [webui] search and filter metrics




> Sort metrics in metric selector and add search box
> --
>
> Key: FLINK-5831
> URL: https://issues.apache.org/jira/browse/FLINK-5831
> Project: Flink
>  Issue Type: Improvement
>  Components: Webfrontend
>Reporter: Robert Metzger
> Attachments: dropDown.png
>
>
> The JobManager UI makes it hard to select metrics using the drop down menu.
> First of all, it would me nice to sort all entries. Also a search box on top 
> of the drop down would make it much easier to find the metrics.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)