[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink
[
https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15983948#comment-15983948
]
mingleizhang commented on FLINK-5855:
-
[~tedyu] Hi, Ted. Thanks for telling me so useful information. I know what to
do and how to do next time. Thanks again and very appreciate it.
> Unprotected access to pendingFilesPerCheckpoint in BucketingSink
>
>
> Key: FLINK-5855
> URL: https://issues.apache.org/jira/browse/FLINK-5855
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
>Reporter: Ted Yu
>Assignee: mingleizhang
>Priority: Minor
>
> {code}
> handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);
> synchronized (restoredState.pendingFilesPerCheckpoint) {
> restoredState.pendingFilesPerCheckpoint.clear();
> {code}
> Lock on pendingFilesPerCheckpoint should be obtained prior to the call to
> handlePendingFilesForPreviousCheckpoints().
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink
[
https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15983282#comment-15983282
]
Ted Yu commented on FLINK-5855:
---
IMO, after discussion, if the new fix is in the same area of code, the
description of the JIRA can be modified to reflect the outcome of discussion -
instead of closing the first JIRA and opening a new one.
> Unprotected access to pendingFilesPerCheckpoint in BucketingSink
>
>
> Key: FLINK-5855
> URL: https://issues.apache.org/jira/browse/FLINK-5855
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
>Reporter: Ted Yu
>Assignee: mingleizhang
>Priority: Minor
>
> {code}
> handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);
> synchronized (restoredState.pendingFilesPerCheckpoint) {
> restoredState.pendingFilesPerCheckpoint.clear();
> {code}
> Lock on pendingFilesPerCheckpoint should be obtained prior to the call to
> handlePendingFilesForPreviousCheckpoints().
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink
[
https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982527#comment-15982527
]
ASF GitHub Bot commented on FLINK-5855:
---
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3758
@zhangminglei Perfect!
> Unprotected access to pendingFilesPerCheckpoint in BucketingSink
>
>
> Key: FLINK-5855
> URL: https://issues.apache.org/jira/browse/FLINK-5855
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
>Reporter: Ted Yu
>Assignee: mingleizhang
>Priority: Minor
>
> {code}
> handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);
> synchronized (restoredState.pendingFilesPerCheckpoint) {
> restoredState.pendingFilesPerCheckpoint.clear();
> {code}
> Lock on pendingFilesPerCheckpoint should be obtained prior to the call to
> handlePendingFilesForPreviousCheckpoints().
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink
[
https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982522#comment-15982522
]
ASF GitHub Bot commented on FLINK-5855:
---
Github user zhangminglei closed the pull request at:
https://github.com/apache/flink/pull/3758
> Unprotected access to pendingFilesPerCheckpoint in BucketingSink
>
>
> Key: FLINK-5855
> URL: https://issues.apache.org/jira/browse/FLINK-5855
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
>Reporter: Ted Yu
>Assignee: mingleizhang
>Priority: Minor
>
> {code}
> handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);
> synchronized (restoredState.pendingFilesPerCheckpoint) {
> restoredState.pendingFilesPerCheckpoint.clear();
> {code}
> Lock on pendingFilesPerCheckpoint should be obtained prior to the call to
> handlePendingFilesForPreviousCheckpoints().
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink
[
https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982521#comment-15982521
]
ASF GitHub Bot commented on FLINK-5855:
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3758
@kl0u Yep. I reopened this PR again for waiting you message me. Haha ~
Okay, Now, I will close it and then create another jira and cc you.
> Unprotected access to pendingFilesPerCheckpoint in BucketingSink
>
>
> Key: FLINK-5855
> URL: https://issues.apache.org/jira/browse/FLINK-5855
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
>Reporter: Ted Yu
>Assignee: mingleizhang
>Priority: Minor
>
> {code}
> handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);
> synchronized (restoredState.pendingFilesPerCheckpoint) {
> restoredState.pendingFilesPerCheckpoint.clear();
> {code}
> Lock on pendingFilesPerCheckpoint should be obtained prior to the call to
> handlePendingFilesForPreviousCheckpoints().
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink
[
https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982446#comment-15982446
]
ASF GitHub Bot commented on FLINK-5855:
---
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3758
Yes. This sounds good, but you reopened this pull request right? Shouldn't
this be closed?
> Unprotected access to pendingFilesPerCheckpoint in BucketingSink
>
>
> Key: FLINK-5855
> URL: https://issues.apache.org/jira/browse/FLINK-5855
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
>Reporter: Ted Yu
>Assignee: mingleizhang
>Priority: Minor
>
> {code}
> handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);
> synchronized (restoredState.pendingFilesPerCheckpoint) {
> restoredState.pendingFilesPerCheckpoint.clear();
> {code}
> Lock on pendingFilesPerCheckpoint should be obtained prior to the call to
> handlePendingFilesForPreviousCheckpoints().
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink
[
https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982231#comment-15982231
]
ASF GitHub Bot commented on FLINK-5855:
---
Github user zhangminglei closed the pull request at:
https://github.com/apache/flink/pull/3758
> Unprotected access to pendingFilesPerCheckpoint in BucketingSink
>
>
> Key: FLINK-5855
> URL: https://issues.apache.org/jira/browse/FLINK-5855
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
>Reporter: Ted Yu
>Assignee: mingleizhang
>Priority: Minor
>
> {code}
> handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);
> synchronized (restoredState.pendingFilesPerCheckpoint) {
> restoredState.pendingFilesPerCheckpoint.clear();
> {code}
> Lock on pendingFilesPerCheckpoint should be obtained prior to the call to
> handlePendingFilesForPreviousCheckpoints().
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink
[
https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982232#comment-15982232
]
ASF GitHub Bot commented on FLINK-5855:
---
GitHub user zhangminglei reopened a pull request:
https://github.com/apache/flink/pull/3758
[FLINK-5855][Streaming Connectors] Unprotected access to pendingFiles…
…PerCheckpoint in BucketingSink.
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-5855
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3758.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3758
commit f99a1cfea95b4a7f1760d97526beac133a25d03b
Author: zhangminglei
Date: 2017-04-24T03:08:17Z
[FLINK-5855][Streaming Connectors] Unprotected access to
pendingFilesPerCheckpoint in BucketingSink.
> Unprotected access to pendingFilesPerCheckpoint in BucketingSink
>
>
> Key: FLINK-5855
> URL: https://issues.apache.org/jira/browse/FLINK-5855
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
>Reporter: Ted Yu
>Assignee: mingleizhang
>Priority: Minor
>
> {code}
> handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);
> synchronized (restoredState.pendingFilesPerCheckpoint) {
> restoredState.pendingFilesPerCheckpoint.clear();
> {code}
> Lock on pendingFilesPerCheckpoint should be obtained prior to the call to
> handlePendingFilesForPreviousCheckpoints().
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink
[
https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982229#comment-15982229
]
ASF GitHub Bot commented on FLINK-5855:
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3758
@kl0u Thanks for review , very appreciate it. Yep, BTW, I would like to
work on what you will thorough the code in the following days and keep watching
this class ```synchronized()```. Hopes work on the new jira if you could assign
to me. I will close this PR and JIRA as well.
> Unprotected access to pendingFilesPerCheckpoint in BucketingSink
>
>
> Key: FLINK-5855
> URL: https://issues.apache.org/jira/browse/FLINK-5855
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
>Reporter: Ted Yu
>Assignee: mingleizhang
>Priority: Minor
>
> {code}
> handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);
> synchronized (restoredState.pendingFilesPerCheckpoint) {
> restoredState.pendingFilesPerCheckpoint.clear();
> {code}
> Lock on pendingFilesPerCheckpoint should be obtained prior to the call to
> handlePendingFilesForPreviousCheckpoints().
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink
[
https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981456#comment-15981456
]
ASF GitHub Bot commented on FLINK-5855:
---
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3758
Hi @zhangminglei, thanks for looking into this! I tend to agree with
@tillrohrmann that there is not need for locking there, as there is no sharing
of the data-structure between different threads. The same holds for the lock at
line 726. So these 2 `synchronized()` clauses could go away.
I will have a more thorough look on the whole locking scheme in the class
in the following days. But for now I think that this PR could be closed and the
JIRA could be updated.
What do you think?
> Unprotected access to pendingFilesPerCheckpoint in BucketingSink
>
>
> Key: FLINK-5855
> URL: https://issues.apache.org/jira/browse/FLINK-5855
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
>Reporter: Ted Yu
>Assignee: mingleizhang
>Priority: Minor
>
> {code}
> handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);
> synchronized (restoredState.pendingFilesPerCheckpoint) {
> restoredState.pendingFilesPerCheckpoint.clear();
> {code}
> Lock on pendingFilesPerCheckpoint should be obtained prior to the call to
> handlePendingFilesForPreviousCheckpoints().
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink
[
https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980981#comment-15980981
]
ASF GitHub Bot commented on FLINK-5855:
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3758
Not sure why we're synchronizing on the `pendingFilesPerCheckpoint` field
at all, because it is only the restored state object. Maybe @kl0u can shed some
light on that.
> Unprotected access to pendingFilesPerCheckpoint in BucketingSink
>
>
> Key: FLINK-5855
> URL: https://issues.apache.org/jira/browse/FLINK-5855
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
>Reporter: Ted Yu
>Assignee: mingleizhang
>Priority: Minor
>
> {code}
> handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);
> synchronized (restoredState.pendingFilesPerCheckpoint) {
> restoredState.pendingFilesPerCheckpoint.clear();
> {code}
> Lock on pendingFilesPerCheckpoint should be obtained prior to the call to
> handlePendingFilesForPreviousCheckpoints().
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink
[
https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980672#comment-15980672
]
ASF GitHub Bot commented on FLINK-5855:
---
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/3758
[FLINK-5855][Streaming Connectors] Unprotected access to pendingFiles…
…PerCheckpoint in BucketingSink.
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-5855
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3758.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3758
commit f99a1cfea95b4a7f1760d97526beac133a25d03b
Author: zhangminglei
Date: 2017-04-24T03:08:17Z
[FLINK-5855][Streaming Connectors] Unprotected access to
pendingFilesPerCheckpoint in BucketingSink.
> Unprotected access to pendingFilesPerCheckpoint in BucketingSink
>
>
> Key: FLINK-5855
> URL: https://issues.apache.org/jira/browse/FLINK-5855
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
>Reporter: Ted Yu
>Priority: Minor
>
> {code}
> handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);
> synchronized (restoredState.pendingFilesPerCheckpoint) {
> restoredState.pendingFilesPerCheckpoint.clear();
> {code}
> Lock on pendingFilesPerCheckpoint should be obtained prior to the call to
> handlePendingFilesForPreviousCheckpoints().
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink
[
https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980673#comment-15980673
]
ASF GitHub Bot commented on FLINK-5855:
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3758
cc @tillrohrmann
> Unprotected access to pendingFilesPerCheckpoint in BucketingSink
>
>
> Key: FLINK-5855
> URL: https://issues.apache.org/jira/browse/FLINK-5855
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
>Reporter: Ted Yu
>Priority: Minor
>
> {code}
> handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);
> synchronized (restoredState.pendingFilesPerCheckpoint) {
> restoredState.pendingFilesPerCheckpoint.clear();
> {code}
> Lock on pendingFilesPerCheckpoint should be obtained prior to the call to
> handlePendingFilesForPreviousCheckpoints().
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink
[
https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980671#comment-15980671
]
mingleizhang commented on FLINK-5855:
-
Okay, thanks. I will give a PR to this. I dont know really, why so many issue
like concurrent and lock in Flink if there is really a question.
> Unprotected access to pendingFilesPerCheckpoint in BucketingSink
>
>
> Key: FLINK-5855
> URL: https://issues.apache.org/jira/browse/FLINK-5855
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
>Reporter: Ted Yu
>Priority: Minor
>
> {code}
> handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);
> synchronized (restoredState.pendingFilesPerCheckpoint) {
> restoredState.pendingFilesPerCheckpoint.clear();
> {code}
> Lock on pendingFilesPerCheckpoint should be obtained prior to the call to
> handlePendingFilesForPreviousCheckpoints().
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink
[
https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980669#comment-15980669
]
Ted Yu commented on FLINK-5855:
---
lgtm
> Unprotected access to pendingFilesPerCheckpoint in BucketingSink
>
>
> Key: FLINK-5855
> URL: https://issues.apache.org/jira/browse/FLINK-5855
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
>Reporter: Ted Yu
>Priority: Minor
>
> {code}
> handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);
> synchronized (restoredState.pendingFilesPerCheckpoint) {
> restoredState.pendingFilesPerCheckpoint.clear();
> {code}
> Lock on pendingFilesPerCheckpoint should be obtained prior to the call to
> handlePendingFilesForPreviousCheckpoints().
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink
[
https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980668#comment-15980668
]
mingleizhang commented on FLINK-5855:
-
I think the code snippet would follow your suggestion. How do you think ?
{code}
synchronized (restoredState.pendingFilesPerCheckpoint) {
handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);
restoredState.pendingFilesPerCheckpoint.clear();
}
{code}
> Unprotected access to pendingFilesPerCheckpoint in BucketingSink
>
>
> Key: FLINK-5855
> URL: https://issues.apache.org/jira/browse/FLINK-5855
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
>Reporter: Ted Yu
>Priority: Minor
>
> {code}
> handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);
> synchronized (restoredState.pendingFilesPerCheckpoint) {
> restoredState.pendingFilesPerCheckpoint.clear();
> {code}
> Lock on pendingFilesPerCheckpoint should be obtained prior to the call to
> handlePendingFilesForPreviousCheckpoints().
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink
[
https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980664#comment-15980664
]
mingleizhang commented on FLINK-5855:
-
@Ted Yu, Yep. That is right. So, follow your suggestion. I would write the code
snippet like {code}. Correct ?
synchronized (restoredState.pendingFilesPerCheckpoint) {
restoredState.pendingFilesPerCheckpoint.clear();
}
handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);
{code}
> Unprotected access to pendingFilesPerCheckpoint in BucketingSink
>
>
> Key: FLINK-5855
> URL: https://issues.apache.org/jira/browse/FLINK-5855
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
>Reporter: Ted Yu
>Priority: Minor
>
> {code}
> handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);
> synchronized (restoredState.pendingFilesPerCheckpoint) {
> restoredState.pendingFilesPerCheckpoint.clear();
> {code}
> Lock on pendingFilesPerCheckpoint should be obtained prior to the call to
> handlePendingFilesForPreviousCheckpoints().
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink
[
https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980646#comment-15980646
]
Ted Yu commented on FLINK-5855:
---
Didn't get your question: clear() is called after
handlePendingFilesForPreviousCheckpoints().
> Unprotected access to pendingFilesPerCheckpoint in BucketingSink
>
>
> Key: FLINK-5855
> URL: https://issues.apache.org/jira/browse/FLINK-5855
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
>Reporter: Ted Yu
>Priority: Minor
>
> {code}
> handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);
> synchronized (restoredState.pendingFilesPerCheckpoint) {
> restoredState.pendingFilesPerCheckpoint.clear();
> {code}
> Lock on pendingFilesPerCheckpoint should be obtained prior to the call to
> handlePendingFilesForPreviousCheckpoints().
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink
[
https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980624#comment-15980624
]
mingleizhang commented on FLINK-5855:
-
[~tedyu] Hi, Ted. I would ask if {code}pendingFilesPerCheckpoint {code} prior
to the call of {code}handlePendingFilesForPreviousCheckpoints{code}. It is a
maybe that the it has alreay removed all elements from the map. Then trigger
the {code}handlePendingFilesForPreviousCheckpoints{code}. Is there a problem
should occur here ? CC [~till.rohrmann]
> Unprotected access to pendingFilesPerCheckpoint in BucketingSink
>
>
> Key: FLINK-5855
> URL: https://issues.apache.org/jira/browse/FLINK-5855
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
>Reporter: Ted Yu
>Priority: Minor
>
> {code}
> handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);
> synchronized (restoredState.pendingFilesPerCheckpoint) {
> restoredState.pendingFilesPerCheckpoint.clear();
> {code}
> Lock on pendingFilesPerCheckpoint should be obtained prior to the call to
> handlePendingFilesForPreviousCheckpoints().
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
