[jira] [Commented] (FLINK-6271) NumericBetweenParametersProvider NullPointer
[ https://issues.apache.org/jira/browse/FLINK-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972227#comment-15972227 ] ASF GitHub Bot commented on FLINK-6271: --- Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/3686 You were right @patricklucas, now I've correct the email address in my .gitconfig. Thanks! > NumericBetweenParametersProvider NullPointer > > > Key: FLINK-6271 > URL: https://issues.apache.org/jira/browse/FLINK-6271 > Project: Flink > Issue Type: Bug > Components: Batch Connectors and Input/Output Formats >Affects Versions: 1.2.0 >Reporter: Flavio Pompermaier >Assignee: Flavio Pompermaier > Labels: jdbc > Fix For: 1.3.0 > > > creating a NumericBetweenParametersProvider using fetchSize=1000, min=0 and > max= 999 fails with a NP -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-6271) NumericBetweenParametersProvider NullPointer
[ https://issues.apache.org/jira/browse/FLINK-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972202#comment-15972202 ] ASF GitHub Bot commented on FLINK-6271: --- Github user patricklucas commented on the issue: https://github.com/apache/flink/pull/3686 @fpompermaier FYI your author email address on this commit was "f.pomperma...@gmai.com" (missing 'l'). You might have a typo in your gitconfig? > NumericBetweenParametersProvider NullPointer > > > Key: FLINK-6271 > URL: https://issues.apache.org/jira/browse/FLINK-6271 > Project: Flink > Issue Type: Bug > Components: Batch Connectors and Input/Output Formats >Affects Versions: 1.2.0 >Reporter: Flavio Pompermaier >Assignee: Flavio Pompermaier > Labels: jdbc > Fix For: 1.3.0 > > > creating a NumericBetweenParametersProvider using fetchSize=1000, min=0 and > max= 999 fails with a NP -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-6271) NumericBetweenParametersProvider NullPointer
[ https://issues.apache.org/jira/browse/FLINK-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970047#comment-15970047 ] ASF GitHub Bot commented on FLINK-6271: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3686 > NumericBetweenParametersProvider NullPointer > > > Key: FLINK-6271 > URL: https://issues.apache.org/jira/browse/FLINK-6271 > Project: Flink > Issue Type: Bug > Components: Batch Connectors and Input/Output Formats >Affects Versions: 1.2.0 >Reporter: Flavio Pompermaier >Assignee: Flavio Pompermaier > Labels: jdbc > Fix For: 1.3.0 > > > creating a NumericBetweenParametersProvider using fetchSize=1000, min=0 and > max= 999 fails with a NP -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-6271) NumericBetweenParametersProvider NullPointer
[ https://issues.apache.org/jira/browse/FLINK-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969936#comment-15969936 ] ASF GitHub Bot commented on FLINK-6271: --- Github user zentol commented on the issue: https://github.com/apache/flink/pull/3686 merging. > NumericBetweenParametersProvider NullPointer > > > Key: FLINK-6271 > URL: https://issues.apache.org/jira/browse/FLINK-6271 > Project: Flink > Issue Type: Bug > Components: Batch Connectors and Input/Output Formats >Affects Versions: 1.2.0 >Reporter: Flavio Pompermaier >Assignee: Flavio Pompermaier > Labels: jdbc > > creating a NumericBetweenParametersProvider using fetchSize=1000, min=0 and > max= 999 fails with a NP -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-6271) NumericBetweenParametersProvider NullPointer
[
https://issues.apache.org/jira/browse/FLINK-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960455#comment-15960455
]
ASF GitHub Bot commented on FLINK-6271:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3686#discussion_r110338259
--- Diff:
flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormatTest.java
---
@@ -162,11 +162,11 @@ public void
testJDBCInputFormatWithParallelismAndNumericColumnSplitting() throws
if (next == null) {
break;
}
- if(next.getField(0)!=null) {
Assert.assertEquals("Field 0 should be int", Integer.class,
next.getField(0).getClass());}
- if(next.getField(1)!=null) {
Assert.assertEquals("Field 1 should be String", String.class,
next.getField(1).getClass());}
- if(next.getField(2)!=null) {
Assert.assertEquals("Field 2 should be String", String.class,
next.getField(2).getClass());}
- if(next.getField(3)!=null) {
Assert.assertEquals("Field 3 should be float", Double.class,
next.getField(3).getClass());}
- if(next.getField(4)!=null) {
Assert.assertEquals("Field 4 should be int", Integer.class,
next.getField(4).getClass());}
+ if (next.getField(0) != null) {
Assert.assertEquals("Field 0 should be int", Integer.class,
next.getField(0).getClass());}
--- End diff --
Sorry, I don't know anything about eclipse. The easiest way to check the
checkstyle is to run `mvn verify -DskipTests` for the module that you're
changing.
> NumericBetweenParametersProvider NullPointer
>
>
> Key: FLINK-6271
> URL: https://issues.apache.org/jira/browse/FLINK-6271
> Project: Flink
> Issue Type: Bug
> Components: Batch Connectors and Input/Output Formats
>Affects Versions: 1.2.0
>Reporter: Flavio Pompermaier
>Assignee: Flavio Pompermaier
> Labels: jdbc
>
> creating a NumericBetweenParametersProvider using fetchSize=1000, min=0 and
> max= 999 fails with a NP
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-6271) NumericBetweenParametersProvider NullPointer
[
https://issues.apache.org/jira/browse/FLINK-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960452#comment-15960452
]
ASF GitHub Bot commented on FLINK-6271:
---
Github user fpompermaier commented on a diff in the pull request:
https://github.com/apache/flink/pull/3686#discussion_r110337693
--- Diff:
flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormatTest.java
---
@@ -162,11 +162,11 @@ public void
testJDBCInputFormatWithParallelismAndNumericColumnSplitting() throws
if (next == null) {
break;
}
- if(next.getField(0)!=null) {
Assert.assertEquals("Field 0 should be int", Integer.class,
next.getField(0).getClass());}
- if(next.getField(1)!=null) {
Assert.assertEquals("Field 1 should be String", String.class,
next.getField(1).getClass());}
- if(next.getField(2)!=null) {
Assert.assertEquals("Field 2 should be String", String.class,
next.getField(2).getClass());}
- if(next.getField(3)!=null) {
Assert.assertEquals("Field 3 should be float", Double.class,
next.getField(3).getClass());}
- if(next.getField(4)!=null) {
Assert.assertEquals("Field 4 should be int", Integer.class,
next.getField(4).getClass());}
+ if (next.getField(0) != null) {
Assert.assertEquals("Field 0 should be int", Integer.class,
next.getField(0).getClass());}
--- End diff --
I didn't know that Flink introduces checkstyle at compile time...is there
any official Eclipse formatter somewhere I can use to verify the code at
development time?
> NumericBetweenParametersProvider NullPointer
>
>
> Key: FLINK-6271
> URL: https://issues.apache.org/jira/browse/FLINK-6271
> Project: Flink
> Issue Type: Bug
> Components: Batch Connectors and Input/Output Formats
>Affects Versions: 1.2.0
>Reporter: Flavio Pompermaier
>Assignee: Flavio Pompermaier
> Labels: jdbc
>
> creating a NumericBetweenParametersProvider using fetchSize=1000, min=0 and
> max= 999 fails with a NP
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-6271) NumericBetweenParametersProvider NullPointer
[ https://issues.apache.org/jira/browse/FLINK-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960448#comment-15960448 ] ASF GitHub Bot commented on FLINK-6271: --- Github user zentol commented on the issue: https://github.com/apache/flink/pull/3686 The approach is good though, once we sort out the formatting we're good to go imo. > NumericBetweenParametersProvider NullPointer > > > Key: FLINK-6271 > URL: https://issues.apache.org/jira/browse/FLINK-6271 > Project: Flink > Issue Type: Bug > Components: Batch Connectors and Input/Output Formats >Affects Versions: 1.2.0 >Reporter: Flavio Pompermaier >Assignee: Flavio Pompermaier > Labels: jdbc > > creating a NumericBetweenParametersProvider using fetchSize=1000, min=0 and > max= 999 fails with a NP -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (FLINK-6271) NumericBetweenParametersProvider NullPointer
[
https://issues.apache.org/jira/browse/FLINK-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960447#comment-15960447
]
ASF GitHub Bot commented on FLINK-6271:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3686#discussion_r110337050
--- Diff:
flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormatTest.java
---
@@ -162,11 +162,11 @@ public void
testJDBCInputFormatWithParallelismAndNumericColumnSplitting() throws
if (next == null) {
break;
}
- if(next.getField(0)!=null) {
Assert.assertEquals("Field 0 should be int", Integer.class,
next.getField(0).getClass());}
- if(next.getField(1)!=null) {
Assert.assertEquals("Field 1 should be String", String.class,
next.getField(1).getClass());}
- if(next.getField(2)!=null) {
Assert.assertEquals("Field 2 should be String", String.class,
next.getField(2).getClass());}
- if(next.getField(3)!=null) {
Assert.assertEquals("Field 3 should be float", Double.class,
next.getField(3).getClass());}
- if(next.getField(4)!=null) {
Assert.assertEquals("Field 4 should be int", Integer.class,
next.getField(4).getClass());}
+ if (next.getField(0) != null) {
Assert.assertEquals("Field 0 should be int", Integer.class,
next.getField(0).getClass());}
--- End diff --
you missed putting the assertions on a new line.
> NumericBetweenParametersProvider NullPointer
>
>
> Key: FLINK-6271
> URL: https://issues.apache.org/jira/browse/FLINK-6271
> Project: Flink
> Issue Type: Bug
> Components: Batch Connectors and Input/Output Formats
>Affects Versions: 1.2.0
>Reporter: Flavio Pompermaier
>Assignee: Flavio Pompermaier
> Labels: jdbc
>
> creating a NumericBetweenParametersProvider using fetchSize=1000, min=0 and
> max= 999 fails with a NP
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (FLINK-6271) NumericBetweenParametersProvider NullPointer
[ https://issues.apache.org/jira/browse/FLINK-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960440#comment-15960440 ] ASF GitHub Bot commented on FLINK-6271: --- Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/3686 Is it ok...? Could this be merged? > NumericBetweenParametersProvider NullPointer > > > Key: FLINK-6271 > URL: https://issues.apache.org/jira/browse/FLINK-6271 > Project: Flink > Issue Type: Bug > Components: Batch Connectors and Input/Output Formats >Affects Versions: 1.2.0 >Reporter: Flavio Pompermaier >Assignee: Flavio Pompermaier > Labels: jdbc > > creating a NumericBetweenParametersProvider using fetchSize=1000, min=0 and > max= 999 fails with a NP -- This message was sent by Atlassian JIRA (v6.3.15#6346)
