[jira] [Commented] (FLINK-6286) hbase command not found error

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972651#comment-15972651
 ] 

ASF GitHub Bot commented on FLINK-6286:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/3711


> hbase command not found error
> -
>
> Key: FLINK-6286
> URL: https://issues.apache.org/jira/browse/FLINK-6286
> Project: Flink
>  Issue Type: Bug
>  Components: Batch Connectors and Input/Output Formats, Startup Shell 
> Scripts
>Reporter: Jinjiang Ling
>Assignee: Jinjiang Ling
>Priority: Minor
> Fix For: 1.3.0
>
> Attachments: FLINK-6286-0.patch, FLINK-6286-1.patch, 
> FLINK-6286-2.patch, FLINK-6286-3.patch
>
>
> As I'm using flink with the HBASE_CONF_DIR env variable and don't install 
> hbase, then I get the error message below.
> {quote}
> *bin/config.sh: line 303: hbase: command not found*
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6286) hbase command not found error

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972634#comment-15972634
 ] 

ASF GitHub Bot commented on FLINK-6286:
---

Github user lingjinjiang commented on the issue:

https://github.com/apache/flink/pull/3711
  
@greghogan @zentol thanks. Can this pull request be merged or closed now ?


> hbase command not found error
> -
>
> Key: FLINK-6286
> URL: https://issues.apache.org/jira/browse/FLINK-6286
> Project: Flink
>  Issue Type: Bug
>  Components: Batch Connectors and Input/Output Formats, Startup Shell 
> Scripts
>Reporter: Jinjiang Ling
>Assignee: Jinjiang Ling
>Priority: Minor
> Attachments: FLINK-6286-0.patch, FLINK-6286-1.patch, 
> FLINK-6286-2.patch, FLINK-6286-3.patch
>
>
> As I'm using flink with the HBASE_CONF_DIR env variable and don't install 
> hbase, then I get the error message below.
> {quote}
> *bin/config.sh: line 303: hbase: command not found*
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6286) hbase command not found error

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972560#comment-15972560
 ] 

ASF GitHub Bot commented on FLINK-6286:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/3711
  
@lingjinjiang You are now the proud owner of contributor permissions and 
can assign issues to yourself.


> hbase command not found error
> -
>
> Key: FLINK-6286
> URL: https://issues.apache.org/jira/browse/FLINK-6286
> Project: Flink
>  Issue Type: Bug
>  Components: Batch Connectors and Input/Output Formats, Startup Shell 
> Scripts
>Reporter: Jinjiang Ling
>Assignee: Jinjiang Ling
>Priority: Minor
> Attachments: FLINK-6286-0.patch, FLINK-6286-1.patch, 
> FLINK-6286-2.patch, FLINK-6286-3.patch
>
>
> As I'm using flink with the HBASE_CONF_DIR env variable and don't install 
> hbase, then I get the error message below.
> {quote}
> *bin/config.sh: line 303: hbase: command not found*
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6286) hbase command not found error

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972554#comment-15972554
 ] 

ASF GitHub Bot commented on FLINK-6286:
---

Github user greghogan commented on the issue:

https://github.com/apache/flink/pull/3711
  
@fhueske can grant you Jira permissions.


> hbase command not found error
> -
>
> Key: FLINK-6286
> URL: https://issues.apache.org/jira/browse/FLINK-6286
> Project: Flink
>  Issue Type: Bug
>  Components: Batch Connectors and Input/Output Formats, Startup Shell 
> Scripts
>Reporter: Jinjiang Ling
>Priority: Minor
> Attachments: FLINK-6286-0.patch, FLINK-6286-1.patch, 
> FLINK-6286-2.patch, FLINK-6286-3.patch
>
>
> As I'm using flink with the HBASE_CONF_DIR env variable and don't install 
> hbase, then I get the error message below.
> {quote}
> *bin/config.sh: line 303: hbase: command not found*
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6286) hbase command not found error

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971920#comment-15971920
 ] 

ASF GitHub Bot commented on FLINK-6286:
---

Github user lingjinjiang commented on the issue:

https://github.com/apache/flink/pull/3711
  
@greghogan thanks for your review. I have another question, how can I 
assign the issue to myself ? 


> hbase command not found error
> -
>
> Key: FLINK-6286
> URL: https://issues.apache.org/jira/browse/FLINK-6286
> Project: Flink
>  Issue Type: Bug
>  Components: Batch Connectors and Input/Output Formats, Startup Shell 
> Scripts
>Reporter: Jinjiang Ling
>Priority: Minor
> Attachments: FLINK-6286-0.patch, FLINK-6286-1.patch, 
> FLINK-6286-2.patch, FLINK-6286-3.patch
>
>
> As I'm using flink with the HBASE_CONF_DIR env variable and don't install 
> hbase, then I get the error message below.
> {quote}
> *bin/config.sh: line 303: hbase: command not found*
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6286) hbase command not found error

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970355#comment-15970355
 ] 

ASF GitHub Bot commented on FLINK-6286:
---

Github user greghogan commented on the issue:

https://github.com/apache/flink/pull/3711
  
@lingjinjiang thanks for your contribution! Merging ...


> hbase command not found error
> -
>
> Key: FLINK-6286
> URL: https://issues.apache.org/jira/browse/FLINK-6286
> Project: Flink
>  Issue Type: Bug
>  Components: Batch Connectors and Input/Output Formats, Startup Shell 
> Scripts
>Reporter: Jinjiang Ling
>Priority: Minor
> Attachments: FLINK-6286-0.patch, FLINK-6286-1.patch, 
> FLINK-6286-2.patch, FLINK-6286-3.patch
>
>
> As I'm using flink with the HBASE_CONF_DIR env variable and don't install 
> hbase, then I get the error message below.
> {quote}
> *bin/config.sh: line 303: hbase: command not found*
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6286) hbase command not found error

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968481#comment-15968481
 ] 

ASF GitHub Bot commented on FLINK-6286:
---

Github user lingjinjiang commented on the issue:

https://github.com/apache/flink/pull/3711
  
@greghogan, thanks for your suggestion. I have changed the log message.


> hbase command not found error
> -
>
> Key: FLINK-6286
> URL: https://issues.apache.org/jira/browse/FLINK-6286
> Project: Flink
>  Issue Type: Bug
>  Components: Batch Connectors and Input/Output Formats, Startup Shell 
> Scripts
>Reporter: Jinjiang Ling
>Priority: Minor
> Attachments: FLINK-6286-0.patch, FLINK-6286-1.patch, 
> FLINK-6286-2.patch
>
>
> As I'm using flink with the HBASE_CONF_DIR env variable and don't install 
> hbase, then I get the error message below.
> {quote}
> *bin/config.sh: line 303: hbase: command not found*
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6286) hbase command not found error

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967622#comment-15967622
 ] 

ASF GitHub Bot commented on FLINK-6286:
---

Github user greghogan commented on a diff in the pull request:

https://github.com/apache/flink/pull/3711#discussion_r111397645
  
--- Diff: flink-dist/src/main/flink-bin/bin/config.sh ---
@@ -310,8 +310,16 @@ fi
 
INTERNAL_HADOOP_CLASSPATHS="${HADOOP_CLASSPATH}:${HADOOP_CONF_DIR}:${YARN_CONF_DIR}"
 
 if [ -n "${HBASE_CONF_DIR}" ]; then
-# Setup the HBase classpath.
-INTERNAL_HADOOP_CLASSPATHS="${INTERNAL_HADOOP_CLASSPATHS}:`hbase 
classpath`"
+# Search hbase command in PATH.
+HBASE_IN_PATH=$(PATH="${HBASE_HOME}/bin:$PATH" \
+which hbase 2>/dev/null)
+# Whether the hbase command is found.
+if [ -f "${HBASE_IN_PATH}" ]; then
+# The hbase command is found, then setup the HBase classpath.
+
INTERNAL_HADOOP_CLASSPATHS="${INTERNAL_HADOOP_CLASSPATHS}:`${HBASE_IN_PATH} 
classpath`"
+else
+echo "The HBASE_IN_PATH is setted but can't setup HBase classpath. 
Please verify hbase command exists."
--- End diff --

Perhaps more like "HBASE_CONF_DIR=\"${HBASE_CONF_DIR}\" is set but 'hbase' 
command was not found in \"${HBASE_PATH}\" so classpath could not be updated."? 
I assumed HBASE_PATH="${HBASE_HOME}/bin:$PATH" as a local variable.


> hbase command not found error
> -
>
> Key: FLINK-6286
> URL: https://issues.apache.org/jira/browse/FLINK-6286
> Project: Flink
>  Issue Type: Bug
>  Components: Batch Connectors and Input/Output Formats, Startup Shell 
> Scripts
>Reporter: Jinjiang Ling
>Priority: Minor
> Attachments: FLINK-6286-0.patch, FLINK-6286-1.patch, 
> FLINK-6286-2.patch
>
>
> As I'm using flink with the HBASE_CONF_DIR env variable and don't install 
> hbase, then I get the error message below.
> {quote}
> *bin/config.sh: line 303: hbase: command not found*
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6286) hbase command not found error

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967411#comment-15967411
 ] 

ASF GitHub Bot commented on FLINK-6286:
---

Github user lingjinjiang commented on the issue:

https://github.com/apache/flink/pull/3711
  
@greghogan , I add some comments and log the message about hbase command 
not found.


> hbase command not found error
> -
>
> Key: FLINK-6286
> URL: https://issues.apache.org/jira/browse/FLINK-6286
> Project: Flink
>  Issue Type: Bug
>  Components: Batch Connectors and Input/Output Formats, Startup Shell 
> Scripts
>Reporter: Jinjiang Ling
>Priority: Minor
> Attachments: FLINK-6286-0.patch, FLINK-6286-1.patch, 
> FLINK-6286-2.patch
>
>
> As I'm using flink with the HBASE_CONF_DIR env variable and don't install 
> hbase, then I get the error message below.
> {quote}
> *bin/config.sh: line 303: hbase: command not found*
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6286) hbase command not found error

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966152#comment-15966152
 ] 

ASF GitHub Bot commented on FLINK-6286:
---

Github user greghogan commented on the issue:

https://github.com/apache/flink/pull/3711
  
Would it be better to replace the outer if-statement (line 312) with the 
test for the presence of `hbase`? And to log a message that `HBASE_CONF_DIR` is 
defined but `hbase` was not found so no HBase jars are included on the 
classpath?


> hbase command not found error
> -
>
> Key: FLINK-6286
> URL: https://issues.apache.org/jira/browse/FLINK-6286
> Project: Flink
>  Issue Type: Bug
>  Components: Batch Connectors and Input/Output Formats, Startup Shell 
> Scripts
>Reporter: Jinjiang Ling
>Priority: Minor
> Attachments: FLINK-6286-0.patch, FLINK-6286-1.patch
>
>
> As I'm using flink with the HBASE_CONF_DIR env variable and don't install 
> hbase, then I get the error message below.
> {quote}
> *bin/config.sh: line 303: hbase: command not found*
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6286) hbase command not found error

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965966#comment-15965966
 ] 

ASF GitHub Bot commented on FLINK-6286:
---

Github user lingjinjiang commented on the issue:

https://github.com/apache/flink/pull/3711
  
Hi @greghogan , In the config.sh, there is a if statement identifies 
whether HBASE_CONF_DIR is setted.
If the HBASE_CONF_DIR is setted, then will use the "hbase classpath" 
command to add the hbase's classpath to flink's classpath.
But it does not  check whether  the "hbase" command is existed before using 
it. 
Then in the host where I'm using flink, another application need this env 
variable and there is no "hbase" command, then the error happen.


> hbase command not found error
> -
>
> Key: FLINK-6286
> URL: https://issues.apache.org/jira/browse/FLINK-6286
> Project: Flink
>  Issue Type: Bug
>Reporter: Jinjiang Ling
>Priority: Minor
> Attachments: FLINK-6286-0.patch, FLINK-6286-1.patch
>
>
> As I'm using flink with the HBASE_CONF_DIR env variable and don't install 
> hbase, then I get the error message below.
> {quote}
> *bin/config.sh: line 303: hbase: command not found*
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6286) hbase command not found error

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965821#comment-15965821
 ] 

ASF GitHub Bot commented on FLINK-6286:
---

Github user greghogan commented on the issue:

https://github.com/apache/flink/pull/3711
  
Hi @lingjinjiang, I am not familiar with configuring HBase for Flink and we 
don't seem to have documentation on this. What does it mean to have 
`HBASE_CONF_DIR` set but not have `hbase` available?


> hbase command not found error
> -
>
> Key: FLINK-6286
> URL: https://issues.apache.org/jira/browse/FLINK-6286
> Project: Flink
>  Issue Type: Bug
>Reporter: Jinjiang Ling
>Priority: Minor
> Attachments: FLINK-6286-0.patch, FLINK-6286-1.patch
>
>
> As I'm using flink with the HBASE_CONF_DIR env variable and don't install 
> hbase, then I get the error message below.
> {quote}
> *bin/config.sh: line 303: hbase: command not found*
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6286) hbase command not found error

[Jinjiang Ling (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965289#comment-15965289
 ] 

Jinjiang Ling commented on FLINK-6286:
--

Hi,[~greghogan], I have attach a patch and opened a pull request. Can you take 
a review?

> hbase command not found error
> -
>
> Key: FLINK-6286
> URL: https://issues.apache.org/jira/browse/FLINK-6286
> Project: Flink
>  Issue Type: Bug
>Reporter: Jinjiang Ling
>Priority: Minor
> Attachments: FLINK-6286-0.patch, FLINK-6286-1.patch
>
>
> As I'm using flink with the HBASE_CONF_DIR env variable and don't install 
> hbase, then I get the error message below.
> {quote}
> *bin/config.sh: line 303: hbase: command not found*
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6286) hbase command not found error

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965283#comment-15965283
 ] 

ASF GitHub Bot commented on FLINK-6286:
---

GitHub user lingjinjiang opened a pull request:

https://github.com/apache/flink/pull/3711

[FLINK-6286] [script] Fix the hbase command not found error

When using flink with the HBASE_CONF_DIR env variable and don't install 
hbase, then will get the "hbase command not found" error.

https://issues.apache.org/jira/browse/FLINK-6286

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lingjinjiang/flink master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/3711.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3711


commit f613e4b221bf4583574be11fe4c3fd5558290545
Author: lingjinjiang 
Date:   2017-04-12T02:53:52Z

[FLINK-6286] [script] Fix the hbase command not found error




> hbase command not found error
> -
>
> Key: FLINK-6286
> URL: https://issues.apache.org/jira/browse/FLINK-6286
> Project: Flink
>  Issue Type: Bug
>Reporter: Jinjiang Ling
>Priority: Minor
> Attachments: FLINK-6286-0.patch, FLINK-6286-1.patch
>
>
> As I'm using flink with the HBASE_CONF_DIR env variable and don't install 
> hbase, then I get the error message below.
> {quote}
> *bin/config.sh: line 303: hbase: command not found*
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6286) hbase command not found error

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965233#comment-15965233
 ] 

ASF GitHub Bot commented on FLINK-6286:
---

Github user lingjinjiang closed the pull request at:

https://github.com/apache/flink/pull/3705


> hbase command not found error
> -
>
> Key: FLINK-6286
> URL: https://issues.apache.org/jira/browse/FLINK-6286
> Project: Flink
>  Issue Type: Bug
>Reporter: Jinjiang Ling
>Priority: Minor
> Attachments: FLINK-6286-0.patch
>
>
> As I'm using flink with the HBASE_CONF_DIR env variable and don't install 
> hbase, then I get the error message below.
> {quote}
> *bin/config.sh: line 303: hbase: command not found*
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6286) hbase command not found error

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15962697#comment-15962697
 ] 

ASF GitHub Bot commented on FLINK-6286:
---

GitHub user lingjinjiang opened a pull request:

https://github.com/apache/flink/pull/3705

[FLINK-6286] Fix the hbase command not found error

Fix the hbase command not found error.
https://issues.apache.org/jira/browse/FLINK-6286

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lingjinjiang/flink master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/3705.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3705


commit 7cd62bedac81ce078ba0933722026f260ed2eedd
Author: lingjinjiang 
Date:   2017-04-10T10:50:50Z

[FLINK-6286] Fix the hbase command not found error




> hbase command not found error
> -
>
> Key: FLINK-6286
> URL: https://issues.apache.org/jira/browse/FLINK-6286
> Project: Flink
>  Issue Type: Bug
>Reporter: Jinjiang Ling
>Priority: Minor
> Attachments: FLINK-6286-0.patch
>
>
> As I'm using flink where set the HBASE_CONF_DIR env variable and don't 
> install hbase. Then I get the error message below.
> {quote}
> *bin/config.sh: line 303: hbase: command not found*
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)