[jira] [Commented] (FLINK-7134) Remove hadoop1.x code in mapreduce.utils.HadoopUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105236#comment-16105236
 ] 

ASF GitHub Bot commented on FLINK-7134:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/4362


> Remove hadoop1.x code in mapreduce.utils.HadoopUtils
> 
>
> Key: FLINK-7134
> URL: https://issues.apache.org/jira/browse/FLINK-7134
> Project: Flink
>  Issue Type: Improvement
>  Components: Java API
>Reporter: mingleizhang
>Assignee: mingleizhang
> Fix For: 1.4.0
>
>
> This jira is similar to FLINK-7118. And for a clearer format and a review, I 
> separated the two jira.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7134) Remove hadoop1.x code in mapreduce.utils.HadoopUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094119#comment-16094119
 ] 

ASF GitHub Bot commented on FLINK-7134:
---

Github user zhangminglei commented on the issue:

https://github.com/apache/flink/pull/4362
  
Hey, Stephan. This time codes works well. Thanks ~ :)


> Remove hadoop1.x code in mapreduce.utils.HadoopUtils
> 
>
> Key: FLINK-7134
> URL: https://issues.apache.org/jira/browse/FLINK-7134
> Project: Flink
>  Issue Type: Improvement
>  Components: Java API
>Reporter: mingleizhang
>Assignee: mingleizhang
>
> This jira is similar to FLINK-7118. And for a clearer format and a review, I 
> separated the two jira.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7134) Remove hadoop1.x code in mapreduce.utils.HadoopUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094117#comment-16094117
 ] 

ASF GitHub Bot commented on FLINK-7134:
---

Github user zhangminglei commented on a diff in the pull request:

https://github.com/apache/flink/pull/4362#discussion_r128417549
  
--- Diff: 
flink-connectors/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatInputFormatBase.java
 ---
@@ -271,7 +273,7 @@ public BaseStatistics getStatistics(BaseStatistics 
cachedStats) throws IOExcepti
 
JobContext jobContext = null;
try {
-   jobContext = 
HadoopUtils.instantiateJobContext(configuration, new JobID());
+   jobContext = new JobContextImpl(configuration, new 
JobID());
--- End diff --

Sorry. Stephan. I just forgot about it. 


> Remove hadoop1.x code in mapreduce.utils.HadoopUtils
> 
>
> Key: FLINK-7134
> URL: https://issues.apache.org/jira/browse/FLINK-7134
> Project: Flink
>  Issue Type: Improvement
>  Components: Java API
>Reporter: mingleizhang
>Assignee: mingleizhang
>
> This jira is similar to FLINK-7118. And for a clearer format and a review, I 
> separated the two jira.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7134) Remove hadoop1.x code in mapreduce.utils.HadoopUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093454#comment-16093454
 ] 

ASF GitHub Bot commented on FLINK-7134:
---

Github user StephanEwen commented on a diff in the pull request:

https://github.com/apache/flink/pull/4362#discussion_r128310731
  
--- Diff: 
flink-connectors/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatInputFormatBase.java
 ---
@@ -271,7 +273,7 @@ public BaseStatistics getStatistics(BaseStatistics 
cachedStats) throws IOExcepti
 
JobContext jobContext = null;
try {
-   jobContext = 
HadoopUtils.instantiateJobContext(configuration, new JobID());
+   jobContext = new JobContextImpl(configuration, new 
JobID());
--- End diff --

We can remove the try/catch block here...


> Remove hadoop1.x code in mapreduce.utils.HadoopUtils
> 
>
> Key: FLINK-7134
> URL: https://issues.apache.org/jira/browse/FLINK-7134
> Project: Flink
>  Issue Type: Improvement
>  Components: Java API
>Reporter: mingleizhang
>Assignee: mingleizhang
>
> This jira is similar to FLINK-7118. And for a clearer format and a review, I 
> separated the two jira.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7134) Remove hadoop1.x code in mapreduce.utils.HadoopUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093455#comment-16093455
 ] 

ASF GitHub Bot commented on FLINK-7134:
---

Github user StephanEwen commented on a diff in the pull request:

https://github.com/apache/flink/pull/4362#discussion_r128310762
  
--- Diff: 
flink-connectors/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatInputFormatBase.java
 ---
@@ -299,7 +301,7 @@ public InputSplitAssigner 
getInputSplitAssigner(HadoopInputSplit[] inputSplits)
public void open(HadoopInputSplit split) throws IOException {
TaskAttemptContext context = null;
try {
-   context = 
HadoopUtils.instantiateTaskAttemptContext(configuration, new TaskAttemptID());
+   context = new TaskAttemptContextImpl(configuration, new 
TaskAttemptID());
--- End diff --

Same as above...


> Remove hadoop1.x code in mapreduce.utils.HadoopUtils
> 
>
> Key: FLINK-7134
> URL: https://issues.apache.org/jira/browse/FLINK-7134
> Project: Flink
>  Issue Type: Improvement
>  Components: Java API
>Reporter: mingleizhang
>Assignee: mingleizhang
>
> This jira is similar to FLINK-7118. And for a clearer format and a review, I 
> separated the two jira.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7134) Remove hadoop1.x code in mapreduce.utils.HadoopUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092482#comment-16092482
 ] 

ASF GitHub Bot commented on FLINK-7134:
---

GitHub user zhangminglei opened a pull request:

https://github.com/apache/flink/pull/4362

[FLINK-7134] Remove hadoop1.x code in mapreduce.utils.HadoopUtils



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zhangminglei/flink flink-7134

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4362.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4362


commit 65d264fee5d15c6960e480c39b33886766171c08
Author: zhangminglei 
Date:   2017-07-19T02:15:16Z

[FLINK-7134] Remove hadoop1.x code in mapreduce.utils.HadoopUtils




> Remove hadoop1.x code in mapreduce.utils.HadoopUtils
> 
>
> Key: FLINK-7134
> URL: https://issues.apache.org/jira/browse/FLINK-7134
> Project: Flink
>  Issue Type: Improvement
>  Components: Java API
>Reporter: mingleizhang
>Assignee: mingleizhang
>
> This jira is similar to FLINK-7118. And for a clearer format and a review, I 
> separated the two jira.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7134) Remove hadoop1.x code in mapreduce.utils.HadoopUtils

[mingleizhang (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092465#comment-16092465
 ] 

mingleizhang commented on FLINK-7134:
-

I will work on this soon enough.

> Remove hadoop1.x code in mapreduce.utils.HadoopUtils
> 
>
> Key: FLINK-7134
> URL: https://issues.apache.org/jira/browse/FLINK-7134
> Project: Flink
>  Issue Type: Improvement
>  Components: Java API
>Reporter: mingleizhang
>Assignee: mingleizhang
>
> This jira is similar to FLINK-7118. And for a clearer format and a review, I 
> separated the two jira.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)