[jira] [Commented] (FLINK-7803) Update savepoint Documentation
[ https://issues.apache.org/jira/browse/FLINK-7803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470266#comment-16470266 ] ASF GitHub Bot commented on FLINK-7803: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4809 > Update savepoint Documentation > -- > > Key: FLINK-7803 > URL: https://issues.apache.org/jira/browse/FLINK-7803 > Project: Flink > Issue Type: Improvement > Components: Documentation, State Backends, Checkpointing >Affects Versions: 1.4.0, 1.5.0 >Reporter: Razvan >Assignee: Razvan >Priority: Major > Fix For: 1.5.0 > > > Can you please update > https://ci.apache.org/projects/flink/flink-docs-release-1.3/setup/savepoints.html > to specify the savepoint location *MUST* always be a location accessible by > all hosts? > I spent quite some time believing it'S a bug and trying to find solutions, > see https://issues.apache.org/jira/browse/FLINK-7750. It's not obvious in the > current documentation and other might waste time also believing it's an > actual issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-7803) Update savepoint Documentation
[ https://issues.apache.org/jira/browse/FLINK-7803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407887#comment-16407887 ] ASF GitHub Bot commented on FLINK-7803: --- Github user zentol commented on the issue: https://github.com/apache/flink/pull/4809 @razvan100 I've merged the PR, could you close it? > Update savepoint Documentation > -- > > Key: FLINK-7803 > URL: https://issues.apache.org/jira/browse/FLINK-7803 > Project: Flink > Issue Type: Improvement > Components: Documentation, State Backends, Checkpointing >Affects Versions: 1.4.0, 1.5.0 >Reporter: Razvan >Assignee: Razvan >Priority: Major > Fix For: 1.5.0 > > > Can you please update > https://ci.apache.org/projects/flink/flink-docs-release-1.3/setup/savepoints.html > to specify the savepoint location *MUST* always be a location accessible by > all hosts? > I spent quite some time believing it'S a bug and trying to find solutions, > see https://issues.apache.org/jira/browse/FLINK-7750. It's not obvious in the > current documentation and other might waste time also believing it's an > actual issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-7803) Update savepoint Documentation
[ https://issues.apache.org/jira/browse/FLINK-7803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356793#comment-16356793 ] ASF GitHub Bot commented on FLINK-7803: --- Github user GJL commented on the issue: https://github.com/apache/flink/pull/4809 Thank you @zentol > Update savepoint Documentation > -- > > Key: FLINK-7803 > URL: https://issues.apache.org/jira/browse/FLINK-7803 > Project: Flink > Issue Type: Improvement > Components: Documentation, State Backends, Checkpointing >Affects Versions: 1.4.0, 1.5.0 >Reporter: Razvan >Assignee: Razvan >Priority: Major > Fix For: 1.5.0 > > > Can you please update > https://ci.apache.org/projects/flink/flink-docs-release-1.3/setup/savepoints.html > to specify the savepoint location *MUST* always be a location accessible by > all hosts? > I spent quite some time believing it'S a bug and trying to find solutions, > see https://issues.apache.org/jira/browse/FLINK-7750. It's not obvious in the > current documentation and other might waste time also believing it's an > actual issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-7803) Update savepoint Documentation
[ https://issues.apache.org/jira/browse/FLINK-7803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353582#comment-16353582 ] ASF GitHub Bot commented on FLINK-7803: --- Github user zentol commented on the issue: https://github.com/apache/flink/pull/4809 will merge this while addressing the comments > Update savepoint Documentation > -- > > Key: FLINK-7803 > URL: https://issues.apache.org/jira/browse/FLINK-7803 > Project: Flink > Issue Type: Bug > Components: Documentation >Reporter: Razvan >Assignee: Razvan >Priority: Major > > Can you please update > https://ci.apache.org/projects/flink/flink-docs-release-1.3/setup/savepoints.html > to specify the savepoint location *MUST* always be a location accessible by > all hosts? > I spent quite some time believing it'S a bug and trying to find solutions, > see https://issues.apache.org/jira/browse/FLINK-7750. It's not obvious in the > current documentation and other might waste time also believing it's an > actual issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-7803) Update savepoint Documentation
[ https://issues.apache.org/jira/browse/FLINK-7803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352541#comment-16352541 ] ASF GitHub Bot commented on FLINK-7803: --- Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/4809#discussion_r166008336 --- Diff: docs/ops/state/savepoints.md --- @@ -120,6 +120,10 @@ This will atomically trigger a savepoint for the job with ID `:jobid` and cancel If you don't specify a target directory, you need to have [configured a default directory](#configuration). Otherwise, cancelling the job with a savepoint will fail. + --- End diff -- 👍 > Update savepoint Documentation > -- > > Key: FLINK-7803 > URL: https://issues.apache.org/jira/browse/FLINK-7803 > Project: Flink > Issue Type: Bug > Components: Documentation >Reporter: Razvan >Assignee: Razvan >Priority: Major > > Can you please update > https://ci.apache.org/projects/flink/flink-docs-release-1.3/setup/savepoints.html > to specify the savepoint location *MUST* always be a location accessible by > all hosts? > I spent quite some time believing it'S a bug and trying to find solutions, > see https://issues.apache.org/jira/browse/FLINK-7750. It's not obvious in the > current documentation and other might waste time also believing it's an > actual issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-7803) Update savepoint Documentation
[ https://issues.apache.org/jira/browse/FLINK-7803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352524#comment-16352524 ] ASF GitHub Bot commented on FLINK-7803: --- Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4809#discussion_r166001086 --- Diff: docs/ops/state/savepoints.md --- @@ -120,6 +120,10 @@ This will atomically trigger a savepoint for the job with ID `:jobid` and cancel If you don't specify a target directory, you need to have [configured a default directory](#configuration). Otherwise, cancelling the job with a savepoint will fail. + --- End diff -- Should be something like: ``` Attention: targetDirectory has to be a location accessible by both the JobManager(s) and TaskManager(s), e.g., a location on a distributed file system. ``` because markdown is not rendered within HTML tags. Also, the *warning* you have added is currently in the *Cancel Job with Savepoint* section. I think it should be moved to the section above (*Trigger a Savepoint*), or somewhere else since it does not only apply to the cancelation case. @uce > Update savepoint Documentation > -- > > Key: FLINK-7803 > URL: https://issues.apache.org/jira/browse/FLINK-7803 > Project: Flink > Issue Type: Bug > Components: Documentation >Reporter: Razvan >Assignee: Razvan >Priority: Major > > Can you please update > https://ci.apache.org/projects/flink/flink-docs-release-1.3/setup/savepoints.html > to specify the savepoint location *MUST* always be a location accessible by > all hosts? > I spent quite some time believing it'S a bug and trying to find solutions, > see https://issues.apache.org/jira/browse/FLINK-7750. It's not obvious in the > current documentation and other might waste time also believing it's an > actual issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-7803) Update savepoint Documentation
[ https://issues.apache.org/jira/browse/FLINK-7803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16202327#comment-16202327 ] ASF GitHub Bot commented on FLINK-7803: --- Github user razvan100 commented on the issue: https://github.com/apache/flink/pull/4809 Okay, so if you account for it in the review then I don't need to make another empty commit. Thanks! > Update savepoint Documentation > -- > > Key: FLINK-7803 > URL: https://issues.apache.org/jira/browse/FLINK-7803 > Project: Flink > Issue Type: Bug > Components: Documentation >Reporter: Razvan >Assignee: Razvan > > Can you please update > https://ci.apache.org/projects/flink/flink-docs-release-1.3/setup/savepoints.html > to specify the savepoint location *MUST* always be a location accessible by > all hosts? > I spent quite some time believing it'S a bug and trying to find solutions, > see https://issues.apache.org/jira/browse/FLINK-7750. It's not obvious in the > current documentation and other might waste time also believing it's an > actual issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7803) Update savepoint Documentation
[ https://issues.apache.org/jira/browse/FLINK-7803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16201972#comment-16201972 ] ASF GitHub Bot commented on FLINK-7803: --- Github user zentol commented on the issue: https://github.com/apache/flink/pull/4809 @razvan100 You can re-trigger the build by adding a new commit (even en empty one). However, please don't do this for the sake of achieving a picture perfect build (in particular for documentation changes which can't affect the build anyway); we are aware of certain test instabilities and account for those in the review. As for reviewers, you cannot explicitly request a review. You can mention committers if (as you did with aljoscha) but I would ask you to refrain from doing so unless absolutely necessary. > Update savepoint Documentation > -- > > Key: FLINK-7803 > URL: https://issues.apache.org/jira/browse/FLINK-7803 > Project: Flink > Issue Type: Bug > Components: Documentation >Reporter: Razvan >Assignee: Razvan > > Can you please update > https://ci.apache.org/projects/flink/flink-docs-release-1.3/setup/savepoints.html > to specify the savepoint location *MUST* always be a location accessible by > all hosts? > I spent quite some time believing it'S a bug and trying to find solutions, > see https://issues.apache.org/jira/browse/FLINK-7750. It's not obvious in the > current documentation and other might waste time also believing it's an > actual issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7803) Update savepoint Documentation
[ https://issues.apache.org/jira/browse/FLINK-7803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16201770#comment-16201770 ] ASF GitHub Bot commented on FLINK-7803: --- Github user razvan100 commented on the issue: https://github.com/apache/flink/pull/4809 @aljoscha Hi, do you know if it's possible to retrigger the build? Don't believe it fails because of my change. Also, how can I add reviewers? Thanks! > Update savepoint Documentation > -- > > Key: FLINK-7803 > URL: https://issues.apache.org/jira/browse/FLINK-7803 > Project: Flink > Issue Type: Bug > Components: Documentation >Reporter: Razvan >Assignee: Razvan > > Can you please update > https://ci.apache.org/projects/flink/flink-docs-release-1.3/setup/savepoints.html > to specify the savepoint location *MUST* always be a location accessible by > all hosts? > I spent quite some time believing it'S a bug and trying to find solutions, > see https://issues.apache.org/jira/browse/FLINK-7750. It's not obvious in the > current documentation and other might waste time also believing it's an > actual issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7803) Update savepoint Documentation
[ https://issues.apache.org/jira/browse/FLINK-7803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200655#comment-16200655 ] ASF GitHub Bot commented on FLINK-7803: --- Github user razvan100 closed the pull request at: https://github.com/apache/flink/pull/4808 > Update savepoint Documentation > -- > > Key: FLINK-7803 > URL: https://issues.apache.org/jira/browse/FLINK-7803 > Project: Flink > Issue Type: Bug > Components: Documentation >Reporter: Razvan >Assignee: Razvan > > Can you please update > https://ci.apache.org/projects/flink/flink-docs-release-1.3/setup/savepoints.html > to specify the savepoint location *MUST* always be a location accessible by > all hosts? > I spent quite some time believing it'S a bug and trying to find solutions, > see https://issues.apache.org/jira/browse/FLINK-7750. It's not obvious in the > current documentation and other might waste time also believing it's an > actual issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7803) Update savepoint Documentation
[ https://issues.apache.org/jira/browse/FLINK-7803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200652#comment-16200652 ] ASF GitHub Bot commented on FLINK-7803: --- GitHub user razvan100 opened a pull request: https://github.com/apache/flink/pull/4809 [FLINK-7803][Documentation] Add missing savepoint information This fixes FLINK-7803 by emphasizing the savepoint save location should be on a distributed file-system. You can merge this pull request into a Git repository by running: $ git pull https://github.com/razvan100/flink patch-3 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4809.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4809 commit a3fa67e0dbc3498a5a916dbe1f7702366d793867 Author: Razvan Date: 2017-10-11T17:38:50Z [FLINK-7803] Add missing savepoint information This fixes FLINK-7803 by emphasizing the savepoint save location should be on a distributed file-system. > Update savepoint Documentation > -- > > Key: FLINK-7803 > URL: https://issues.apache.org/jira/browse/FLINK-7803 > Project: Flink > Issue Type: Bug > Components: Documentation >Reporter: Razvan >Assignee: Razvan > > Can you please update > https://ci.apache.org/projects/flink/flink-docs-release-1.3/setup/savepoints.html > to specify the savepoint location *MUST* always be a location accessible by > all hosts? > I spent quite some time believing it'S a bug and trying to find solutions, > see https://issues.apache.org/jira/browse/FLINK-7750. It's not obvious in the > current documentation and other might waste time also believing it's an > actual issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7803) Update savepoint Documentation
[ https://issues.apache.org/jira/browse/FLINK-7803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200626#comment-16200626 ] ASF GitHub Bot commented on FLINK-7803: --- GitHub user razvan100 opened a pull request: https://github.com/apache/flink/pull/4808 [FLINK-7803][Documentation] Add missing information about savepoint location FLINK-7803 FLINK-7750 *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.* *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.* ## Contribution Checklist - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue. - Name the pull request in the form "[FLINK-] [component] Title of the pull request", where *FLINK-* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component. Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`. - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review. - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](http://flink.apache.org/contribute-code.html#best-practices). - Each pull request should address only one issue, not mix up code from multiple issues. - Each commit in the pull request has a meaningful commit message (including the JIRA id) - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below. **(The sections below can be removed for hotfixes of typos)** ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)* ## Brief change log *(for example:)* - *The TaskInfo is stored in the blob store on job creation time as a persistent artifact* - *Deployments RPC transmits only the blob storage reference* - *TaskManagers retrieve the TaskInfo from the blob cache* ## Verifying this change *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment with large payloads (100MB)* - *Extended integration test for recovery after master (JobManager) failure* - *Added test that validates that TaskInfo is transferred only once across recoveries* - *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no) - The serializers: (yes / no / don't know) - The runtime per-record code paths (performance sensitive): (yes / no / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / no) - If yes, how is the feature documented? (not applicable / docs /
