[jira] [Commented] (FLINK-7984) Bump snappy-java to 1.1.4
[ https://issues.apache.org/jira/browse/FLINK-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352458#comment-16352458 ] ASF GitHub Bot commented on FLINK-7984: --- Github user yew1eb closed the pull request at: https://github.com/apache/flink/pull/5072 > Bump snappy-java to 1.1.4 > - > > Key: FLINK-7984 > URL: https://issues.apache.org/jira/browse/FLINK-7984 > Project: Flink > Issue Type: Improvement > Components: Build System >Affects Versions: 1.4.0 >Reporter: Hai Zhou UTC+8 >Assignee: Hai Zhou UTC+8 >Priority: Major > Fix For: 1.5.0 > > > Upgrade the snappy java version to 1.1.4(the latest, May, 2017). The older > version has some issues like memory leak > (https://github.com/xerial/snappy-java/issues/91). > Snappy Java [Release > Notes|https://github.com/xerial/snappy-java/blob/master/Milestone.md] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-7984) Bump snappy-java to 1.1.4
[ https://issues.apache.org/jira/browse/FLINK-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352409#comment-16352409 ] ASF GitHub Bot commented on FLINK-7984: --- Github user zentol commented on the issue: https://github.com/apache/flink/pull/5072 @yew1eb Could you close the PR? The issue was addressed in f1e4d25c11a678688064492d50ffad38c39ea877. > Bump snappy-java to 1.1.4 > - > > Key: FLINK-7984 > URL: https://issues.apache.org/jira/browse/FLINK-7984 > Project: Flink > Issue Type: Improvement > Components: Build System >Affects Versions: 1.4.0 >Reporter: Hai Zhou UTC+8 >Assignee: Hai Zhou UTC+8 >Priority: Major > Fix For: 1.5.0 > > > Upgrade the snappy java version to 1.1.4(the latest, May, 2017). The older > version has some issues like memory leak > (https://github.com/xerial/snappy-java/issues/91). > Snappy Java [Release > Notes|https://github.com/xerial/snappy-java/blob/master/Milestone.md] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-7984) Bump snappy-java to 1.1.4
[ https://issues.apache.org/jira/browse/FLINK-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293010#comment-16293010 ] ASF GitHub Bot commented on FLINK-7984: --- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5072 Sorry, actually, taking a step back: Can you check in which dependencies snappy is included in addition? Especially big packaged dependencies like `flink-s3-fs-presto` and `flink-s3-fs-hadoop`? In case they contain snappy, we should manage the dependency to the same version there. If two different versions get pulled in, the update may not have an effect. > Bump snappy-java to 1.1.4 > - > > Key: FLINK-7984 > URL: https://issues.apache.org/jira/browse/FLINK-7984 > Project: Flink > Issue Type: Improvement > Components: Build System >Affects Versions: 1.4.0 >Reporter: Hai Zhou UTC+8 >Assignee: Hai Zhou UTC+8 > Fix For: 1.5.0 > > > Upgrade the snappy java version to 1.1.4(the latest, May, 2017). The older > version has some issues like memory leak > (https://github.com/xerial/snappy-java/issues/91). > Snappy Java [Release > Notes|https://github.com/xerial/snappy-java/blob/master/Milestone.md] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7984) Bump snappy-java to 1.1.4
[ https://issues.apache.org/jira/browse/FLINK-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292632#comment-16292632 ] ASF GitHub Bot commented on FLINK-7984: --- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5072 Merging this... > Bump snappy-java to 1.1.4 > - > > Key: FLINK-7984 > URL: https://issues.apache.org/jira/browse/FLINK-7984 > Project: Flink > Issue Type: Improvement > Components: Build System >Affects Versions: 1.4.0 >Reporter: Hai Zhou UTC+8 >Assignee: Hai Zhou UTC+8 > Fix For: 1.5.0 > > > Upgrade the snappy java version to 1.1.4(the latest, May, 2017). The older > version has some issues like memory leak > (https://github.com/xerial/snappy-java/issues/91). > Snappy Java [Release > Notes|https://github.com/xerial/snappy-java/blob/master/Milestone.md] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7984) Bump snappy-java to 1.1.4
[ https://issues.apache.org/jira/browse/FLINK-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292628#comment-16292628 ] ASF GitHub Bot commented on FLINK-7984: --- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5072 Bumping the version should be fine. We only need to make sure that wherever this is pulled, we promote it to a direct dependency such that dependency convergence works. > Bump snappy-java to 1.1.4 > - > > Key: FLINK-7984 > URL: https://issues.apache.org/jira/browse/FLINK-7984 > Project: Flink > Issue Type: Improvement > Components: Build System >Affects Versions: 1.4.0 >Reporter: Hai Zhou UTC+8 >Assignee: Hai Zhou UTC+8 > Fix For: 1.5.0 > > > Upgrade the snappy java version to 1.1.4(the latest, May, 2017). The older > version has some issues like memory leak > (https://github.com/xerial/snappy-java/issues/91). > Snappy Java [Release > Notes|https://github.com/xerial/snappy-java/blob/master/Milestone.md] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7984) Bump snappy-java to 1.1.4
[ https://issues.apache.org/jira/browse/FLINK-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283716#comment-16283716 ] ASF GitHub Bot commented on FLINK-7984: --- Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/5072 @greghogan, I saw the following in the `flink-core` POM: ``` org.xerial.snappy snappy-java ``` I think this PR just upgrades the snappy-java version from 1.1.1.3 to 1.1.4 for the "flink-core" module. I can not find out what bad effects it will cause.:) > Bump snappy-java to 1.1.4 > - > > Key: FLINK-7984 > URL: https://issues.apache.org/jira/browse/FLINK-7984 > Project: Flink > Issue Type: Improvement > Components: Build System >Affects Versions: 1.4.0 >Reporter: Hai Zhou UTC+8 >Assignee: Hai Zhou UTC+8 > Fix For: 1.5.0 > > > Upgrade the snappy java version to 1.1.4(the latest, May, 2017). The older > version has some issues like memory leak > (https://github.com/xerial/snappy-java/issues/91). > Snappy Java [Release > Notes|https://github.com/xerial/snappy-java/blob/master/Milestone.md] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7984) Bump snappy-java to 1.1.4
[ https://issues.apache.org/jira/browse/FLINK-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282466#comment-16282466 ] ASF GitHub Bot commented on FLINK-7984: --- Github user greghogan commented on the issue: https://github.com/apache/flink/pull/5072 @yew1eb have you looked at FLINK-6965? > Bump snappy-java to 1.1.4 > - > > Key: FLINK-7984 > URL: https://issues.apache.org/jira/browse/FLINK-7984 > Project: Flink > Issue Type: Improvement > Components: Build System >Affects Versions: 1.4.0 >Reporter: Hai Zhou UTC+8 >Assignee: Hai Zhou UTC+8 > Fix For: 1.5.0 > > > Upgrade the snappy java version to 1.1.4(the latest, May, 2017). The older > version has some issues like memory leak > (https://github.com/xerial/snappy-java/issues/91). > Snappy Java [Release > Notes|https://github.com/xerial/snappy-java/blob/master/Milestone.md] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7984) Bump snappy-java to 1.1.4
[ https://issues.apache.org/jira/browse/FLINK-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266089#comment-16266089 ] ASF GitHub Bot commented on FLINK-7984: --- GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/5072 [FLINK-7984][build] Bump snappy-java to 1.1.4 ## What is the purpose of the change This PR bumps the snappy-java version to 1.1.14. snappy-java-1.1.4 (2017-05-22): - Fix a 1% performance regression when snappy is used in PIE executables. - Improve compression performance by 5%. - Improve decompression performance by 20%. - See more: [Snappy-java Release Notes](https://github.com/xerial/snappy-java/blob/master/Milestone.md) ## Verifying this change This change should be covered by travis and the end-to-end tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yew1eb/flink FLINK-7984 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5072.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5072 commit b67f71fc252075d21ce64d5d8b474fac5e4c85a5 Author: yew1ebDate: 2017-11-19T18:03:19Z [FLINK-7984][build] Bump snappy-java to 1.1.4 > Bump snappy-java to 1.1.4 > - > > Key: FLINK-7984 > URL: https://issues.apache.org/jira/browse/FLINK-7984 > Project: Flink > Issue Type: Improvement > Components: Build System >Affects Versions: 1.4.0 >Reporter: Hai Zhou UTC+8 >Assignee: Hai Zhou UTC+8 > Fix For: 1.5.0 > > > Upgrade the snappy java version to 1.1.4(the latest, May, 2017). The older > version has some issues like memory leak > (https://github.com/xerial/snappy-java/issues/91). > Snappy Java [Release > Notes|https://github.com/xerial/snappy-java/blob/master/Milestone.md] -- This message was sent by Atlassian JIRA (v6.4.14#64029)