[jira] [Commented] (FLINK-8079) Skip remaining E2E tests if one failed

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-8079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337454#comment-16337454
 ] 

ASF GitHub Bot commented on FLINK-8079:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/5156


> Skip remaining E2E tests if one failed
> --
>
> Key: FLINK-8079
> URL: https://issues.apache.org/jira/browse/FLINK-8079
> Project: Flink
>  Issue Type: Improvement
>  Components: Tests
>Affects Versions: 1.4.0, 1.5.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Major
> Fix For: 1.5.0, 1.4.1
>
>
> I propose that if one end-to-end tests fails the remaining tests are skipped.
> [~aljoscha] What do you think?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8079) Skip remaining E2E tests if one failed

2018-01-24 Thread Chesnay Schepler (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-8079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337451#comment-16337451
 ] 

Chesnay Schepler commented on FLINK-8079:
-

master: dcacdb9161a7bae67203460c5ac34b64286fc535

> Skip remaining E2E tests if one failed
> --
>
> Key: FLINK-8079
> URL: https://issues.apache.org/jira/browse/FLINK-8079
> Project: Flink
>  Issue Type: Improvement
>  Components: Tests
>Affects Versions: 1.4.0, 1.5.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Major
> Fix For: 1.5.0, 1.4.1
>
>
> I propose that if one end-to-end tests fails the remaining tests are skipped.
> [~aljoscha] What do you think?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8079) Skip remaining E2E tests if one failed

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-8079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337272#comment-16337272
 ] 

ASF GitHub Bot commented on FLINK-8079:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/5156
  
merging.


> Skip remaining E2E tests if one failed
> --
>
> Key: FLINK-8079
> URL: https://issues.apache.org/jira/browse/FLINK-8079
> Project: Flink
>  Issue Type: Improvement
>  Components: Tests
>Affects Versions: 1.4.0, 1.5.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Major
> Fix For: 1.5.0, 1.4.1
>
>
> I propose that if one end-to-end tests fails the remaining tests are skipped.
> [~aljoscha] What do you think?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8079) Skip remaining E2E tests if one failed

2018-01-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-8079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316376#comment-16316376
 ] 

ASF GitHub Bot commented on FLINK-8079:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/5156
  
@greghogan good point, I'll adjust that part as well to combine the error 
codes of both checks. We don't have to fail immediately after one fails since 
nothing is printed if the check succeeds.


> Skip remaining E2E tests if one failed
> --
>
> Key: FLINK-8079
> URL: https://issues.apache.org/jira/browse/FLINK-8079
> Project: Flink
>  Issue Type: Improvement
>  Components: Tests
>Affects Versions: 1.4.0, 1.5.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
> Fix For: 1.5.0, 1.4.1
>
>
> I propose that if one end-to-end tests fails the remaining tests are skipped.
> [~aljoscha] What do you think?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-8079) Skip remaining E2E tests if one failed

2018-01-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-8079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316347#comment-16316347
 ] 

ASF GitHub Bot commented on FLINK-8079:
---

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/5156#discussion_r160148368
  
--- Diff: tools/travis_mvn_watchdog.sh ---
@@ -543,35 +543,45 @@ case $TEST in
printf "Running end-to-end tests\n"
printf 
"==\n"
 
-   printf 
"\n==\n"
-   printf "Running Wordcount end-to-end test\n"
-   printf 
"==\n"
-   FLINK_DIR=build-target CLUSTER_MODE=cluster 
test-infra/end-to-end-test/test_batch_wordcount.sh
-   EXIT_CODE=$(($EXIT_CODE+$?))
-
-   printf 
"\n==\n"
-   printf "Running Kafka end-to-end test\n"
-   printf 
"==\n"
-   FLINK_DIR=build-target CLUSTER_MODE=cluster 
test-infra/end-to-end-test/test_streaming_kafka010.sh
-   EXIT_CODE=$(($EXIT_CODE+$?))
-
-   printf 
"\n==\n"
-   printf "Running class loading end-to-end test\n"
-   printf 
"==\n"
-   FLINK_DIR=build-target CLUSTER_MODE=cluster 
test-infra/end-to-end-test/test_streaming_classloader.sh
-   EXIT_CODE=$(($EXIT_CODE+$?))
-
-   printf 
"\n==\n"
-   printf "Running Shaded Hadoop S3A end-to-end test\n"
-   printf 
"==\n"
-   FLINK_DIR=build-target CLUSTER_MODE=cluster 
test-infra/end-to-end-test/test_shaded_hadoop_s3a.sh
-   EXIT_CODE=$(($EXIT_CODE+$?))
-
-   printf 
"\n==\n"
-   printf "Running Shaded Presto S3 end-to-end test\n"
-   printf 
"==\n"
-   FLINK_DIR=build-target CLUSTER_MODE=cluster 
test-infra/end-to-end-test/test_shaded_presto_s3.sh
-   EXIT_CODE=$(($EXIT_CODE+$?))
+   if [ $EXIT_CODE == 0 ]; then
+   printf 
"\n==\n"
+   printf "Running Wordcount end-to-end test\n"
+   printf 
"==\n"
+   FLINK_DIR=build-target CLUSTER_MODE=cluster 
test-infra/end-to-end-test/test_batch_wordcount.sh
+   EXIT_CODE=$(($EXIT_CODE+$?))
--- End diff --

jup we can simplify things now.


> Skip remaining E2E tests if one failed
> --
>
> Key: FLINK-8079
> URL: https://issues.apache.org/jira/browse/FLINK-8079
> Project: Flink
>  Issue Type: Improvement
>  Components: Tests
>Affects Versions: 1.4.0, 1.5.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
> Fix For: 1.5.0, 1.4.1
>
>
> I propose that if one end-to-end tests fails the remaining tests are skipped.
> [~aljoscha] What do you think?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-8079) Skip remaining E2E tests if one failed

2017-12-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-8079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298598#comment-16298598
 ] 

ASF GitHub Bot commented on FLINK-8079:
---

Github user greghogan commented on a diff in the pull request:

https://github.com/apache/flink/pull/5156#discussion_r158037581
  
--- Diff: tools/travis_mvn_watchdog.sh ---
@@ -543,35 +543,45 @@ case $TEST in
printf "Running end-to-end tests\n"
printf 
"==\n"
 
-   printf 
"\n==\n"
-   printf "Running Wordcount end-to-end test\n"
-   printf 
"==\n"
-   FLINK_DIR=build-target CLUSTER_MODE=cluster 
test-infra/end-to-end-test/test_batch_wordcount.sh
-   EXIT_CODE=$(($EXIT_CODE+$?))
-
-   printf 
"\n==\n"
-   printf "Running Kafka end-to-end test\n"
-   printf 
"==\n"
-   FLINK_DIR=build-target CLUSTER_MODE=cluster 
test-infra/end-to-end-test/test_streaming_kafka010.sh
-   EXIT_CODE=$(($EXIT_CODE+$?))
-
-   printf 
"\n==\n"
-   printf "Running class loading end-to-end test\n"
-   printf 
"==\n"
-   FLINK_DIR=build-target CLUSTER_MODE=cluster 
test-infra/end-to-end-test/test_streaming_classloader.sh
-   EXIT_CODE=$(($EXIT_CODE+$?))
-
-   printf 
"\n==\n"
-   printf "Running Shaded Hadoop S3A end-to-end test\n"
-   printf 
"==\n"
-   FLINK_DIR=build-target CLUSTER_MODE=cluster 
test-infra/end-to-end-test/test_shaded_hadoop_s3a.sh
-   EXIT_CODE=$(($EXIT_CODE+$?))
-
-   printf 
"\n==\n"
-   printf "Running Shaded Presto S3 end-to-end test\n"
-   printf 
"==\n"
-   FLINK_DIR=build-target CLUSTER_MODE=cluster 
test-infra/end-to-end-test/test_shaded_presto_s3.sh
-   EXIT_CODE=$(($EXIT_CODE+$?))
+   if [ $EXIT_CODE == 0 ]; then
+   printf 
"\n==\n"
+   printf "Running Wordcount end-to-end test\n"
+   printf 
"==\n"
+   FLINK_DIR=build-target CLUSTER_MODE=cluster 
test-infra/end-to-end-test/test_batch_wordcount.sh
+   EXIT_CODE=$(($EXIT_CODE+$?))
--- End diff --

If `$EXIT_CODE == 0` then why not simply set `EXIT_CODE=$?`?


> Skip remaining E2E tests if one failed
> --
>
> Key: FLINK-8079
> URL: https://issues.apache.org/jira/browse/FLINK-8079
> Project: Flink
>  Issue Type: Improvement
>  Components: Tests
>Affects Versions: 1.4.0, 1.5.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
> Fix For: 1.5.0, 1.4.1
>
>
> I propose that if one end-to-end tests fails the remaining tests are skipped.
> [~aljoscha] What do you think?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-8079) Skip remaining E2E tests if one failed

2017-12-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-8079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293069#comment-16293069
 ] 

ASF GitHub Bot commented on FLINK-8079:
---

Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/5156
  
I like the change+1

Minor: Is there a way to write `if code != 0 return` in bash? Might be 
easier to read...


> Skip remaining E2E tests if one failed
> --
>
> Key: FLINK-8079
> URL: https://issues.apache.org/jira/browse/FLINK-8079
> Project: Flink
>  Issue Type: Improvement
>  Components: Tests
>Affects Versions: 1.4.0, 1.5.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
> Fix For: 1.5.0, 1.4.1
>
>
> I propose that if one end-to-end tests fails the remaining tests are skipped.
> [~aljoscha] What do you think?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-8079) Skip remaining E2E tests if one failed

2017-12-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-8079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287573#comment-16287573
 ] 

ASF GitHub Bot commented on FLINK-8079:
---

GitHub user zentol opened a pull request:

https://github.com/apache/flink/pull/5156

[FLINK-8079][tests] Stop end-to-end test execution after first failure

## What is the purpose of the change

This PR modifies the travis maven script to stop the execution of 
end-to-end tests once the first failure was detected.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zentol/flink 8079

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/5156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5156


commit 3faf3707a3134cfdd40bfa0870d4e3e01579e10b
Author: zentol 
Date:   2017-12-12T13:04:34Z

[FLINK-8079][tests] Stop end-to-end test execution after first failure




> Skip remaining E2E tests if one failed
> --
>
> Key: FLINK-8079
> URL: https://issues.apache.org/jira/browse/FLINK-8079
> Project: Flink
>  Issue Type: Improvement
>  Components: Tests
>Affects Versions: 1.4.0, 1.5.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
> Fix For: 1.5.0, 1.4.1
>
>
> I propose that if one end-to-end tests fails the remaining tests are skipped.
> [~aljoscha] What do you think?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-8079) Skip remaining E2E tests if one failed

2017-11-15 Thread Aljoscha Krettek (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-8079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253631#comment-16253631
 ] 

Aljoscha Krettek commented on FLINK-8079:
-

Sounds good!

> Skip remaining E2E tests if one failed
> --
>
> Key: FLINK-8079
> URL: https://issues.apache.org/jira/browse/FLINK-8079
> Project: Flink
>  Issue Type: Improvement
>  Components: Tests
>Affects Versions: 1.4.0, 1.5.0
>Reporter: Chesnay Schepler
>
> I propose that if one end-to-end tests fails the remaining tests are skipped.
> [~aljoscha] What do you think?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)