[jira] [Commented] (FLINK-8257) Unify the value checks for setParallelism()

2018-01-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-8257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308219#comment-16308219
 ] 

ASF GitHub Bot commented on FLINK-8257:
---

Github user xccui closed the pull request at:

https://github.com/apache/flink/pull/5192


> Unify the value checks for setParallelism()
> ---
>
> Key: FLINK-8257
> URL: https://issues.apache.org/jira/browse/FLINK-8257
> Project: Flink
>  Issue Type: Improvement
>  Components: Configuration
>Reporter: Xingcan Cui
>Assignee: Xingcan Cui
> Fix For: 1.5.0
>
>
> The {{setParallelism()}} method exist in many components from different 
> levels. Some of the methods require the input value to be greater than {{1}} 
> (e.g., {{StreamTransformation.setParallelism()}}), while some of them also 
> allow the value to be {{ExecutionConfig.PARALLELISM_DEFAULT}}, which is 
> {{-1}} by default (e.g., {{DataSink.setParallelism()}}). We need to unify the 
> value checks for these methods.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-8257) Unify the value checks for setParallelism()

2018-01-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-8257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308218#comment-16308218
 ] 

ASF GitHub Bot commented on FLINK-8257:
---

Github user xccui commented on the issue:

https://github.com/apache/flink/pull/5192
  
Thanks for the review, @aljoscha  . I'll close this PR.


> Unify the value checks for setParallelism()
> ---
>
> Key: FLINK-8257
> URL: https://issues.apache.org/jira/browse/FLINK-8257
> Project: Flink
>  Issue Type: Improvement
>  Components: Configuration
>Reporter: Xingcan Cui
>Assignee: Xingcan Cui
> Fix For: 1.5.0
>
>
> The {{setParallelism()}} method exist in many components from different 
> levels. Some of the methods require the input value to be greater than {{1}} 
> (e.g., {{StreamTransformation.setParallelism()}}), while some of them also 
> allow the value to be {{ExecutionConfig.PARALLELISM_DEFAULT}}, which is 
> {{-1}} by default (e.g., {{DataSink.setParallelism()}}). We need to unify the 
> value checks for these methods.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-8257) Unify the value checks for setParallelism()

2018-01-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-8257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308106#comment-16308106
 ] 

ASF GitHub Bot commented on FLINK-8257:
---

Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/5192
  
Thanks for fixing this!  

I merged, could you please close the PR?


> Unify the value checks for setParallelism()
> ---
>
> Key: FLINK-8257
> URL: https://issues.apache.org/jira/browse/FLINK-8257
> Project: Flink
>  Issue Type: Improvement
>  Components: Configuration
>Reporter: Xingcan Cui
>Assignee: Xingcan Cui
> Fix For: 1.5.0
>
>
> The {{setParallelism()}} method exist in many components from different 
> levels. Some of the methods require the input value to be greater than {{1}} 
> (e.g., {{StreamTransformation.setParallelism()}}), while some of them also 
> allow the value to be {{ExecutionConfig.PARALLELISM_DEFAULT}}, which is 
> {{-1}} by default (e.g., {{DataSink.setParallelism()}}). We need to unify the 
> value checks for these methods.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-8257) Unify the value checks for setParallelism()

2017-12-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-8257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299729#comment-16299729
 ] 

ASF GitHub Bot commented on FLINK-8257:
---

Github user xccui commented on the issue:

https://github.com/apache/flink/pull/5192
  
Hi @aljoscha, I wonder if you could help review this PR when you are 
convenient. 

Thanks, Xingcan


> Unify the value checks for setParallelism()
> ---
>
> Key: FLINK-8257
> URL: https://issues.apache.org/jira/browse/FLINK-8257
> Project: Flink
>  Issue Type: Improvement
>  Components: Configuration
>Reporter: Xingcan Cui
>Assignee: Xingcan Cui
>
> The {{setParallelism()}} method exist in many components from different 
> levels. Some of the methods require the input value to be greater than {{1}} 
> (e.g., {{StreamTransformation.setParallelism()}}), while some of them also 
> allow the value to be {{ExecutionConfig.PARALLELISM_DEFAULT}}, which is 
> {{-1}} by default (e.g., {{DataSink.setParallelism()}}). We need to unify the 
> value checks for these methods.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-8257) Unify the value checks for setParallelism()

2017-12-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-8257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298303#comment-16298303
 ] 

ASF GitHub Bot commented on FLINK-8257:
---

GitHub user xccui opened a pull request:

https://github.com/apache/flink/pull/5192

[FLINK-8257] [conf] Unify the value checks for setParallelism()

## What is the purpose of the change

This PR unifies the value checks for `setParallelism()` methods in 
different components.

## Brief change log

 flink-java:
Updates the error message in 
`org.apache.flink.api.java.operators.Operator.setParallelism()`.

 flink-streaming-java:
Refines the check in `StreamTransformation.setParallelism()`.
Changes the value check to `parallelism != 1` in 
`DataStreamSource.setParallelism()`.
Removes the value checks in `SingleOutputStreamOperator.setParallelism()` 
and `StreamExecutionEnvironment.setParallelism()`.

 flink-gelly:
Updates the error messages for `setParallelism()` methods in 
`GraphAnalyticBase`, `IterationConfiguration` and `GraphAlgorithmWrappingBase`.

The methods in flink-runtime package were kept unchanged.

Since `org.apache.flink.api.common.operators.Operator.setParallelism()` is 
only used internally, no extra check was provided for it.

## Verifying this change
This change is already covered by existing tests

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (no)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
  - The serializers: (no)
  - The runtime per-record code paths (performance sensitive): (no)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  - The S3 file system connector: (no)

## Documentation

  - Does this pull request introduce a new feature? (no)
  - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xccui/flink FLINK-8257

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/5192.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5192


commit 44681d1a06373c5e9e723bd202ee053aaf95b3e8
Author: Xingcan Cui 
Date:   2017-12-20T09:11:12Z

[FLINK-8257] [conf] Unify the value checks for setParallelism()




> Unify the value checks for setParallelism()
> ---
>
> Key: FLINK-8257
> URL: https://issues.apache.org/jira/browse/FLINK-8257
> Project: Flink
>  Issue Type: Improvement
>  Components: Configuration
>Reporter: Xingcan Cui
>Assignee: Xingcan Cui
>
> The {{setParallelism()}} method exist in many components from different 
> levels. Some of the methods require the input value to be greater than {{1}} 
> (e.g., {{StreamTransformation.setParallelism()}}), while some of them also 
> allow the value to be {{ExecutionConfig.PARALLELISM_DEFAULT}}, which is 
> {{-1}} by default (e.g., {{DataSink.setParallelism()}}). We need to unify the 
> value checks for these methods.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-8257) Unify the value checks for setParallelism()

2017-12-14 Thread Eron Wright (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-8257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291536#comment-16291536
 ] 

Eron Wright  commented on FLINK-8257:
-

Related: in some cases the parallelism must be equal to that of the preceding 
operator. 
e.g. 
[DataStream::assignTimestampsAndWatermarks|https://github.com/apache/flink/blob/release-1.4.0/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/DataStream.java#L833]

> Unify the value checks for setParallelism()
> ---
>
> Key: FLINK-8257
> URL: https://issues.apache.org/jira/browse/FLINK-8257
> Project: Flink
>  Issue Type: Improvement
>  Components: Configuration
>Reporter: Xingcan Cui
>
> The {{setParallelism()}} method exist in many components from different 
> levels. Some of the methods require the input value to be greater than {{1}} 
> (e.g., {{StreamTransformation.setParallelism()}}), while some of also allow 
> the value to be {{ExecutionConfig.PARALLELISM_DEFAULT}}, which is {{-1}} by 
> default (e.g., {{DataSink.setParallelism()}}). We need to unify the value 
> checks for these methods.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)