[jira] [Commented] (FLINK-8280) Enable checkstyle for org.apache.flink.runtime.blob

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316831#comment-16316831
 ] 

ASF GitHub Bot commented on FLINK-8280:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/5175


> Enable checkstyle for org.apache.flink.runtime.blob
> ---
>
> Key: FLINK-8280
> URL: https://issues.apache.org/jira/browse/FLINK-8280
> Project: Flink
>  Issue Type: Improvement
>  Components: Checkstyle
>Affects Versions: 1.4.0
>Reporter: Nico Kruber
>Assignee: Nico Kruber
> Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-8280) Enable checkstyle for org.apache.flink.runtime.blob

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316236#comment-16316236
 ] 

ASF GitHub Bot commented on FLINK-8280:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/5175
  
looks good to me, merging.


> Enable checkstyle for org.apache.flink.runtime.blob
> ---
>
> Key: FLINK-8280
> URL: https://issues.apache.org/jira/browse/FLINK-8280
> Project: Flink
>  Issue Type: Improvement
>  Components: Checkstyle
>Affects Versions: 1.4.0
>Reporter: Nico Kruber
>Assignee: Nico Kruber
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-8280) Enable checkstyle for org.apache.flink.runtime.blob

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307903#comment-16307903
 ] 

ASF GitHub Bot commented on FLINK-8280:
---

Github user NicoK commented on a diff in the pull request:

https://github.com/apache/flink/pull/5175#discussion_r159209751
  
--- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobUtils.java ---
@@ -150,8 +150,7 @@ static File initLocalStorageDirectory(String basePath) 
throws IOException {
File storageDir;
 
// NOTE: although we will be using UUIDs, there may be 
collisions
-   final int MAX_ATTEMPTS = 10;
-   for(int attempt = 0; attempt < MAX_ATTEMPTS; attempt++) {
+   for (int attempt = 0; attempt < 10; attempt++) {
--- End diff --

ok, sure - I admit, I was tempted to change it and went for it - let me 
change that back


> Enable checkstyle for org.apache.flink.runtime.blob
> ---
>
> Key: FLINK-8280
> URL: https://issues.apache.org/jira/browse/FLINK-8280
> Project: Flink
>  Issue Type: Improvement
>  Components: Checkstyle
>Affects Versions: 1.4.0
>Reporter: Nico Kruber
>Assignee: Nico Kruber
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-8280) Enable checkstyle for org.apache.flink.runtime.blob

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298650#comment-16298650
 ] 

ASF GitHub Bot commented on FLINK-8280:
---

Github user greghogan commented on a diff in the pull request:

https://github.com/apache/flink/pull/5175#discussion_r158056059
  
--- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobUtils.java ---
@@ -150,8 +150,7 @@ static File initLocalStorageDirectory(String basePath) 
throws IOException {
File storageDir;
 
// NOTE: although we will be using UUIDs, there may be 
collisions
-   final int MAX_ATTEMPTS = 10;
-   for(int attempt = 0; attempt < MAX_ATTEMPTS; attempt++) {
+   for (int attempt = 0; attempt < 10; attempt++) {
--- End diff --

Should we keep and simply rename the constant?


> Enable checkstyle for org.apache.flink.runtime.blob
> ---
>
> Key: FLINK-8280
> URL: https://issues.apache.org/jira/browse/FLINK-8280
> Project: Flink
>  Issue Type: Improvement
>  Components: Checkstyle
>Affects Versions: 1.4.0
>Reporter: Nico Kruber
>Assignee: Nico Kruber
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-8280) Enable checkstyle for org.apache.flink.runtime.blob

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294957#comment-16294957
 ] 

ASF GitHub Bot commented on FLINK-8280:
---

GitHub user NicoK opened a pull request:

https://github.com/apache/flink/pull/5175

[FLINK-8280][checkstyle] fix checkstyle in BlobServer and BlobUtils

## What is the purpose of the change

This commits enables checkstyle in the `org.apache.flink.runtime.blob` 
package and fixes the few remaining issues

## Brief change log

- enable checkstyle for  `org.apache.flink.runtime.blob`
- fix checkstyle errors in  `org.apache.flink.runtime.blob`

## Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): **no**
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: **no**
  - The serializers: **no**
  - The runtime per-record code paths (performance sensitive): **no**
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
  - The S3 file system connector: **no**

## Documentation

  - Does this pull request introduce a new feature? **no**
  - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/NicoK/flink flink-8280

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/5175.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5175


commit 5f4b1864a2ec8dd257d804c3887be78662cb2c7e
Author: Nico Kruber 
Date:   2017-12-18T12:22:13Z

[FLINK-8280][checkstyle] enable and fix checkstyle in BlobServer and 
BlobUtils




> Enable checkstyle for org.apache.flink.runtime.blob
> ---
>
> Key: FLINK-8280
> URL: https://issues.apache.org/jira/browse/FLINK-8280
> Project: Flink
>  Issue Type: Improvement
>  Components: Checkstyle
>Affects Versions: 1.4.0
>Reporter: Nico Kruber
>Assignee: Nico Kruber
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)